RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1081932 - the return value of API virNodeDevice.listCaps() is not correct
Summary: the return value of API virNodeDevice.listCaps() is not correct
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Ján Tomko
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-28 08:27 UTC by Xuesong Zhang
Modified: 2015-03-05 07:33 UTC (History)
6 users (show)

Fixed In Version: libvirt-1.2.7-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-05 07:33:28 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:0323 0 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2015-03-05 12:10:54 UTC

Description Xuesong Zhang 2014-03-28 08:27:01 UTC
Description of problem:
the reture value of API virNodeDevice.listCaps() is not correct

Version-Release number of selected component:
libvirt-1.1.1-29.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. find one rhel7 host, and check the libvirt python API
# python 
Python 2.7.5 (default, Feb 11 2014, 07:46:25) 
[GCC 4.8.2 20140120 (Red Hat 4.8.2-13)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import libvirt
>>> conn = libvirt.open('')
>>> node_obj = conn.nodeDeviceLookupByName('pci_0000_00_19_0')
>>> node_capabilities = node_obj.listCaps()

2. check the return value of API virNodeDevice.listCaps(), it's NULL.
>>> print node_capabilities
[]

3. find one rhel6 host, run the same scenario, it will return the expect value.
......
>>> print node_capabilities
['pci']

Actual result:
As step 2

Expected results:
The return value should not be NULL, should be samilar with step 3.

Additional info:
Check the python API on rhel6 and rhel7, it's same.

Comment 1 Ján Tomko 2014-03-29 05:57:17 UTC
Fixed by commit 15a173fc13b4a16707a0d88b17a8a631791a4083
Author:     Jincheng Miao <jmiao>
CommitDate: 2014-03-29 06:51:10 +0100

    Fix virNodeDeviceListCaps always returns empty
    
    virNodeDeviceListCaps will always return empty for a pci nodedevice,
    actually it should return 'pci'.
    
    It is because the loop variable ncaps isn't increased.
    
    Introduced by commit be2636f.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1081932
    
    Signed-off-by: Jincheng Miao <jmiao>
    Signed-off-by: Ján Tomko <jtomko>

git describe: v1.2.3-rc1-9-g15a173f

Comment 3 hongming 2014-11-24 07:29:22 UTC
Verify it as follows. The result is expected. Move its status to VERIFIED.

# rpm -q libvirt libvirt-python
libvirt-1.2.8-8.el7.x86_64
libvirt-python-1.2.8-5.el7.x86_64


# cat test.py 
import libvirt

conn = libvirt.open('')
nodedev = conn.nodeDeviceLookupByName('pci_0000_00_19_0')
node_capabilities = nodedev.listCaps()
print node_capabilities

# python test.py
['pci']

Comment 5 errata-xmlrpc 2015-03-05 07:33:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html


Note You need to log in before you can comment on or make changes to this bug.