Bug 1082342 - Review Request: nodejs-multimatch - Adds multiple patterns support to minimatch.match()
Summary: Review Request: nodejs-multimatch - Adds multiple patterns support to minimat...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Tom Hughes
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: nodejs-reviews 1082343
TreeView+ depends on / blocked
Reported: 2014-03-30 13:12 UTC by Jamie Nguyen
Modified: 2014-03-31 19:33 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2014-03-31 19:33:18 UTC
Type: ---
tom: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Jamie Nguyen 2014-03-30 13:12:08 UTC
Spec URL: http://jamielinux.fedorapeople.org/gruntjs/nodejs-multimatch.spec
SRPM URL: http://jamielinux.fedorapeople.org/gruntjs/SRPMS/nodejs-multimatch-0.1.0-1.fc21.src.rpm
Fedora Account System Username: jamielinux

Adds multiple patterns support to minimatch.match().

Comment 1 Tom Hughes 2014-03-30 17:52:40 UTC
This has a dependency on lodash 2.4.1 but 1.3.1 is the current version in rawhide.

Comment 2 Tom Hughes 2014-03-30 17:56:10 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Spec file according to URL is the same as in SRPM.

Installation errors
INFO: mock.py version 1.1.36 starting...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Mock Version: 1.1.36
INFO: Mock Version: 1.1.36
Start: lock buildroot
INFO: installing package(s): /home/tom/1082342-nodejs-multimatch/results/nodejs-multimatch-0.1.0-1.fc21.noarch.rpm
ERROR: Command failed: 
 # ['/usr/bin/yum', '--installroot', '/var/lib/mock/compton-rawhide-x86_64/root/', 'install', '/home/tom/1082342-nodejs-multimatch/results/nodejs-multimatch-0.1.0-1.fc21.noarch.rpm']
Error: Package: nodejs-multimatch-0.1.0-1.fc21.noarch (/nodejs-multimatch-0.1.0-1.fc21.noarch)
           Requires: npm(lodash) >= 2.4.1
           Installing: nodejs-lodash-1.3.1-3.fc20.noarch (fedora)
               npm(lodash) = 1.3.1
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest

Checking: nodejs-multimatch-0.1.0-1.fc21.noarch.rpm
nodejs-multimatch.noarch: W: only-non-binary-in-usr-lib
nodejs-multimatch.noarch: W: dangling-symlink /usr/lib/node_modules/multimatch/node_modules/minimatch /usr/lib/node_modules/minimatch
nodejs-multimatch.noarch: W: dangling-symlink /usr/lib/node_modules/multimatch/node_modules/lodash /usr/lib/node_modules/lodash
nodejs-multimatch.src: W: spelling-error Summary(en_US) minimatch -> mini match, mini-match, mismatch
nodejs-multimatch.src: W: spelling-error %description -l en_US minimatch -> mini match, mini-match, mismatch
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

nodejs-multimatch (rpmlib, GLIBC filtered):


Source checksums
http://registry.npmjs.org/multimatch/-/multimatch-0.1.0.tgz :
  CHECKSUM(SHA256) this package     : 71288d4030c7b8e243526e0f530d1dc956e0716e462cef1d74f34d024a5daf26
  CHECKSUM(SHA256) upstream package : 71288d4030c7b8e243526e0f530d1dc956e0716e462cef1d74f34d024a5daf26

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1082342
Buildroot used: compton-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

Comment 3 Jamie Nguyen 2014-03-30 18:38:44 UTC
(In reply to Tom Hughes from comment #1)
> This has a dependency on lodash 2.4.1 but 1.3.1 is the current version in
> rawhide.

I've posted updates for a handful of packages earlier today but must not have reached mirrors yet:


Comment 4 Jamie Nguyen 2014-03-30 18:42:28 UTC
(In reply to Tom Hughes from comment #2)
> [!]: If the source package does not include license text(s) as a separate
> file
>      from upstream, the packager SHOULD query upstream to include it.

I opened a whole bunch of pull requests for a lot of this person's other modules and they were all closed. The reason was "don't want clutter".

Comment 5 Tom Hughes 2014-03-30 19:26:10 UTC
I guess in that case it's not worth pursuing, and it's only a SHOULD so package is approved.

Comment 6 Jamie Nguyen 2014-03-30 21:28:15 UTC
New Package SCM Request
Package Name: nodejs-multimatch
Short Description: Adds multiple patterns support to minimatch.match()
Owners: jamielinux patches
Branches: f19 f20 el6

Comment 7 Gwyn Ciesla 2014-03-31 11:52:17 UTC
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.