Spec URL: https://raw.githubusercontent.com/RussianFedora/gimp-wavelet-denoise-plugin/master/gimp-wavelet-denoise-plugin.spec SRPM URL: http://koji.russianfedora.pro/kojifiles/work/tasks/2692/2692/gimp-wavelet-denoise-plugin-0.3.1-2.fc21.R.src.rpm Description: The wavelet denoise plugin is a tool to reduce noise in each channel of an image separately. The default colour space to do denoising is YCbCr which has the advantage that chroma noise can be reduced without affecting image details. Denoising in CIELAB (L*a*b*) or RGB is available as an option. The user interface allows colour mode and preview channel selection. The denoising threshold can be set for each colour channel independently. License COPYING file contain wrong FSF address, but upstream looks dead.
See bug 1063144 for gimp macros.
This macros shipped only with rawhide gimp. In f20, f19 and el6 macros is absent.
And if I want use macroses I must add to BuildRequires: gimp?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2)". Detailed output of licensecheck: GPL (v2) -------- wavelet-denoise-0.3.1/src/colorspace.c wavelet-denoise-0.3.1/src/denoise.c wavelet-denoise-0.3.1/src/events.c wavelet-denoise-0.3.1/src/interface.c wavelet-denoise-0.3.1/src/interface.h wavelet-denoise-0.3.1/src/messages.h wavelet-denoise-0.3.1/src/plugin.c wavelet-denoise-0.3.1/src/plugin.h wavelet-denoise-0.3.1/src/wavelet.c [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: gimp-wavelet-denoise-plugin-0.3.1-2.fc21.i686.rpm gimp-wavelet-denoise-plugin-0.3.1-2.fc21.src.rpm gimp-wavelet-denoise-plugin.i686: W: spelling-error %description -l en_US colour -> color, co lour, co-lour gimp-wavelet-denoise-plugin.i686: W: spelling-error %description -l en_US denoising -> noising gimp-wavelet-denoise-plugin.i686: W: spelling-error %description -l en_US chroma -> chrome, chromatic gimp-wavelet-denoise-plugin.i686: W: spelling-error %description -l en_US Denoising -> Noising gimp-wavelet-denoise-plugin.i686: W: invalid-url URL: http://registry.gimp.org/node/4235 <urlopen error timed out> gimp-wavelet-denoise-plugin.i686: E: incorrect-fsf-address /usr/share/doc/gimp-wavelet-denoise-plugin/COPYING gimp-wavelet-denoise-plugin.src: W: spelling-error %description -l en_US colour -> color, co lour, co-lour gimp-wavelet-denoise-plugin.src: W: spelling-error %description -l en_US denoising -> noising gimp-wavelet-denoise-plugin.src: W: spelling-error %description -l en_US chroma -> chrome, chromatic gimp-wavelet-denoise-plugin.src: W: spelling-error %description -l en_US Denoising -> Noising 2 packages and 0 specfiles checked; 1 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint gimp-wavelet-denoise-plugin gimp-wavelet-denoise-plugin.i686: W: spelling-error %description -l en_US colour -> color, co lour, co-lour gimp-wavelet-denoise-plugin.i686: W: spelling-error %description -l en_US denoising -> noising gimp-wavelet-denoise-plugin.i686: W: spelling-error %description -l en_US chroma -> chrome, chromatic gimp-wavelet-denoise-plugin.i686: W: spelling-error %description -l en_US Denoising -> Noising gimp-wavelet-denoise-plugin.i686: E: incorrect-fsf-address /usr/share/doc/gimp-wavelet-denoise-plugin/COPYING 1 packages and 0 specfiles checked; 1 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- gimp-wavelet-denoise-plugin (rpmlib, GLIBC filtered): gimp libatk-1.0.so.0 libc.so.6 libcairo.so.2 libfontconfig.so.1 libfreetype.so.6 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgimp-2.0.so.0 libgimpbase-2.0.so.0 libgimpcolor-2.0.so.0 libgimpconfig-2.0.so.0 libgimpmath-2.0.so.0 libgimpmodule-2.0.so.0 libgimpui-2.0.so.0 libgimpwidgets-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libpthread.so.0 rtld(GNU_HASH) Provides -------- gimp-wavelet-denoise-plugin: gimp-wavelet-denoise-plugin gimp-wavelet-denoise-plugin(x86-32) Source checksums ---------------- http://registry.gimp.org/files/wavelet-denoise-0.3.1.tar.gz : CHECKSUM(SHA256) this package : 430d6cf0a641656c251d11fe1635f8859836b0e784770024a41da3c33482383b CHECKSUM(SHA256) upstream package : 430d6cf0a641656c251d11fe1635f8859836b0e784770024a41da3c33482383b Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn gimp-wavelet-denoise-plugin-0.3.1-2.fc21.R.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ------------------------------------------------- (In reply to Vasiliy Glazov from comment #3) > And if I want use macroses I must add to BuildRequires: gimp? Yes. I think the macro file can be moved to devel tools subpackage, but I can't decide it. For now, the gimp macro shouldn't be an issue. PACKAGE APPROVED.
One forgot to say: install src/wavelet-denoise %{buildroot}$GIMP_PLUGINS_DIR/plug-ins Use -p and -m
OK, done http://koji.russianfedora.pro/kojifiles/work/tasks/4601/4601/gimp-wavelet-denoise-plugin-0.3.1-3.fc21.R.src.rpm
New Package SCM Request ======================= Package Name: gimp-wavelet-denoise-plugin Short Description: Gimp wavelet denoise plugin Owners: vascom Branches: f20 f19 el6 InitialCC:
Git done (by process-git-requests).
gimp-wavelet-denoise-plugin-0.3.1-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/gimp-wavelet-denoise-plugin-0.3.1-3.fc20
gimp-wavelet-denoise-plugin-0.3.1-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/gimp-wavelet-denoise-plugin-0.3.1-3.fc19
gimp-wavelet-denoise-plugin-0.3.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/gimp-wavelet-denoise-plugin-0.3.1-3.el6
gimp-wavelet-denoise-plugin-0.3.1-3.fc19 has been pushed to the Fedora 19 testing repository.
gimp-wavelet-denoise-plugin-0.3.1-3.fc19 has been pushed to the Fedora 19 stable repository.
gimp-wavelet-denoise-plugin-0.3.1-3.fc20 has been pushed to the Fedora 20 stable repository.
gimp-wavelet-denoise-plugin-0.3.1-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/gimp-wavelet-denoise-plugin-0.3.1-4.el6
gimp-wavelet-denoise-plugin-0.3.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.