Bug 1082747 - Postgres Plugin - An Invalid Server Configuration Status Should Not Be Stack Trace
Summary: Postgres Plugin - An Invalid Server Configuration Status Should Not Be Stack ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: Plugin -- Other
Version: JON 3.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: DR01
: JON 3.2.2
Assignee: Thomas Segismont
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks: 1082792
TreeView+ depends on / blocked
 
Reported: 2014-03-31 18:20 UTC by Matt Mahoney
Modified: 2014-07-29 00:17 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-29 00:17:18 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Matt Mahoney 2014-03-31 18:20:05 UTC
Description of problem:
When changing the server configuration to be invalid (i.e. invalid "role name" and/or "role password) Status should be a user readable message instead of a stack trace.

Note: The Server status and Child Resource status do report that there is an issue.

Example:


Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Navigate to Inventory.Connection Settings, and then change "role name" to an invalid value.
2. Click Save button, and then click "Connection Settings History", and then explore the Status message/text (aka: stack trace)
3.

Actual results:
Status text is a stack trace.

Expected results:
Status text should be more readable, and not a stack trace. 

Additional info:

Comment 1 Thomas Segismont 2014-04-08 14:46:19 UTC
Pushed to master

commit dbeedced3664c0cda68f4a53b5bc789647cdd5f6
Author: Thomas Segismont <tsegismo>
Date:   Tue Apr 8 16:43:56 2014 +0200

Throwing an Exception is the only way a plugin component can fail the process of starting of a resource. So without changing the agent plugin facet we can't really avoid the stack trace shown on the server.
   
Still, the stack trace shown when a Postgres server resource is configured with invalid credentials was particularly long, so I changed the plugin component implementation to make the server show a stack trace with no cause and a condensed message ("Invalid password").

Comment 2 Thomas Segismont 2014-05-09 15:20:34 UTC
Cherry-picked over to release/jon3.2.x

commit 2076253a9be9e085a9b08d61d447490b6f369269
Author: Thomas Segismont <tsegismo>
Date:   Tue Apr 8 16:43:56 2014 +0200

Comment 3 Simeon Pinder 2014-05-22 15:15:39 UTC
Via product triage, determined that this bug is to be included for DR01 target milestone.

Comment 4 Simeon Pinder 2014-05-30 02:43:38 UTC
Moving to ON_QA as available for test in latest cumulative patch build(DR01):
http://jon01.mw.lab.eng.bos.redhat.com:8042/dist/release/jon/3.2.2.GA/5-29-2014/

Comment 5 Matt Mahoney 2014-06-02 19:05:02 UTC
Verified JON 3.2.2 DR1

Comment 6 Larry O'Leary 2014-07-29 00:17:18 UTC
This has been verified and released in Red Hat JBoss Operations Network 3.2 Update 02 (3.2.2) available from the Red Hat Customer Portal[1].



[1]: https://access.redhat.com/jbossnetwork/restricted/softwareDetail.html?softwareId=31783


Note You need to log in before you can comment on or make changes to this bug.