Upon creating a DirectLUN disk, it was mandatory to supply a disk format (COW/RAW). However, disk format is relevant only for images not DirectLUNs disks; hence, removed disk format validation so specifying it in the request is not required now.
Created attachment 881349[details]
engine/vdsm logs
Description of problem:
When adding a Direct LUN through REST api:
<disk>
<name>test_lun</name>
<alias>test_lun</alias>
<interface>virtio</interface>
<bootable>false</bootable>
<shareable>false</shareable>
<wipe_after_delete>false</wipe_after_delete>
<propagate_errors>false</propagate_errors>
<lun_storage id="360060160f4a030002635d37fd01be311">
<logical_unit id="360060160f4a030002635d37fd01be311">
<serial>SDGC_VRAID_CKM00121000438</serial>
<vendor_id>DGC</vendor_id>
<product_id>VRAID</product_id>
<lun_mapping>3</lun_mapping>
<disk_id>761f8200-f713-424c-9e7d-cd140426c1c4</disk_id>
</logical_unit>
</lun_storage>
</disk>
And not passing disk format (COW, RAW), the response is:
<fault>
<reason>Incomplete parameters</reason>
<detail>Disk [format] required for add</detail>
</fault>
And it's should not be required because the lun is already exists.
Version-Release number of selected component (if applicable):
How reproducible:
100%
Steps to Reproduce:
1. Add direct lun like example above
2.
3.
Actual results:
<fault>
<reason>Incomplete parameters</reason>
<detail>Disk [format] required for add</detail>
</fault>
Expected results:
Response code ok: 200
Additional info:
(In reply to Allon Mureinik from comment #1)
> Juan,
>
> Seems specific to this object - should one of my team members take it off
> your hand?
Yes, please.
Created attachment 881349 [details] engine/vdsm logs Description of problem: When adding a Direct LUN through REST api: <disk> <name>test_lun</name> <alias>test_lun</alias> <interface>virtio</interface> <bootable>false</bootable> <shareable>false</shareable> <wipe_after_delete>false</wipe_after_delete> <propagate_errors>false</propagate_errors> <lun_storage id="360060160f4a030002635d37fd01be311"> <logical_unit id="360060160f4a030002635d37fd01be311"> <serial>SDGC_VRAID_CKM00121000438</serial> <vendor_id>DGC</vendor_id> <product_id>VRAID</product_id> <lun_mapping>3</lun_mapping> <disk_id>761f8200-f713-424c-9e7d-cd140426c1c4</disk_id> </logical_unit> </lun_storage> </disk> And not passing disk format (COW, RAW), the response is: <fault> <reason>Incomplete parameters</reason> <detail>Disk [format] required for add</detail> </fault> And it's should not be required because the lun is already exists. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. Add direct lun like example above 2. 3. Actual results: <fault> <reason>Incomplete parameters</reason> <detail>Disk [format] required for add</detail> </fault> Expected results: Response code ok: 200 Additional info: