RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1083345 - The --memspec parameters "snapshot=no" doesn't work when creating internal disk snapshot
Summary: The --memspec parameters "snapshot=no" doesn't work when creating internal di...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Peter Krempa
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 1083346
TreeView+ depends on / blocked
 
Reported: 2014-04-02 03:07 UTC by Shanzhi Yu
Modified: 2015-03-05 07:33 UTC (History)
6 users (show)

Fixed In Version: libvirt-1.2.7-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1083346 (view as bug list)
Environment:
Last Closed: 2015-03-05 07:33:39 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:0323 0 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2015-03-05 12:10:54 UTC

Description Shanzhi Yu 2014-04-02 03:07:27 UTC 
Description of problem:

The --memspec parameters "snapshot=no" doesn't work when creating internal disk snapshot

Version-Release number of selected component (if applicable):

libvirt-1.1.1-29.el7.x86_64
qemu-kvm-rhev-1.5.3-59.el7ev.x86_64

How reproducible:

100%

Steps to Reproduce:
1.define an guest and keep it running status
# virsh list --name --state-running
rhel6.5

2.try to create internal disk-only snapshot
# virsh snapshot-create-as rhel6.5 diskonly-internal1   --memspec snapshot=no --diskspec vda,snapshot=internal --diskspec vdb,snapshot=internal
Domain snapshot diskonly-internal1 created

3. check snapshot info
# virsh snapshot-dumpxml rhel6.5  diskonly-internal1
<domainsnapshot>
  <name>diskonly-internal1</name>
  <state>running</state>
  <parent>
    <name>diskonly-internal</name>
  </parent>
  <creationTime>1396342930</creationTime>
  <memory snapshot='internal'/>
  <disks>
    <disk name='vda' snapshot='internal'/>
    <disk name='vdb' snapshot='internal'/>
  </disks>

Actual results:

As above.

Expected results:

1) Suppose we support internal disk-only snapshot, we should succeed creating such snapshot in step3
2) If we don't support internal disk-only snapshot, it should come up with some error info when creating it as in step 2

Additional info:
Comment 2 Eric Blake 2014-05-29 14:05:22 UTC 
qemu 1.7 added the blockdev-snapshot-internal-sync QMP command which would let us do a disk-only internal snapshot. We have not wired that up in libvirt yet.
Comment 3 Peter Krempa 2014-05-30 07:28:13 UTC 
The original problem was fixed upstream with

commit d2e668e535fd62810eb268351e9e74a483efd0d4
Author: Peter Krempa <pkrempa>
Date:   Thu May 29 10:52:57 2014 +0200

    qemu: snapshot: Reject internal active snapshot without memory state
    
    A internal snapshot of a active VM with the memory snapshot disabled
    explicitly would actually still take the memory snapshot. Reject it
    explicitly.
    
    Before:
     $ virsh snapshot-create-as --domain VM --diskspec vda,snapshot=internal --memspec snapshot=no
     Domain snapshot 1401353155 created
    
    After:
     $ virsh snapshot-create-as --domain VM --diskspec vda,snapshot=internal --memspec snapshot=no
     error: Operation not supported: internal snapshot of a running VM must include the memory state
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1083345

I'll open a bug to add the support for internal snapshots
Comment 5 Yang Yang 2014-09-26 06:34:12 UTC 
Verified it on 
qemu-kvm-rhev-2.1.0-5.el7.x86_64
libvirt-1.2.8-3.el7.x86_64

# virsh list --all
 Id    Name                           State
----------------------------------------------------
 2     qe-con                         running

# virsh snapshot-create-as qe-con --memspec snapshot=no --diskspec hda,snapshot=internal
error: Operation not supported: internal snapshot of a running VM must include the memory state

Since the results is expected, set the status to verified.
Comment 7 errata-xmlrpc 2015-03-05 07:33:39 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html
Note You need to log in before you can comment on or make changes to this bug.