RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:

In case the kernel sets the "needs_check" flag on thin provisioning metadata
because of an io error, "thin_check --clear-needs-check" resets it
erroneously even when metadata is in error causing the pool to be reloaded in read/write mode rather than read-only.

This is critical, because the metadata errors have not been fixed thus
potentially causing more damage if activated read/write.


Version-Release number of selected component (if applicable):


How reproducible:

Always.
device-mapper-test-suite contains a test (-n /NeedsCheck/)

Steps to Reproduce:
1. Set up device-mapper-test-suite as described in README.md
2. Run "dmsetup run --suite era -n /NeedsCheck/
3.

Actual results:
Test fails.

Expected results:
Test succeeds.

Additional info:

Created attachment 881811 [details]
Log of device-mapper-test-suite NeedsCheck test case run

Proper command to run the test is:

"dmtest run --suite thin-provisioning -n /NeedsCheck/"