Bug 1084007 - Review Request: google-roboto-fonts - Google Roboto fonts
Summary: Review Request: google-roboto-fonts - Google Roboto fonts
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-03 11:53 UTC by David Tardon
Modified: 2018-01-13 22:34 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-04-07 12:58:17 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Tardon 2014-04-03 11:53:27 UTC
Spec URL: http://dtardon.fedorapeople.org/rpm/google-roboto-fonts.spec
SRPM URL: http://dtardon.fedorapeople.org/rpm/google-roboto-fonts-1.2-1.fc20.src.rpm
Description:
Roboto is a sans-serif typeface family introduced with Android Ice Cream Sandwich operating system. Google describes the font as "modern, yet approachable" and "emotional".

Fedora Account System Username: dtardon

Comment 1 Parag AN(पराग) 2014-04-07 06:06:04 UTC
Issues:

1) It's better to use subpackage name -common and not -license. See http://fedoraproject.org/wiki/Fonts_spec_template_for_multiple_fonts suggests using -common for common files needed by all other packages.

2) Requires: fontpackages-filesystem is missing for -condensed-fonts subpackage. 

The other simple way is to add it to -common and let -common be required by google-roboto-fonts and google-roboto-condensed-fonts. This way -common will provide LICENSE.txt file and you can also add RobotoSpecimenBook.pdf as a  %doc

If you add -common then let it alone Requires: fontpackages-filesystem

3) Group tag is no longer needed.

4) Summary can be "Google Roboto fonts"

Comment 3 Parag AN(पराग) 2014-04-07 09:03:09 UTC
Review:

+ Package built fine in mock on rawhide

+ rpmlint on generated rpms gave
google-roboto-condensed-fonts.noarch: W: no-documentation
google-roboto-fonts.noarch: W: no-documentation
google-roboto-fonts.src: W: invalid-url Source0: http://developer.android.com/downloads/design/roboto-1.2.zip HTTP Error 405: Method Not Allowed
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as  (sha256sum)
source tarball:5101b5bdb3b7b14cc922a771ba068bfcae8634467c1f446bc89bc2b4f8b4f1b5
srpm tarball:5101b5bdb3b7b14cc922a771ba068bfcae8634467c1f446bc89bc2b4f8b4f1b5

+ fontconfig rules provided and follow fonts packaging guidelines.

APPROVED.

Comment 4 David Tardon 2014-04-07 09:19:32 UTC
New Package SCM Request
=======================
Package Name: google-roboto-fonts
Short Description: Google Roboto fonts
Owners: dtardon
Branches: f19 f20
InitialCC:

Comment 5 Parag AN(पराग) 2014-04-07 09:23:09 UTC
I request please re-submit above request with addition as
IntialCC: fonts-sig i18n-team

Comment 6 David Tardon 2014-04-07 09:31:23 UTC
New Package SCM Request
=======================
Package Name: google-roboto-fonts
Short Description: Google Roboto fonts
Owners: dtardon
Branches: f19 f20
InitialCC: fonts-sig i18n-team

Comment 7 Gwyn Ciesla 2014-04-07 12:23:00 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2017-12-29 21:23:17 UTC
google-roboto-fonts-2.138-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-30d4a534b6

Comment 9 Fedora Update System 2018-01-13 22:34:26 UTC
google-roboto-fonts-2.138-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.