Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1084103

Summary: Shareable and bootable disk shouldn't be allowed
Product: Red Hat Enterprise Virtualization Manager Reporter: Raz Tamir <ratamir>
Component: ovirt-engineAssignee: Idan Shaby <ishaby>
Status: CLOSED WONTFIX QA Contact: Raz Tamir <ratamir>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.4.0CC: amureini, iheim, lpeer, michal.skrivanek, ofrenkel, rbalakri, Rhev-m-bugs, scohen, tnisan, yeylon
Target Milestone: ---Keywords: Reopened
Target Release: 3.5.0Flags: scohen: needinfo+
scohen: needinfo+
amureini: Triaged+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: Doc Type: Release Note
Doc Text:
Cause: Two operating systems try to write simultaneously to a shareable and bootable disk. Consequence: The disk will probably get corrupted. Fix: The UI and REST API are blocked from setting a disk to be both shareable and bootable. Also, when upgrading the engine, a script will set each shareable and bootable disk to be shareable only. Result: There are no disks which are both bootable and shareable.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-11 16:14:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1138335, 1138346    

Description Raz Tamir 2014-04-03 15:26:49 UTC
Description of problem:
When adding new disk as bootable, there is an option to select it also as shareable and vice versa.



Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create new disk as bootable
2. Select it also as shareable
3.

Actual results:
The disk added successfully 

Expected results:
After 1 of the two options is selected, the other one should be greyed out

Additional info:

Comment 1 Tal Nisan 2014-04-06 12:47:19 UTC
No reason to block this option since this is by design, one can have a bootable disk on one VM yet have it shared as a regular disk on another VM without any complications, having the same disk shared and bootable on multiple VMs might pose some problems indeed but as in every shareable disk this is the user's responsibility to use this option cautiously.

Comment 2 Raz Tamir 2014-04-06 13:17:29 UTC
If the reason for not blocking this, is because this is the design then the design is wrong.
The scenario you mentioned is impossible. There is no option to share a bootable disk as regular disk on another vm.
It will complain that the disk you are trying is already marked as boot.
This attribute (boot) is Disk's attribute and not per attach so it is impossible to select the disk as regular for the other vm.

Comment 3 Sean Cohen 2014-04-07 12:18:48 UTC
Indeed, this is a loose end, that was not covered in the 3.2 fix... 
[See Bug 854964 - [Storage] There is a scenario when VM might have several bootable disks which is wrong]

Sean

Comment 4 Allon Mureinik 2014-04-08 22:28:23 UTC
I don't see a problem with this behavior - several VMs share a boot disk, and each can have its own data disk.

Sean - up to you.

Comment 5 Omer Frenkel 2014-08-28 06:24:41 UTC
Sean, can you please answer the question on comment #4 the meaning of the fix will be that vms will not start, and the user will not know exactly what happened.

i also think that its possible to share the boot disk between vms, i dont understand how it can be corrupted, i thought shared is readonly

Comment 6 Allon Mureinik 2014-08-28 07:28:05 UTC
(In reply to Omer Frenkel from comment #5)
> i also think that its possible to share the boot disk between vms, i dont
> understand how it can be corrupted, i thought shared is readonly
"shared" and "readonly" are orthogonal - you may very well have a shared r/w disk. In such a case, it's up to the user to ensure that multiple writes won't corrupt the disk (e.g., by using a clustered filesystem).

Comment 7 Allon Mureinik 2014-08-28 07:34:18 UTC
Having said that, I agree with Omer that this may be overthinking it. Under the philosophy of "don't nanny the user", we leave this configuration enabled, and allow "power" users who know what they're doing to utilize it.

Comment 8 Michal Skrivanek 2014-09-04 13:42:19 UTC
I'd support more freedom as well. We have a bad past experience when trying to outsmart the users:)

Comment 9 Sean Cohen 2014-09-05 20:51:22 UTC
(In reply to Omer Frenkel from comment #5)
> Sean, can you please answer the question on comment #4 the meaning of the
> fix will be that vms will not start, and the user will not know exactly what
> happened.
> 
> i also think that its possible to share the boot disk between vms, i dont
> understand how it can be corrupted, i thought shared is readonly

Freedom is good, but we also need to protect the user from ending up in a corrupted state.

This can be solved of course with the proper warning, to minimize human errors.

Sharing a bootable does has it use cases, as clustering configurations etc.
The point is the admin need to select this option for a reason and be aware of its possible implications.

Sean

Comment 10 Allon Mureinik 2014-09-07 09:01:01 UTC
(In reply to Sean Cohen from comment #9)
> (In reply to Omer Frenkel from comment #5)
> > Sean, can you please answer the question on comment #4 the meaning of the
> > fix will be that vms will not start, and the user will not know exactly what
> > happened.
> > 
> > i also think that its possible to share the boot disk between vms, i dont
> > understand how it can be corrupted, i thought shared is readonly
> 
> Freedom is good, but we also need to protect the user from ending up in a
> corrupted state.
> 
> This can be solved of course with the proper warning, to minimize human
> errors.
> 
> Sharing a bootable does has it use cases, as clustering configurations etc.
> The point is the admin need to select this option for a reason and be aware
> of its possible implications.
> 
> Sean

OK - so we're going to allow this, and issue a warning.
Sean - please provide the text you want there.

Comment 12 Allon Mureinik 2014-11-03 12:30:09 UTC
The issue existed since 3.1 and we received exactly 0 customer tickets or upstream user reports on it.

Since this isn't getting any traction on the needinfo (see comment 10), pushing out to 3.6.0 until we get a decision.

Comment 13 Allon Mureinik 2014-12-11 16:14:41 UTC
Closing, not worth the hassle.