Bug 1084147 - tests/bugs/bug-767095.t needs to be more robust. It's failing on long hostnames.
Summary: tests/bugs/bug-767095.t needs to be more robust. It's failing on long hostna...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: tests
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Justin Clift
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-03 17:27 UTC by Justin Clift
Modified: 2015-07-13 04:35 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-11 08:29:25 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Justin Clift 2014-04-03 17:27:25 UTC
Description of problem:

  tests/bugs/bug-767095.t is failing in Rackspace, due to the VMs there having
  long hostnames, which the test isn't able to cope with.

    # tests/bugs/bug-767095.t
    1..19
    ok 1
    ok 2
    No volumes present
    ok 3
    ok 4
    ok 5
    ok 6
    ok 7
    ok 8
    ok 9
    ok 10
    ok 11
    ok 12
    kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill -l [sigspec]
    not ok 13 
    ok 14
    ok 15
    ok 16
    ok 17
    ok 18

  The failing piece of code in the test is this:

    TEST PID=`gluster volume status $V0 | grep patchy1 | awk {'print $5'}`;

  It's expecting output similar to this:

    Status of volume: patchy
    Gluster process						Port	Online	Pid
    ------------------------------------------------------------------------------
    Brick 127.1.1.1:/d/backends/1/patchy			49152	Y	21977
    Brick 127.1.1.2:/d/backends/2/patchy			49154	Y	21996
    Brick 127.1.1.3:/d/backends/3/patchy			49155	Y	22027

  When a hostname is fairly long though, the output from "gluster volume status $V0" wraps around to the next line, so the awk statement doesn't capture the PID.

    Status of volume: patchy
    Gluster process						Port	Online	Pid
    ------------------------------------------------------------------------------
    Brick jc-api-test-node0.cloud.gluster.org:/d/backends/p
atchy1							49160	Y	24658
    Brick jc-api-test-node0.cloud.gluster.org:/d/backends/p
atchy2							49161	Y	24670
    Brick jc-api-test-node0.cloud.gluster.org:/d/backends/p
atchy3							49162	Y	24681

  This can probably be fixed by using --xml mode or similar, which shouldn't have the same problem.

Version-Release number of selected component (if applicable):

  Upstream GlusterFS git master, as of Thu 3rd April 2014.
  commit 997c89b6172116557f981510a94232486ec526b0


How reproducible:

  Every time.

Comment 1 Anand Avati 2014-04-03 17:39:56 UTC
REVIEW: http://review.gluster.org/7395 (tests: Adjust test 767095 to cope with long hostnames) posted (#1) for review on master by Justin Clift (justin)

Comment 2 Anand Avati 2014-04-04 13:29:24 UTC
COMMIT: http://review.gluster.org/7395 committed in master by Vijay Bellur (vbellur) 
------
commit 27bc6a07b4c82409845077aed0556114caa8dc99
Author: Justin Clift <justin>
Date:   Thu Apr 3 18:33:19 2014 +0100

    tests: Adjust test 767095 to cope with long hostnames
    
    BUG: 1084147
    Change-Id: Ie1ff8852a501690e681072c54620d305b5e20d6a
    Signed-off-by: Justin Clift <justin>
    Reviewed-on: http://review.gluster.org/7395
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2014-09-22 12:37:28 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 4 Niels de Vos 2014-11-11 08:29:25 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.