Bug 1084503 - Add explicit dependency on python-requests
Summary: Add explicit dependency on python-requests
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: linkchecker
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-04 14:09 UTC by Alex Wood
Modified: 2014-04-23 07:43 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-04-23 05:49:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Alex Wood 2014-04-04 14:09:26 UTC
Description of problem:
Linkchecker depends on python-requests (in director/aggregator.py and url.py for example) but there is no explicit Requires on it in the spec file.

Version-Release number of selected component (if applicable): linkchecker.x86_64 0:9.0-1.fc20

How reproducible: Always

Steps to Reproduce:
1. Ensure that python-requests is not installed.
2. yum install linkchecker
3. linkchecker http://fedoraproject.org

Actual results:
Traceback (most recent call last):
  File "/usr/bin/linkchecker", line 34, in <module>
    from linkcheck.cmdline import print_version, print_usage, aggregate_url, \
  File "/usr/lib64/python2.7/site-packages/linkcheck/cmdline.py", line 23, in <module>
    from . import checker, fileutil, strformat, plugins
  File "/usr/lib64/python2.7/site-packages/linkcheck/checker/__init__.py", line 24, in <module>
    from .. import strformat, url as urlutil, log, LOG_CHECK
  File "/usr/lib64/python2.7/site-packages/linkcheck/url.py", line 25, in <module>
    import requests
ImportError: No module named requests

Expected results:
A successful run of linkchecker.

Additional info:
To add to the issue, linkchecker requires a newer version of python-requests than what is available in Fedora 20.  If you use the python-requests that's in Fedora 20, you'll run into https://github.com/wummel/linkchecker/issues/478  I'm going to file a bug against python-requests and I'll update this one with that bug number.

Comment 1 Alex Wood 2014-04-04 14:12:39 UTC
I have opened Bug #1084505 to request that python-requests be updated to the latest upstream.

Comment 2 Christopher Meng 2014-04-23 05:49:00 UTC
I've added the relevant requires in the SPEC after building 9.1 ;-)

This bug should be solved from 9.2 at least.

Thanks!

Comment 3 Fedora Update System 2014-04-23 07:43:15 UTC
linkchecker-9.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/linkchecker-9.1-1.fc20


Note You need to log in before you can comment on or make changes to this bug.