Bug 1084956 - gitk displays truncated tag
Summary: gitk displays truncated tag
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: git
Version: 20
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Chris Wright
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-07 11:39 UTC by Jeremy Harris
Modified: 2014-05-29 15:31 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-05-29 15:31:33 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot of offending tag marker (16.79 KB, image/png)
2014-04-07 11:39 UTC, Jeremy Harris
no flags Details

Description Jeremy Harris 2014-04-07 11:39:22 UTC
Created attachment 883589 [details]
screenshot of offending tag marker

Description of problem:
 In the list-of-commits pane gitk displays only "tag..." for the tag marker.  This is a regression from previous version and makes the marker much less useful.


Version-Release number of selected component (if applicable):
 gitk.noarch 0:1.9.0-1.fc20


How reproducible:
 100%


Steps to Reproduce:
1. Run gitk on a tree having tags
2.
3.

Actual results:
 "tag..."


Expected results:
 "kernel-2.6.32-453.el6"


Additional info:
 1.8.4.2-1.fc20 operates as expected.

Comment 1 Ondrej Oprala 2014-05-29 15:31:33 UTC
the newer versions of gitk seems to have weird word-wrapping settings. 
The upstream commit that introduces this "enhancement" states:

gitk: Tag display improvements
    
    When a commit has many tags, the tag icons in the graph display can
    easily become so wide as to push the commit message off the right-hand
    edge of the graph display pane.  This changes the display so that if
    there are more than 3 tags or they would take up more than a quarter
    of the width of the pane, we instead display a single tag icon with
    a legend inside it like "4 tags...".  If the user clicks on the tag
    icon, gitk then displays all the tags in the diff display pane.

What's even better is that this is hardcoded and cannot be changed from ~/.gitk.
If you do want the old behaviour, my only advice is to hack at gitk (not a binary, just a tcl script).
In particular, you need to change the lines:
set maxtags 3
set maxtagpct 25

Thanks for the report.


Note You need to log in before you can comment on or make changes to this bug.