Bug 1085360 - Migrations incorrectly create tables using MyISAM storage engine
Summary: Migrations incorrectly create tables using MyISAM storage engine
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-neutron
Version: 5.0 (RHEL 7)
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 5.0 (RHEL 7)
Assignee: Jakub Libosvar
QA Contact: Ofer Blaut
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-08 12:57 UTC by John Eckersberg
Modified: 2016-04-26 19:45 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-28 11:10:17 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description John Eckersberg 2014-04-08 12:57:33 UTC
When running Neutron migrations against MySQL, most tables are incorrectly created using the MyISAM storage engine.  Instead, they should be created using the InnoDB storage engine.

I've described the problem in detail in the upstream bug:

https://bugs.launchpad.net/neutron/+bug/1288358

I've also submitted a patch for the issue:

https://review.openstack.org/81334

However the patch is likely out of date now, and really needs some tests added.  I've left a comment about the tests on the review but I'll repeat it here:

"""
One thing I definitely would like to add is a test to make sure there's only InnoDB tables. Nova has a test for that:

https://git.openstack.org/cgit/openstack/nova/tree/nova/tests/db/test_migrations.py?id=c032ab8696aa4b2cb0cebd5f711e123b1e3b0ed7#n400

Otherwise this is just going to keep happening in the future.
"""

I'm not familiar with the Neutron tests and I don't know when/if I'll have the time to sit down and figure it out.  If someone more familiar can write the test(s) and fix up anything out of date, it would be great.  

This is breaking Neutron with the ml2 driver.  More details are in this long and meandering bug:

https://bugzilla.redhat.com/show_bug.cgi?id=1017281

I've purposefully split this bug out to filter the noise from that bug.


Note You need to log in before you can comment on or make changes to this bug.