Spec URL: https://github.com/elmiko/fedorapkg_openstack-sahara/raw/master/openstack-sahara.spec SRPM URL: https://github.com/elmiko/fedorapkg_openstack-sahara/raw/master/openstack-sahara-2014.1.rc1-1.fc20.src.rpm Description: Apache Hadoop cluster management on OpenStack Fedora Account System Username: mimccune This review request is for a version upgrade and a rename of the package openstack-savanna. I am not including the rpmlint output in this request as it generates several long warnings and a few errors. Some of the errors pertain to .py files beginning with a shbang and not having executable bits set, these files are used by distutils to create executable scripts during install. The remaining errors are all noted in the spec file. http://koji.fedoraproject.org/koji/taskinfo?taskID=6718510
Created attachment 884976 [details] updated spec file changing __python to __python2 enabling some unittests
Created attachment 884977 [details] updated source rpm rebuilding after spec change
* removed unittests SPEC/SRPM urls updated
Just a few issues here, Mike. Issues: ======= - several rpmlint errors here: - non-executable-script ones can be handled either by removing the shebang or changing mode - the dir and conf permissions are justified; thanks for commenting on these - Large documentation must go in a -doc subpackage. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - The Obsoletes should capture %dist tags in releases, so "openstack-savanna <= 2014.1.b3-3" instead of "openstack-savanna <= 2014.1.b3-2" - are you using this spec for EPEL too? if not, %defattr is unnecessary Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. - see above; "openstack-savanna <= 2014.1.b3-3" is correct [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines - except as mentioned [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. - absence justified [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openstack-sahara-2014.1.rc1-1.fc21.noarch.rpm openstack-sahara-2014.1.rc1-1.fc21.src.rpm openstack-sahara.noarch: W: non-standard-uid /var/lib/sahara sahara openstack-sahara.noarch: W: non-standard-gid /var/lib/sahara sahara openstack-sahara.noarch: E: non-standard-dir-perm /var/lib/sahara 0700L openstack-sahara.noarch: W: non-standard-uid /var/log/sahara sahara openstack-sahara.noarch: W: non-standard-gid /var/log/sahara sahara openstack-sahara.noarch: W: non-standard-gid /etc/sahara/sahara.conf sahara openstack-sahara.noarch: E: non-readable /etc/sahara/sahara.conf 0640L openstack-sahara.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/sahara/cli/sahara_api.py 0644L /usr/bin/env openstack-sahara.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/sahara/cli/sahara_subprocess.py 0644L /usr/bin/env openstack-sahara.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/sahara/plugins/vanilla/v2_3_0/resources/post_conf.template 0644L /bin/bash openstack-sahara.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/openstack-sahara/html/_static/jquery.js openstack-sahara.noarch: W: log-files-without-logrotate /var/log/sahara openstack-sahara.noarch: W: no-manual-page-for-binary _sahara-subprocess openstack-sahara.noarch: W: no-manual-page-for-binary sahara-api openstack-sahara.noarch: W: no-manual-page-for-binary sahara-db-manage 2 packages and 0 specfiles checked; 5 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint openstack-sahara openstack-sahara.noarch: W: non-standard-uid /var/lib/sahara sahara openstack-sahara.noarch: W: non-standard-gid /var/lib/sahara sahara openstack-sahara.noarch: E: non-standard-dir-perm /var/lib/sahara 0700L openstack-sahara.noarch: W: non-standard-uid /var/log/sahara sahara openstack-sahara.noarch: W: non-standard-gid /var/log/sahara sahara openstack-sahara.noarch: W: non-standard-gid /etc/sahara/sahara.conf sahara openstack-sahara.noarch: E: non-readable /etc/sahara/sahara.conf 0640L openstack-sahara.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/sahara/cli/sahara_api.py 0644L /usr/bin/env openstack-sahara.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/sahara/cli/sahara_subprocess.py 0644L /usr/bin/env openstack-sahara.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/sahara/plugins/vanilla/v2_3_0/resources/post_conf.template 0644L /bin/bash openstack-sahara.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/openstack-sahara/html/_static/jquery.js openstack-sahara.noarch: W: log-files-without-logrotate /var/log/sahara openstack-sahara.noarch: W: no-manual-page-for-binary _sahara-subprocess openstack-sahara.noarch: W: no-manual-page-for-binary sahara-api openstack-sahara.noarch: W: no-manual-page-for-binary sahara-db-manage 1 packages and 0 specfiles checked; 5 errors, 10 warnings. # echo 'rpmlint-done:' Requires -------- openstack-sahara (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/python2 config(openstack-sahara) python(abi) python-alembic python-cinderclient python-eventlet python-flask python-iso8601 python-jsonschema python-keystoneclient python-neutronclient python-novaclient python-oslo-config python-oslo-messaging python-paramiko python-pbr python-six python-sqlalchemy python-stevedore python-swiftclient python-webob shadow-utils systemd Provides -------- openstack-sahara: config(openstack-sahara) openstack-sahara openstack-savanna Source checksums ---------------- http://tarballs.openstack.org/sahara/sahara-2014.1.rc1.tar.gz : CHECKSUM(SHA256) this package : 867ed0e937b2d5db4239d827c172910ea1120614154f240fed186488986dc182 CHECKSUM(SHA256) upstream package : 867ed0e937b2d5db4239d827c172910ea1120614154f240fed186488986dc182 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1085441 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
* updating the obsoletes to have proper dist * removing shbang from 2 python files in prep phase * adding execute bit to script template in prep phase * removed %defattr As to the documentation, I agree that splitting it into openstack-sahara-doc is probably the proper thing to do. The docs are more than just text files for this package, they also represent a Python Sphinx build.
* added a subpackage for docs * added backward compatibility for __python2 macro SPEC/SRPM urls updated
* added LICENSE file to doc subpackage
* doc subpackage adjusted to use _pkgdocdir for documentation files * added require on master package for sub package
Please post a new comment with the updated Spec URL:, SRPM URL: and Description: tags, so that tools like fedora-review can pick it up automatically. Don't be afraid to bump release numbers. I also notice that 2014.1 official has been released, so you might as well bump to that in the version for the next comment. thanks!
SPEC URL: http://mimccune.fedorapeople.org/openstack-sahara.spec SRPM URL: http://mimccune.fedorapeople.org/openstack-sahara-2014.1.0-1.fc20.src.rpm Description: Apache Hadoop cluster management on OpenStack * added new upstream version 2014.1 * changing upstream tarball location to launchpad.net instead of tarballs.openstack.org * modifying spec to eliminate self-obsoletion warnings
SPEC URL: http://mimccune.fedorapeople.org/openstack-sahara.spec SRPM URL: http://mimccune.fedorapeople.org/openstack-sahara-2014.1.0-1.fc20.src.rpm Description: Apache Hadoop cluster management on OpenStack * changing upstream tarball location back to orignal value This was changed back mainly to keep this package consistent with historical versions pending more investigation on the launchpad location.
Thanks for making the changes, Mike! Everything looks good to me now.
New Package SCM Request ======================= Package Name: openstack-sahara Short Description: Apache Hadoop cluster management on OpenStack Owners: mimccune Branches: f20 el6 epel7 InitialCC: willb
Git done (by process-git-requests).
openstack-sahara-2014.1.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openstack-sahara-2014.1.0-1.fc20
openstack-sahara-2014.1.0-1.fc20 has been pushed to the Fedora 20 testing repository.
openstack-sahara-2014.1.0-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openstack-sahara-2014.1.0-4.fc20
openstack-sahara-2014.1.0-5.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openstack-sahara-2014.1.0-5.fc20
openstack-sahara-2014.1.0-6.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openstack-sahara-2014.1.0-6.fc20
openstack-sahara-2014.1.0-7.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openstack-sahara-2014.1.0-7.fc20
openstack-sahara-2014.1.0-8.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openstack-sahara-2014.1.0-8.fc20
openstack-sahara-2014.1.0-10.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openstack-sahara-2014.1.0-10.fc20
openstack-sahara-2014.1.0-12.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openstack-sahara-2014.1.0-12.fc20
openstack-sahara-2014.1.0-13.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openstack-sahara-2014.1.0-13.fc20
openstack-sahara-2014.1.0-13.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.