Bug 1085706 – virsh numatune should forbid to accept int as parameter values

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1085706 - virsh numatune should forbid to accept int as parameter values

Summary:	virsh numatune should forbid to accept int as parameter values

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	libvirt (Show other bugs)
Sub Component:
Version:	7.0
Hardware:	Unspecified Unspecified

Priority	low Severity low
Target Milestone:	rc
Target Release:	---
Assigned To:	Martin Kletzander
QA Contact:	Virtualization Bugs
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2014-04-09 03:47 EDT by hongming
Modified:	2015-03-05 02:33 EST (History)
CC List:	4 users (show)

See Also:
Fixed In Version:	libvirt-1.2.7-1.el7
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2015-03-05 02:33:47 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2015:0323	normal	SHIPPED_LIVE	Low: libvirt security, bug fix, and enhancement update	2015-03-05 07:10:54 EST

Groups: None (edit)

Description hongming 2014-04-09 03:47:43 EDT

Description of problem:
virsh numatune should forbid to accept int as parameter values. Maybe modify manual and help and add description about integer parameters
 

Version-Release number of selected component (if applicable):
libvirt-1.1.1-29.el7.x86_64 

How reproducible:
100% 

Steps to Reproduce:
[root@ibm-x3850x5-05 ~]# virsh help numatune
  NAME
    numatune - Get or set numa parameters

  SYNOPSIS
    numatune <domain> [<mode>] [<nodeset>] [--config] [--live] [--current]

  DESCRIPTION
    Get or set the current numa parameters for a guest domain.
    To get the numa parameters use following command:

    virsh # numatune <domain>

  OPTIONS
    [--domain] <string>  domain name, id or uuid
    [--mode] <string>  NUMA mode, one of strict, preferred and interleave
    [--nodeset] <string>  NUMA node selections to set
    --config         affect next boot
    --live           affect running domain
    --current        affect current domain


[root@ibm-x3850x5-05 ~]# virsh numatune rhel7
numa_mode      : strict
numa_nodeset   : 0

[root@ibm-x3850x5-05 ~]# virsh numatune rhel7 0 1

[root@ibm-x3850x5-05 ~]# virsh numatune rhel7
numa_mode      : strict
numa_nodeset   : 1 

Actual results:
When pass integer as mode value , numatune can change the nodeset. 

Expected results:
virsh numatune should forbid to accept int as parameter values. Maybe modify manual and help and add description about integer parameters.

Additional info:

Comment 2 Martin Kletzander 2014-07-09 09:12:13 EDT

Fixed upstream with v1.2.6-114-gfd59f6c:

commit fd59f6c83e5f3dbb44ad93de0568f9f3158fbb4d
Author: Martin Kletzander <mkletzan@redhat.com>
Date:   Wed Jul 9 09:53:14 2014 +0200

    virsh: document the possibility of accepting integers for numatune mode

Comment 4 Jincheng Miao 2014-11-19 04:21:23 EST

The verification steps are:

# virsh numatune r71
numa_mode      : strict
numa_nodeset   : 

1. pass '0' as strict mode
# virsh numatune r71 0 1

# virsh numatune r71
numa_mode      : strict
numa_nodeset   : 1

2. pass '1' as preferred mode
# virsh numatune r71 1 1

# virsh numatune r71
numa_mode      : preferred
numa_nodeset   : 1

3. pass '2' as interleave mode
# virsh numatune r71 2 1

# virsh numatune r71
numa_mode      : interleave
numa_nodeset   : 1

4. pass invalid number
# virsh numatune r71 3 1
error: Unable to change numa parameters
error: invalid argument: unsupported numatune mode: '3'

# virsh numatune r71 -1 1
error: Unable to change numa parameters
error: invalid argument: unsupported numatune mode: '-1'

So change the status to VERIFIED.

Comment 5 Jincheng Miao 2014-11-19 04:23:22 EST

In addition, the doc has been updated:
# virsh help numatune
...
    [--mode] <string>  NUMA mode, one of strict, preferred and interleave 
or a number from the virDomainNumatuneMemMode enum
...

Comment 7 errata-xmlrpc 2015-03-05 02:33:47 EST

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html

Note You need to log in before you can comment on or make changes to this bug.