Spec URL: http://anishpatil.fedorapeople.org/nodejs-strip-json-comments.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-strip-json-comments-0.1.1-1.fc20.src.rpm Description: Strip comments from JSON. Lets you use comments in your JSON files! Fedora Account System Username: anishpatil
Preliminary comments: * Needs an ExclusiveArch: %{nodejs_arches} noarch * The second %setup is not needed * You're installing cli.js twice, once with the cp then overwriting it with the install * Is there a reason for adding the -nodejs suffix to the installed binary? * Need to ask upstream to add a proper copy of the license, and add one yourself until then
Hi Tom Hughes! Thank you for package review and review comments, I have incorporated all the comments please find new spec and SRPM file on Spec URL: http://anishpatil.fedorapeople.org/nodejs-strip-json-comments.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-strip-json-comments-0.1.1-2.fc20.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues ====== [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. - You should ask upstream to include the licese file. [!]: Latest version is packaged. - Version 0.1.2 has been release. [!]: %check is present and all tests pass. - There are some tests (the test.js file) upstream but they're not in the npm tar ball, so you should probably either include them as a separate source file, or package from github so that you can run them in the %check section. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nodejs-strip-json-comments-0.1.1-2.fc21.noarch.rpm nodejs-strip-json-comments-0.1.1-2.fc21.src.rpm nodejs-strip-json-comments.noarch: W: only-non-binary-in-usr-lib nodejs-strip-json-comments.noarch: W: no-manual-page-for-binary strip-json-comments 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-strip-json-comments nodejs-strip-json-comments.noarch: W: only-non-binary-in-usr-lib nodejs-strip-json-comments.noarch: W: no-manual-page-for-binary strip-json-comments 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- nodejs-strip-json-comments (rpmlib, GLIBC filtered): /usr/bin/env nodejs(engine) Provides -------- nodejs-strip-json-comments: nodejs-strip-json-comments npm(strip-json-comments) Source checksums ---------------- http://registry.npmjs.org/strip-json-comments/-/strip-json-comments-0.1.1.tgz : CHECKSUM(SHA256) this package : fc9e140bdda44c580b27afa40a4574da6d7e2335e70d86eb0cd8a2c8afcce617 CHECKSUM(SHA256) upstream package : fc9e140bdda44c580b27afa40a4574da6d7e2335e70d86eb0cd8a2c8afcce617 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1086217 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Hi Tom Hughes! Thank you for package review and review comments, I have incorporated few the comments please find new spec and SRPM file on Spec URL: http://anishpatil.fedorapeople.org/nodejs-strip-json-comments.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-strip-json-comments-0.1.2-3.fc20.src.rpm I have created upstream bug for inclusion of license,https://github.com/sindresorhus/strip-json-comments/issues/5 I have included test.js because test cases are broken that is why they have not included in release, i have created bug for that as well https://github.com/sindresorhus/strip-json-comments/issues/6
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nodejs-strip-json-comments-0.1.2-3.fc21.noarch.rpm nodejs-strip-json-comments-0.1.2-3.fc21.src.rpm nodejs-strip-json-comments.noarch: W: only-non-binary-in-usr-lib nodejs-strip-json-comments.noarch: W: no-manual-page-for-binary strip-json-comments 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-strip-json-comments nodejs-strip-json-comments.noarch: W: only-non-binary-in-usr-lib nodejs-strip-json-comments.noarch: W: no-manual-page-for-binary strip-json-comments 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- nodejs-strip-json-comments (rpmlib, GLIBC filtered): /usr/bin/env nodejs(engine) Provides -------- nodejs-strip-json-comments: nodejs-strip-json-comments npm(strip-json-comments) Source checksums ---------------- http://registry.npmjs.org/strip-json-comments/-/strip-json-comments-0.1.2.tgz : CHECKSUM(SHA256) this package : a42668156d5ce1315db072aebc93adeb6733a46a9b74eb853d20ecb128bcda3e CHECKSUM(SHA256) upstream package : a42668156d5ce1315db072aebc93adeb6733a46a9b74eb853d20ecb128bcda3e Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1086217 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Upstream has released 0.1.3 now, which adds the license file. Once you've updated to that I think this is good to go.
Hi Tom Hughes! Thank you for your review comments, please find new SRPMS and spec file on Spec URL: http://anishpatil.fedorapeople.org/nodejs-strip-json-comments.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-strip-json-comments-0.1.3-4.fc20.src.rpm
That looks great now. Package is approved.
New Package SCM Request ======================= Package Name: nodejs-strip-json-comments Short Description: strip comments from json Owners: anishpatil Branches: f20
Git done (by process-git-requests).
nodejs-strip-json-comments-0.1.3-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-strip-json-comments-0.1.3-4.fc20
nodejs-strip-json-comments-0.1.3-4.fc20 has been pushed to the Fedora 20 testing repository.
nodejs-strip-json-comments-0.1.3-4.fc20 has been pushed to the Fedora 20 stable repository.
Hi Anish, Please add el6 and epel7 branches by requesting here Package Change Request. Thanks.
Package Change Request ====================== Package Name: nodejs-strip-json-comments New Branches: el6 epel7 Owners: anishpatil InitialCC: i18n-team
nodejs-strip-json-comments-1.0.2-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-strip-json-comments-1.0.2-1.el7
nodejs-strip-json-comments-1.0.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.