Bug 1086228 - Remove-brick: File permission (setuid) changes after migration of the file
Summary: Remove-brick: File permission (setuid) changes after migration of the file
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: pre-release
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nagaprasad Sathyanarayana
QA Contact:
URL:
Whiteboard:
Depends On: 1061585 1168549
Blocks: 1162119
TreeView+ depends on / blocked
 
Reported: 2014-04-10 12:06 UTC by vsomyaju
Modified: 2016-02-18 00:20 UTC (History)
7 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of: 1061585
Environment:
Last Closed: 2015-05-14 17:25:38 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Comment 1 Anand Avati 2014-04-10 12:22:08 UTC
REVIEW: http://review.gluster.org/7435 ( posix:  Changed order of chown and chmod) posted (#1) for review on master by venkatesh somyajulu (vsomyaju)

Comment 2 Anand Avati 2014-04-10 12:24:28 UTC
REVIEW: http://review.gluster.org/7435 (posix:  Changed order of chown and chmod) posted (#2) for review on master by venkatesh somyajulu (vsomyaju)

Comment 3 Anand Avati 2014-11-13 12:42:38 UTC
REVIEW: http://review.gluster.org/7435 (posix:  Changed order of chown and chmod) posted (#3) for review on master by venkatesh somyajulu (vsomyaju)

Comment 4 Anand Avati 2014-11-14 06:38:10 UTC
REVIEW: http://review.gluster.org/7435 (posix:  Changed order of chown and chmod) posted (#4) for review on master by venkatesh somyajulu (vsomyaju)

Comment 5 Anand Avati 2014-11-14 09:43:12 UTC
COMMIT: http://review.gluster.org/7435 committed in master by Vijay Bellur (vbellur) 
------
commit 3e0a9c04ed86153a2822b92d69b31e20ef5c63f6
Author: Venkatesh Somyajulu <vsomyaju>
Date:   Fri Nov 14 12:06:39 2014 +0530

    posix:  Changed order of chown and chmod
    
        Problem:
        Rebalance process runs in the root mode. If a normal
        user create a file and if it  requires migration then
        because the migrated file is created by root, its owner and
        mode should  be changed to the source normal user and
        permission should be changed the previous mode. If
        the suid bit is also set, then at the destination
        suid bit should also be set.
    
        Two operations are performed in the given order:
        1. chmod
        2. chown
    
        But chown resets the suid bit. So changed the order
        of these two operations so that first chown will be
        performed and then chmod will be performd so that
        suid bit will be preserved.
    
    Change-Id: Ib63b5cf528f8336b69bf090ad43bb02eec1d1602
    BUG: 1086228
    Signed-off-by: Venkatesh Somyajulu <vsomyaju>
    Reviewed-on: http://review.gluster.org/7435
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 7 Niels de Vos 2015-05-14 17:25:38 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:35:26 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:37:47 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 10 Niels de Vos 2015-05-14 17:42:17 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.