Bug 1086443 - Review Request: extra-cmake-modules - Additional functionality for the CMake build system
Summary: Review Request: extra-cmake-modules - Additional functionality for the CMake ...
Keywords:
Status: CLOSED DUPLICATE of bug 1061019
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews kf5
TreeView+ depends on / blocked
 
Reported: 2014-04-10 22:44 UTC by Daniel Vrátil
Modified: 2015-11-02 01:37 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-04-12 05:27:55 UTC
Type: ---
Embargoed:
i: fedora-review?


Attachments (Terms of Use)

Description Daniel Vrátil 2014-04-10 22:44:53 UTC
Spec URL: http://dvratil.fedorapeople.org/kf5/review/extra-cmake-modules.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/extra-cmake-modules-0.0.12-1.src.rpm
Description: The Extra CMake Modules package, or ECM, adds to the modules provided by CMake, including both ones used by `find_package()` to find common software and ones that can be used directly in `CMakeLists.txt` files to perform common tasks.
Fedora Account System Username: dvratil

Comment 1 Christopher Meng 2014-04-11 03:49:54 UTC
1. Release:        1

%{?dist} tag needed.

2. noarch packages don't need this line IMO:

# There's nothing to debug
%global debug_package   %{nil}

Comment 2 Daniel Vrátil 2014-04-11 09:34:21 UTC
Spec URL: http://dvratil.fedorapeople.org/kf5/review/extra-cmake-modules.spec
SRPM URL: http://dvratil.fedorapeople.org/kf5/review/extra-cmake-modules-0.0.12-3.src.rpm

Added %{?dist} and removed debug_package. Earlier snapshots were installing some CMake files to %{_libdir}, so rpmbuild insisted on generating debug packages, but that's not the case anymore.

Comment 4 Christopher Meng 2014-04-12 05:27:55 UTC
Feel free to update this package in Fedora!

I will approve your request if you want!

*** This bug has been marked as a duplicate of bug 1061019 ***


Note You need to log in before you can comment on or make changes to this bug.