Bug 1086768 - Remove unused SysPrep*Path parameters from vdc_options
Summary: Remove unused SysPrep*Path parameters from vdc_options
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.4.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ovirt-3.6.0-rc
: 3.6.0
Assignee: Martin Betak
QA Contact: Ilanit Stein
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-11 12:43 UTC by Pavel Novotny
Modified: 2016-04-20 01:34 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-20 01:34:32 UTC
oVirt Team: Virt
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 34831 0 master MERGED core: Drop legacy SysPrep paths from config Never
oVirt gerrit 35142 0 None None None Never

Description Pavel Novotny 2014-04-11 12:43:58 UTC
Description of problem:
Starting from 3.4, the default paths to sysprep files are no longer stored in DB vdc_options table, but in OS info definition file(s) (by default in /etc/ovirt-engine/osinfo.conf.d/00-defaults.properties).
But the related parameters are still present in the DB which may leave the customer in false belief that sysprep files are still managed via DB/engine-config.

Version-Release number of selected component (if applicable):
rhevm-3.4.0-0.13.beta3.el6ev.noarch (av6)


How reproducible:
100%

Steps to Reproduce:
1. List all SysPrep*Path parameters from configuration (vdc_options table): engine-config -a | egrep 'SysPrep.*Path'
2.
3.

Actual results:

SysPrep*Path parameters are still present (with empty value):

# engine-config -a | egrep 'SysPrep.*Path'
SysPrep2K3Path:  version: general
SysPrep2K8Path:  version: general
SysPrep2K8R2Path:  version: general
SysPrep2K8x64Path:  version: general
SysPrepWindows7Path:  version: general
SysPrepWindows7x64Path:  version: general
SysPrepWindows8Path:  version: general
SysPrepWindows8x64Path:  version: general
SysPrepWindows2012x64Path:  version: general
SysPrepXPPath:  version: general


Expected results:

All SysPrep*Path parameters should be removed from vdc_options as they are defined in OS info file(s) in RHEVM 3.4.


Additional info:

Comment 1 Michal Skrivanek 2014-08-22 12:25:46 UTC
these should be safely dropped as AFAIK they're not in use anymore

Comment 2 Sandro Bonazzola 2014-11-06 13:43:47 UTC
Please either open a BZ on engine-setup which still rely on SysPrep in the DB detailing what should be done or push a patch for fixing it, thanks.

Comment 4 Ilanit Stein 2016-01-21 08:16:10 UTC
Verified on rhevm 3.6.2-10


Note You need to log in before you can comment on or make changes to this bug.