Bug 1086815 - VMware: instance names can be edited, breaks nova-driver lookup
Summary: VMware: instance names can be edited, breaks nova-driver lookup
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-nova
Version: 5.0 (RHEL 7)
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: async
: 4.0
Assignee: Matthew Booth
QA Contact: Jaroslav Henner
URL:
Whiteboard:
Depends On: 1080621
Blocks: 1055536
TreeView+ depends on / blocked
 
Reported: 2014-04-11 14:55 UTC by Scott Lewis
Modified: 2022-07-09 07:56 UTC (History)
7 users (show)

Fixed In Version: openstack-nova-2013.2.3-9.el6ost
Doc Type: Enhancement
Doc Text:
This enhancement allows administrators to rename vSphere virtual machines created by Compute. Previously, Compute used a virtual machine's name to look it up in vSphere, which meant that renaming a virtual machine would make it inaccessible to Compute. However, administrators may want to organise virtual machines in vSphere according to their own conventions. With this change, administrators can now safely rename a vSphere virtual machine created by Compute. Compute now uses other metadata to look up the virtual machine, so it will continue to work.
Clone Of: 1080621
Environment:
Last Closed: 2014-08-21 00:40:14 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1247427 0 None None None Never
Launchpad 1257038 0 None None None Never
Launchpad 1258179 0 None None None Never
OpenStack gerrit 55038 0 None MERGED VMware: bug fix for VM rescue when config drive is configured 2020-06-30 05:03:42 UTC
OpenStack gerrit 59571 0 None MERGED VMware: fix instance lookup against vSphere 2020-06-30 05:03:42 UTC
OpenStack gerrit 60259 0 None MERGED VMware: optimize instance reference access 2020-06-30 05:03:42 UTC
Red Hat Issue Tracker OSP-16678 0 None None None 2022-07-09 07:56:58 UTC
Red Hat Product Errata RHSA-2014:1084 0 normal SHIPPED_LIVE Moderate: openstack-nova security, bug fix, and enhancement update 2014-08-21 04:34:32 UTC

Description Scott Lewis 2014-04-11 14:55:24 UTC
+++ This bug was initially created as a clone of Bug #1080621 +++

Description of problem:

Currently the VMware Nova Driver relies on the VM name in vCenter/ESX to match the UUID in Nova. The name can be easily edited by vCenter administrators and break Nova administration of VMs. A better solution should be found allowing the Nova Compute Driver for vSphere to look up VMs by a less volatile and publicly visible mechanism.

EDIT:
A fix would make the link between vSphere and Nova more solid and involve using a vSphere metadata value that cannot be easily edited. Currently the UUID is stored as an extra config metadata property inside vSphere (associated with the instance's virtual-machine) and
this value is not easy to accidentally change. That would make the link much more robust.

--- Additional comment from Matthew Booth on 2014-04-10 11:16:37 EDT ---

The change listed is dependent on 2 other changes, which I have also backported:

https://review.openstack.org/#/c/55038/
https://review.openstack.org/#/c/60259/
https://review.openstack.org/#/c/59571/

Comment 6 Jaroslav Henner 2014-07-21 13:30:31 UTC
# nova boot --flavor m1.small  --image cirros-0.3.1-x86_64-disk.vmdk foo
* edit the VM name in the vcenter
# nova delete foo

this removed the VM from the VCENTER.


I also tried creating two VMs, rename one of them in the VCENTER, upgrade nova, restart nova, and delete the VMs in openstack. Both VMs got deleted from the vCenter.

Comment 8 errata-xmlrpc 2014-08-21 00:40:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2014-1084.html


Note You need to log in before you can comment on or make changes to this bug.