Bug 108697 - Dodgy handling of nulls in DomainObjectFactory
Dodgy handling of nulls in DomainObjectFactory
Status: CLOSED WONTFIX
Product: Red Hat Web Application Framework
Classification: Retired
Component: other (Show other bugs)
5.2
All Linux
medium Severity medium
: ---
: ---
Assigned To: ccm-bugs-list
Jon Orris
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2003-10-31 05:36 EST by Daniel Berrange
Modified: 2007-04-18 12:59 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-09-02 13:27:03 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Daniel Berrange 2003-10-31 05:36:59 EST
From Bugzilla Helper:
User-Agent: Mozilla/5.0 Galeon/1.2.9 (X11; Linux i686; U;) Gecko/20030314

Description of problem:
There are two bits of code in DomainObjectFactory which do not handle nulls
correctly. This has two effects:

 * It is possible to register an instantiator against a 'null' object type.
 * When recursively looking up instantiators for parent objects types, it will
eventually look up an instantiator for a 'null' object type.

If something accidently registers an instantiator against 'null' type (eg
through typo in the object type string they pass in), then anything which
doesn't have an explicit instantantiator registered suddenly resolves to this
instantiator. 

This is already fixed in Troika & Rickshaw, but needs to be backported to 5.2 as
well

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Register an instantiator against a type which doesn't exist
2. Try & instantiate an object for which no instanatiator is found
3.
    

Actual Results:  It tries to use the instantiator registered against 'null'
object type

Expected Results:  It throws an instantiator not found exception.

Additional info:

p4 change 33290 is suitable for direct application to the 5.2 branch
Comment 1 Daniel Berrange 2006-09-02 13:27:03 EDT
Closing old tickets

Note You need to log in before you can comment on or make changes to this bug.