Bug 1087085 - Review Request: perl-POSIX-strftime-Compiler - GNU C library compatible strftime for loggers and servers
Summary: Review Request: perl-POSIX-strftime-Compiler - GNU C library compatible strf...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1087087
TreeView+ depends on / blocked
 
Reported: 2014-04-13 23:12 UTC by Ralf Corsepius
Modified: 2014-04-27 09:11 UTC (History)
2 users (show)

Fixed In Version: perl-POSIX-strftime-Compiler-0.31-1.fc19
Clone Of:
Environment:
Last Closed: 2014-04-27 09:07:15 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
petersen: fedora-cvs+


Attachments (Terms of Use)

Description Ralf Corsepius 2014-04-13 23:12:34 UTC
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-POSIX-strftime-Compiler.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-POSIX-strftime-Compiler-0.31-1.fc21.src.rpm
Description: 
POSIX::strftime::Compiler provides GNU C library compatible strftime(3).
But this module will not affected by the system locale. This feature is
useful when you want to write loggers, servers and portable applications.

Fedora Account System Username: corsepiu

Additional info: This package is required by newer releases of perl-Apache-LogFormat-Compiler.

Comment 1 Petr Pisar 2014-04-16 14:28:04 UTC
Standalone spec file and the one embedded into SRPM package differ in changelog. I will use the standalone one which has newer time stamp.

URL and Source0 are usable. Ok.
Source archive is original (SHA-256: 45d19aef7e15d975bbe91b7fcd2f2aec650efd182654ed8b146e8b548a61d8f1). Ok.
Summary verified from lib/POSIX/strftime/Compiler.pm. Ok.
Description verified from lib/POSIX/strftime/Compiler.pm. Ok.

TODO: "But this module will not affected by the system locale" description sentence is missing a predicate verb. I guess a "be" is missing there. Please correct the description.

No XS code, noarch BuildArch is Ok.
License verified from lib/POSIX/strftime/Compiler.pm, README.md, and LICENSE. Ok.

TODO: You can remove the line deleting empty directories from %install section. Contemporary Module::Build does suffer from this bug.

Time::TZOffset is optional (lib/POSIX/strftime/Compiler.pm:33,228). Ok.
Module::Build >= 0.38 is provided by all Fedoras. Missing version constrain is Ok.
Build-time dependencies are Ok.
All tests pass. Ok.

$ rpmlint perl-POSIX-strftime-Compiler.spec ../SRPMS/perl-POSIX-strftime-Compiler-0.31-1.fc21.src.rpm ../RPMS/noarch/perl-POSIX-strftime-Compiler-0.31-1.fc21.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-POSIX-strftime-Compiler-0.31-1.fc21.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Apr 16 16:15 /usr/share/doc/perl-POSIX-strftime-Compiler
-rw-r--r--    1 root    root                     1095 Feb 24 07:27 /usr/share/doc/perl-POSIX-strftime-Compiler/Changes
-rw-r--r--    1 root    root                    18418 Feb 24 07:27 /usr/share/doc/perl-POSIX-strftime-Compiler/LICENSE
-rw-r--r--    1 root    root                     2656 Feb 24 07:27 /usr/share/doc/perl-POSIX-strftime-Compiler/README.md
-rw-r--r--    1 root    root                     3000 Apr 16 16:15 /usr/share/man/man3/POSIX::strftime::Compiler.3pm.gz
drwxr-xr-x    2 root    root                        0 Apr 16 16:15 /usr/share/perl5/vendor_perl/POSIX
drwxr-xr-x    2 root    root                        0 Apr 16 16:15 /usr/share/perl5/vendor_perl/POSIX/strftime
-rw-r--r--    1 root    root                    14866 Apr 16 16:15 /usr/share/perl5/vendor_perl/POSIX/strftime/Compiler.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-POSIX-strftime-Compiler-0.31-1.fc21.noarch.rpm | sort | uniq -c
      1 perl >= 0:5.008004
      1 perl(base)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.18.2)
      1 perl(POSIX)
      1 perl(strict)
      1 perl(Time::Local)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-POSIX-strftime-Compiler-0.31-1.fc21.noarch.rpm | sort | uniq -c
      1 perl(POSIX::strftime::Compiler) = 0.31
      1 perl-POSIX-strftime-Compiler = 0.31-1.fc21
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-POSIX-strftime-Compiler-0.31-1.fc21.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6746330). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Please consider fixing all `TODO' items before building this package.
Resolution: Package APPROVED.

Comment 2 Ralf Corsepius 2014-04-16 16:55:44 UTC
Thanks for the review.

New Package SCM Request
=======================
Package Name: perl-POSIX-strftime-Compiler
Short Description: GNU C library compatible strftime for loggers and servers
Owners: corsepiu
Branches: f19 f20
InitialCC: perl-sig

Comment 3 Jens Petersen 2014-04-17 06:11:26 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2014-04-17 07:54:40 UTC
perl-POSIX-strftime-Compiler-0.31-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-POSIX-strftime-Compiler-0.31-1.fc20

Comment 5 Fedora Update System 2014-04-17 07:54:49 UTC
perl-POSIX-strftime-Compiler-0.31-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-POSIX-strftime-Compiler-0.31-1.fc19

Comment 6 Fedora Update System 2014-04-18 15:33:14 UTC
Package perl-POSIX-strftime-Compiler-0.31-1.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing perl-POSIX-strftime-Compiler-0.31-1.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-5287/perl-POSIX-strftime-Compiler-0.31-1.fc19
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2014-04-27 09:07:15 UTC
perl-POSIX-strftime-Compiler-0.31-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2014-04-27 09:11:01 UTC
perl-POSIX-strftime-Compiler-0.31-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.