Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Thread-SigMask.spec SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Thread-SigMask-0.004-1.fc21.src.rpm Description: This module provides per-thread signal masks. On non-threaded perls it will be effectively the same as POSIX::sigprocmask. The interface works exactly the same as sigprocmask. Fedora Account System Username: corsepiu
Looks good. The rpmlint warnings about spelling are obviously worthless, and everything else is copacetic. Here comes some text: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/dshea/1087379-perl-Thread-SigMask/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-Thread-SigMask-0.004-1.fc21.x86_64.rpm perl-Thread-SigMask-0.004-1.fc21.src.rpm perl-Thread-SigMask.x86_64: W: spelling-error %description -l en_US perls -> Perls, peels, perks perl-Thread-SigMask.x86_64: W: spelling-error %description -l en_US sigprocmask perl-Thread-SigMask.src: W: spelling-error %description -l en_US perls -> Perls, peels, perks perl-Thread-SigMask.src: W: spelling-error %description -l en_US sigprocmask 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint perl-Thread-SigMask perl-Thread-SigMask.x86_64: W: spelling-error %description -l en_US perls -> Perls, peels, perks perl-Thread-SigMask.x86_64: W: spelling-error %description -l en_US sigprocmask 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- perl-Thread-SigMask (rpmlib, GLIBC filtered): libc.so.6()(64bit) libperl.so.5.18()(64bit) perl(:MODULE_COMPAT_5.18.2) perl(Exporter) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH) Provides -------- perl-Thread-SigMask: perl(Thread::SigMask) perl-Thread-SigMask perl-Thread-SigMask(x86-64) Unversioned so-files -------------------- perl-Thread-SigMask: /usr/lib64/perl5/vendor_perl/auto/Thread/SigMask/SigMask.so Source checksums ---------------- http://www.cpan.org/authors/id/L/LE/LEONT/Thread-SigMask-0.004.tar.gz : CHECKSUM(SHA256) this package : f4baa4841b990b1fff742d3256dd1a91885603e3fdaf134337dd9dd13408113a CHECKSUM(SHA256) upstream package : f4baa4841b990b1fff742d3256dd1a91885603e3fdaf134337dd9dd13408113a Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1087379 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thanks for the review, David. New Package SCM Request ======================= Package Name: perl-Thread-SigMask Short Description: Thread specific signal masks Owners: corsepiu Branches: f19 f20 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Thread-SigMask-0.004-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Thread-SigMask-0.004-1.fc20
perl-Thread-SigMask-0.004-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Thread-SigMask-0.004-1.fc19
perl-Thread-SigMask-0.004-1.fc19 has been pushed to the Fedora 19 testing repository.
perl-Thread-SigMask-0.004-1.fc20 has been pushed to the Fedora 20 stable repository.
perl-Thread-SigMask-0.004-1.fc19 has been pushed to the Fedora 19 stable repository.