Bug 1087471 - Warning in wicket-ear and wicket-war quickstarts
Summary: Warning in wicket-ear and wicket-war quickstarts
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Quickstarts
Version: 6.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ER5
: EAP 6.3.0
Assignee: sgilda
QA Contact: Nikoleta Hlavickova
Russell Dickenson
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-14 11:57 UTC by Nikoleta Hlavickova
Modified: 2014-06-03 17:31 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-05-21 15:41:35 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Nikoleta Hlavickova 2014-04-14 11:57:09 UTC
WARNING [org.jboss.seam.conversation.spi.SeamConversationContextFactory] (ServerService Thread Pool -- 48) No matching SeamConversationContext for store type interface javax.servlet.http.HttpServletRequest, using NOOP instance!

The warning is logged after the quickstarts deployment.

Comment 1 sgilda 2014-04-14 14:52:13 UTC
I tested the EAP 6.1 version of this quickstart and it appears it put out the same warning.

Adding Ondra, as he is the contributor of this quickstart.

Ondra, do you know what would cause this warning?

Comment 2 sgilda 2014-04-14 15:00:21 UTC
I found this: https://www.42lines.net/2011/11/15/integrating-cdi-into-wicket/
It says you need to add the seam-conversation-weld jar.

Comment 3 Ondřej Žižka 2014-04-14 15:23:54 UTC
Could you please attach the stacktrace? Thanks

Comment 4 sgilda 2014-04-14 15:56:49 UTC
Ondra, there is no stacktrace. It's just a warning message in the server log.

Here is the entire deployment log:

11:55:40,286 INFO  [org.jboss.as.repository] (management-handler-thread - 6) JBAS014900: Content added at location /home/sgilda/tools/jboss-eap-6.3/standalone/data/content/cd/9dde1b1525664eef9548ccc0fc98d2779efb62/content
11:55:40,288 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-9) JBAS015876: Starting deployment of "jboss-wicket-war.war" (runtime-name: "jboss-wicket-war.war")
11:55:40,382 INFO  [org.jboss.as.jpa] (MSC service thread 1-14) JBAS011401: Read persistence.xml for primary
11:55:40,397 INFO  [org.jboss.as.connector.subsystems.datasources] (MSC service thread 1-2) JBAS010400: Bound data source [java:jboss/datasources/WicketQuickstartDS]
11:55:40,405 INFO  [org.jboss.weld.deployer] (MSC service thread 1-1) JBAS016002: Processing weld deployment jboss-wicket-war.war
11:55:40,406 INFO  [org.jboss.as.ejb3.deployment.processors.EjbJndiBindingsDeploymentUnitProcessor] (MSC service thread 1-1) JNDI bindings for session bean named ContactDaoBean in deployment unit deployment "jboss-wicket-war.war" are as follows:

	java:global/jboss-wicket-war/ContactDaoBean!org.jboss.as.quickstarts.wicketWar.dao.ContactDao
	java:app/jboss-wicket-war/ContactDaoBean!org.jboss.as.quickstarts.wicketWar.dao.ContactDao
	java:module/ContactDaoBean!org.jboss.as.quickstarts.wicketWar.dao.ContactDao
	java:global/jboss-wicket-war/ContactDaoBean
	java:app/jboss-wicket-war/ContactDaoBean
	java:module/ContactDaoBean

11:55:40,419 INFO  [org.jboss.weld.deployer] (MSC service thread 1-9) JBAS016005: Starting Services for CDI deployment: jboss-wicket-war.war
11:55:40,422 INFO  [org.jboss.as.jpa] (ServerService Thread Pool -- 65) JBAS011402: Starting Persistence Unit Service 'jboss-wicket-war.war#primary'
11:55:40,422 INFO  [org.jboss.weld.deployer] (MSC service thread 1-7) JBAS016008: Starting weld service for deployment jboss-wicket-war.war
11:55:40,423 INFO  [org.hibernate.ejb.Ejb3Configuration] (ServerService Thread Pool -- 65) HHH000204: Processing PersistenceUnitInfo [
	name: primary
	...]
11:55:40,451 INFO  [org.hibernate.service.jdbc.connections.internal.ConnectionProviderInitiator] (ServerService Thread Pool -- 65) HHH000130: Instantiating explicit connection provider: org.hibernate.ejb.connection.InjectedDataSourceConnectionProvider
11:55:40,455 INFO  [org.hibernate.dialect.Dialect] (ServerService Thread Pool -- 65) HHH000400: Using dialect: org.hibernate.dialect.H2Dialect
11:55:40,456 WARN  [org.hibernate.dialect.H2Dialect] (ServerService Thread Pool -- 65) HHH000431: Unable to determine H2 database version, certain features may not work
11:55:40,458 INFO  [org.hibernate.engine.transaction.internal.TransactionFactoryInitiator] (ServerService Thread Pool -- 65) HHH000268: Transaction strategy: org.hibernate.engine.transaction.internal.jta.CMTTransactionFactory
11:55:40,458 INFO  [org.hibernate.hql.internal.ast.ASTQueryTranslatorFactory] (ServerService Thread Pool -- 65) HHH000397: Using ASTQueryTranslatorFactory
11:55:40,464 INFO  [org.hibernate.tool.hbm2ddl.SchemaExport] (ServerService Thread Pool -- 65) HHH000227: Running hbm2ddl schema export
11:55:40,466 INFO  [org.hibernate.tool.hbm2ddl.SchemaExport] (ServerService Thread Pool -- 65) HHH000230: Schema export complete
11:55:40,588 INFO  [org.jboss.web] (ServerService Thread Pool -- 63) JBAS018210: Register web context: /jboss-wicket-war
11:55:40,597 ERROR [stderr] (ServerService Thread Pool -- 63) SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
11:55:40,597 ERROR [stderr] (ServerService Thread Pool -- 63) SLF4J: Defaulting to no-operation (NOP) logger implementation
11:55:40,597 ERROR [stderr] (ServerService Thread Pool -- 63) SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
11:55:40,640 WARNING [org.jboss.seam.conversation.spi.SeamConversationContextFactory] (ServerService Thread Pool -- 63) No matching SeamConversationContext for store type interface javax.servlet.http.HttpServletRequest, using NOOP instance!
11:55:40,644 ERROR [stderr] (ServerService Thread Pool -- 63) ********************************************************************
11:55:40,644 ERROR [stderr] (ServerService Thread Pool -- 63) *** WARNING: Wicket is running in DEVELOPMENT mode.              ***
11:55:40,644 ERROR [stderr] (ServerService Thread Pool -- 63) ***                               ^^^^^^^^^^^                    ***
11:55:40,644 ERROR [stderr] (ServerService Thread Pool -- 63) *** Do NOT deploy to your live server(s) without changing this.  ***
11:55:40,644 ERROR [stderr] (ServerService Thread Pool -- 63) *** See Application#getConfigurationType() for more information. ***
11:55:40,644 ERROR [stderr] (ServerService Thread Pool -- 63) ********************************************************************
11:55:40,689 INFO  [org.jboss.as.server] (management-handler-thread - 6) JBAS018559: Deployed "jboss-wicket-war.war" (runtime-name : "jboss-wicket-war.war")

Comment 5 Marek Schmidt 2014-04-14 16:05:12 UTC
Seam 3 conversation is not supported and never will. Quickstarts should not depend on it, not even transitively.

IMHO the quickstart should either be migrated to a wicket version which no longer uses Seam 3 (not sure if such exists or is possible [1]), or to not use CDI.


[1] hints that it may exist, http://wicket.apache.org/2014/01/05/wicket-6.13.0-released.html  though it might require CDI 1.1, so it probably won't work.

Comment 6 Vineet Reynolds 2014-04-14 16:08:46 UTC
Ondra, this warning is most likely because of the dependency on "net.ftlines.wicket-cdi:wicket-cdi" which transitively depends on the Seam conversation module for Weld (ref: https://github.com/42Lines/wicket-cdi#installation).

I'm not sure if it makes sense for this quickstart to depend on wicket-cdi or even Seam module. Maybe we should consider removing the bits in the quickstart that depend on this?

Comment 7 Vineet Reynolds 2014-04-14 16:13:55 UTC
FYI, the hard requirement on Seam conversation seems to be done away with in Wicket 6.13 through support for CDI 1.1: http://wicket.apache.org/2014/01/05/wicket-6.13.0-released.html. Something to consider in the future.

Comment 8 sgilda 2014-04-14 18:59:20 UTC
It appears that the 6.14 wicket artifacts are in Maven Central: http://search.maven.org/#search|ga|1|wicket-cdi

Could/should the quickstart be updated to use it?

Comment 9 sgilda 2014-04-21 16:01:50 UTC
I updated the wicket-war quickstart to use the latest org.apache.wicket wicket-cdi 6.14.0 artifacts, however, I still see the SeamConversationContext warnings in the server log when I deploy the conversations.

My code changes are here: https://github.com/jboss-developer/jboss-eap-quickstarts/pull/937

I hope someone can tell me what I missed.

Comment 10 sgilda 2014-04-21 18:28:01 UTC
Based on google search of similar issues, some solutions say you need to add the seam-conversation-weld jar. I found this one on Maven Central:
http://search.maven.org/#artifactdetails|org.jboss.seam.conversation|seam-conversation-weld|3.0.0.Final|jar


I modified the wicket-war/pom.xml file to add the following to the dependencyManagement section:

 <!-- Seam Weld integration. -->
        <dependency>
            <groupId>org.jboss.seam.converstation</groupId>
            <artifactId>seam-conversation-weld</artifactId>
           <version>3.0.0.Final</version>
        </dependency>

And added the following dependency:
 <!-- Seam Weld integration. -->
    <dependency>
        <groupId>org.jboss.seam.converstation</groupId>
        <artifactId>seam-conversation-weld</artifactId>
    </dependency>

However, now I get this error when I build the WAR:

[ERROR] Failed to execute goal on project jboss-wicket-war: Could not resolve dependencies for project org.jboss.quickstarts.eap:jboss-wicket-war:war:6.2.0-redhat-SNAPSHOT: Failure to find org.jboss.seam.converstation:seam-conversation-weld:jar:3.0.0.Final in http://jboss-developer.github.io/temp-maven-repo/ was cached in the local repository, resolution will not be reattempted until the update interval of jboss-developer-repository has elapsed or updates are forced -> [Help 1]

Comment 11 sgilda 2014-04-21 19:35:00 UTC
Joshua noticed I had a typo in 'conversation'. Removing the extra 't' solved the problem.

Updated to wicket-cdi 6.14.0 and added seam-conversation-weld dependency to get rid of the warning message.

Pull issued: https://github.com/jboss-developer/jboss-eap-quickstarts/pull/937

Comment 12 sgilda 2014-04-21 23:33:07 UTC
Fix was merged.

Comment 13 Marek Novotny 2014-04-22 12:45:11 UTC
Current fix is not really what we should release in any of our product. I thought that all quickstarts present our recommendation or the way how to develop applications by end users. Even not all libs/deps/patterns should be supported, using outdated and get away technologies should not be added or highlighted. And exactly this seam3 is wrong from QS point of view for guiding end users.

Comment 14 Ondřej Žižka 2014-04-23 14:18:03 UTC
Sent a mail to wicket-users list to check whether there's anything new:

Hi,

the Wicket quickstart for WildFly, when deployed, gives a warning -

WARNING [org.jboss.seam.conversation.spi.SeamConversationContextFactory] (ServerService Thread Pool -- 48) No matching SeamConversationContext for store type interface javax.servlet.http.HttpServletRequest, using NOOP instance!

Until seam-conversation-weld is added as dependency.
See  https://bugzilla.redhat.com/show_bug.cgi?id=1087471 .

I remember this was the way to go when I created the quickstart,
and it seems to be until now:
http://apache-wicket.1842946.n4.nabble.com/CDI-upgrade-to-1-1-td4658579.html

Is that correct? Or anything new so we could get rid of Seam dependency?

Thanks,
Ondra

Comment 15 sgilda 2014-05-09 20:33:20 UTC
These quickstarts are being removed from the product build per https://bugzilla.redhat.com/show_bug.cgi?id=1095892. 

They should be removed for ER5.

Comment 16 sgilda 2014-05-21 15:41:35 UTC
These quickstarts were removed per Bug 1095892, so this is no longer an issue. 

I am closing it out.

Comment 18 sgilda 2014-05-22 11:35:01 UTC
Marek, Sounds good. I wasn't sure what to use. Thanks!

Comment 19 Ondřej Žižka 2014-06-03 16:45:08 UTC
Martin Grigorov:

"Since our Wicket CDI experts didn't answer you I will try.
wicket-cdi module provides integration for CDI 1.0 impls. It requires SEAM
dependencies to provide support for CDI conversations.
wicket-cdi-1.1 provides support for CDI 1.1 impls (e.g. JBoss 8.x, aka
WildFly) and it doesn't need SEAM as dependency."

Comment 20 sgilda 2014-06-03 17:31:39 UTC
Ondra, I tried upgrading the quickstart to:

    <version.wicket.cdi>6.14.0</version.wicket.cdi>

But it still had a dependency on:

    <version.seam.conversation.weld>3.0.0.Final</version.seam.conversation.weld>


Note You need to log in before you can comment on or make changes to this bug.