Bug 1087700 - lost signals when sending lots of signals using --sig-proxy to docker
Summary: lost signals when sending lots of signals using --sig-proxy to docker
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: docker-io
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jack Rieden
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1096269
TreeView+ depends on / blocked
 
Reported: 2014-04-15 06:05 UTC by Lukáš Doktor
Modified: 2023-09-14 02:06 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1096269 (view as bug list)
Environment:
Last Closed: 2016-07-19 11:22:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Lukáš Doktor 2014-04-15 06:05:30 UTC
Description of problem:
When I send lots of signals to the running docker with --sig-proxy (actual kill signals, not `docker kill`), most of them got lost.

Version-Release number of selected component (if applicable):
docker-io-0.9.1-1.fc21.x86_64


How reproducible:
always

Steps to Reproduce:
1. /usr/bin/docker -D run --tty=false --rm -i --name test_eoly localhost:5000/ldoktor/fedora:latest bash -c 'for NUM in `seq 1 64`; do trap "echo Received $NUM, ignoring..." $NUM; done; while :; do sleep 1; done'
2. ps ax |grep docker
3. for AAA in `seq 1 32`; do [ $AAA -ne 9 ] && [ $AAA -ne 20 ] && [ $AAA -ne 19 ] && kill -s $AAA $PID; done

Actual results:
Output of the docker is:
Received 1, ignoring...
Received 2, ignoring...


Expected results:
Messages for all of the `Received $NUM, ignoring...` printed (order doesn't matter)

Additional info:
Skipping 9, 19, 20 as they are a bit too special..

Comment 1 Lukáš Doktor 2014-05-05 08:10:09 UTC
The same results with upstream docker dc9c28f/0.10.0:

Output:
Received 1, ignoring...
[debug] stdcopy.go:111 framesize: 24
Received 2, ignoring...

Daemon output:
2014/05/05 10:08:45 POST /v1.10/containers/b01a849cb45ebe94c3a61fa021a5464186345d5b159faee4ea9d5da39fb36de5/kill?signal=HUP
[/home/medic/Work/Projekty/Docker/root|fa3816b6] +job kill(b01a849cb45ebe94c3a61fa021a5464186345d5b159faee4ea9d5da39fb36de5, HUP)
[/home/medic/Work/Projekty/Docker/root|fa3816b6] -job kill(b01a849cb45ebe94c3a61fa021a5464186345d5b159faee4ea9d5da39fb36de5, HUP) = OK (0)
2014/05/05 10:08:45 POST /v1.10/containers/b01a849cb45ebe94c3a61fa021a5464186345d5b159faee4ea9d5da39fb36de5/kill?signal=INT
[/home/medic/Work/Projekty/Docker/root|fa3816b6] +job kill(b01a849cb45ebe94c3a61fa021a5464186345d5b159faee4ea9d5da39fb36de5, INT)
[/home/medic/Work/Projekty/Docker/root|fa3816b6] -job kill(b01a849cb45ebe94c3a61fa021a5464186345d5b159faee4ea9d5da39fb36de5, INT) = OK (0)

Comment 2 Daniel Walsh 2014-06-03 20:33:28 UTC

*** This bug has been marked as a duplicate of bug 1087697 ***

Comment 3 Lukáš Doktor 2014-06-04 04:56:25 UTC
Hi Daniel, I don't see the relation to bz1087697. This one is about docker not handling signals properly (when sending them too quickly) and the bz1087697 is about --sig-proxy not working in --tty=false mode.

Comment 4 Daniel Walsh 2014-06-04 12:47:29 UTC
Ok sorry about that, I was doing a lot of cleanup yesterday and screwed up.  This is the one we agreed would be a documentation issue correct.  IE Just document which signals do not work?

Comment 5 Lukáš Doktor 2014-06-16 06:34:01 UTC
This one was about using `docker kill` very quickly/in parallel, which results in missing signals in container, even when you use only the "safe" signals. So documentation won't fix this issue (well you can add 1s wait in `docker kill` ;-) but I believe there is a better solution.

Comment 6 Matthew Heon 2014-07-07 17:54:46 UTC
A fix for this has made its way upstream (https://github.com/dotcloud/docker/pull/6508#issuecomment-48211901), and should be included in the next upstream release of Docker.

Comment 7 Daniel Walsh 2014-09-15 20:00:11 UTC
Fixed in docker-1.2

Comment 8 Lukáš Doktor 2014-09-29 08:46:37 UTC
Thank you, this seems to be working fine on docker-1.2.0-19.el7.x86_64 (apart from the usually broken signals...)

Comment 10 Fedora End Of Life 2015-05-29 11:34:22 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 11 Fedora End Of Life 2016-07-19 11:22:31 UTC
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 12 Red Hat Bugzilla 2023-09-14 02:06:23 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days


Note You need to log in before you can comment on or make changes to this bug.