Spec URL: http://opuk.fedorapeople.org/scite.spec SRPM URL: http://opuk.fedorapeople.org/SRPMS/scite-3.4.1-1.fc20.src.rpm Description: SciTE is a SCIntilla based Text Editor. Originally built to demonstrate Scintilla, it has grown to be a generally useful editor with facilities for building and running programs. Fedora Account System Username: opuk Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6740589 This is a rereview of the retired package scite, upstream is no longer dead.
Spec URL: http://opuk.fedorapeople.org/scite.spec SRPM URL: http://opuk.fedorapeople.org/SRPMS/scite-3.4.1-2.fc20.src.rpm Dropped the rm -rf %{buildroot} in %install and %defattr(-,root,root,-) in %files as they are no longer needed.
THanks for resurrecting it. 1. LDFLAGS not set. 2. mv scite/doc/scite.1 %{buildroot}%{_mandir}/man1/ Use install with -pm644 is better. 3. It supports gtk3, please use gtk3. 4. Why do we need ln -s SciTE %{buildroot}%{_bindir}/scite ? 5. desktop-file-install --vendor fedora --delete-original \ No vendor please.
(In reply to Christopher Meng from comment #2) > 1. LDFLAGS not set. > Fixed. > 2. mv scite/doc/scite.1 %{buildroot}%{_mandir}/man1/ > > Use install with -pm644 is better. > Fixed. > 3. It supports gtk3, please use gtk3. > Fixed, altough it still needs gtk2-devel to build. > 4. Why do we need ln -s SciTE %{buildroot}%{_bindir}/scite ? > The original package was called scite and not SciTE, I didn't change that. The upstream tarball is called sciteXXX.tgz too. It may also be because the man page is called scite.1 I guess the man page could be renamed if this is an issue. If this should be dropped I think the package should be renamed to SciTE as well, however other distros call it scite so I think it would be better to keep it all lowercase. > 5. desktop-file-install --vendor fedora --delete-original \ > > No vendor please. Fixed. Spec URL: http://opuk.fedorapeople.org/scite.spec SRPM URL: http://opuk.fedorapeople.org/SRPMS/scite-3.4.1-3.fc20.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6745226
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in scite See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Public domain", "Unknown or generated", "*No copyright* Public domain". 360 files have unknown license. Detailed output of licensecheck: *No copyright* Public domain ---------------------------- scite-3.4.1/scintilla/src/RESearch.h Public domain ------------- scite-3.4.1/scintilla/lexlib/StyleContext.cxx scite-3.4.1/scintilla/lexlib/StyleContext.h scite-3.4.1/scintilla/src/UnicodeFromUTF8.h Unknown or generated -------------------- scite-3.4.1/scintilla/bin/__init__.py scite-3.4.1/scintilla/cocoa/InfoBar.h scite-3.4.1/scintilla/cocoa/InfoBarCommunicator.h scite-3.4.1/scintilla/cocoa/PlatCocoa.h scite-3.4.1/scintilla/cocoa/QuartzTextLayout.h scite-3.4.1/scintilla/cocoa/QuartzTextStyle.h scite-3.4.1/scintilla/cocoa/QuartzTextStyleAttribute.h scite-3.4.1/scintilla/cocoa/ScintillaCocoa.h scite-3.4.1/scintilla/cocoa/ScintillaTest/AppController.h scite-3.4.1/scintilla/cocoa/ScintillaTest/main.m scite-3.4.1/scintilla/cocoa/ScintillaView.h scite-3.4.1/scintilla/cocoa/checkbuildosx.sh scite-3.4.1/scintilla/gtk/Converter.h scite-3.4.1/scintilla/gtk/PlatGTK.cxx scite-3.4.1/scintilla/gtk/ScintillaGTK.cxx scite-3.4.1/scintilla/gtk/scintilla-marshal.c scite-3.4.1/scintilla/gtk/scintilla-marshal.h scite-3.4.1/scintilla/include/ILexer.h scite-3.4.1/scintilla/include/Platform.h scite-3.4.1/scintilla/include/SciLexer.h scite-3.4.1/scintilla/include/Scintilla.h scite-3.4.1/scintilla/include/ScintillaWidget.h scite-3.4.1/scintilla/lexers/LexA68k.cxx scite-3.4.1/scintilla/lexers/LexAPDL.cxx scite-3.4.1/scintilla/lexers/LexASY.cxx scite-3.4.1/scintilla/lexers/LexAU3.cxx scite-3.4.1/scintilla/lexers/LexAVE.cxx scite-3.4.1/scintilla/lexers/LexAVS.cxx scite-3.4.1/scintilla/lexers/LexAbaqus.cxx scite-3.4.1/scintilla/lexers/LexAda.cxx scite-3.4.1/scintilla/lexers/LexAsm.cxx scite-3.4.1/scintilla/lexers/LexAsn1.cxx scite-3.4.1/scintilla/lexers/LexBaan.cxx scite-3.4.1/scintilla/lexers/LexBash.cxx scite-3.4.1/scintilla/lexers/LexBasic.cxx scite-3.4.1/scintilla/lexers/LexBullant.cxx scite-3.4.1/scintilla/lexers/LexCLW.cxx scite-3.4.1/scintilla/lexers/LexCOBOL.cxx scite-3.4.1/scintilla/lexers/LexCPP.cxx scite-3.4.1/scintilla/lexers/LexCSS.cxx scite-3.4.1/scintilla/lexers/LexCaml.cxx scite-3.4.1/scintilla/lexers/LexCmake.cxx scite-3.4.1/scintilla/lexers/LexCoffeeScript.cxx scite-3.4.1/scintilla/lexers/LexConf.cxx scite-3.4.1/scintilla/lexers/LexCrontab.cxx scite-3.4.1/scintilla/lexers/LexCsound.cxx scite-3.4.1/scintilla/lexers/LexD.cxx scite-3.4.1/scintilla/lexers/LexDMAP.cxx scite-3.4.1/scintilla/lexers/LexECL.cxx scite-3.4.1/scintilla/lexers/LexEScript.cxx scite-3.4.1/scintilla/lexers/LexEiffel.cxx scite-3.4.1/scintilla/lexers/LexErlang.cxx scite-3.4.1/scintilla/lexers/LexFlagship.cxx scite-3.4.1/scintilla/lexers/LexForth.cxx scite-3.4.1/scintilla/lexers/LexFortran.cxx scite-3.4.1/scintilla/lexers/LexGAP.cxx scite-3.4.1/scintilla/lexers/LexGui4Cli.cxx scite-3.4.1/scintilla/lexers/LexHTML.cxx scite-3.4.1/scintilla/lexers/LexHaskell.cxx scite-3.4.1/scintilla/lexers/LexInno.cxx scite-3.4.1/scintilla/lexers/LexKVIrc.cxx scite-3.4.1/scintilla/lexers/LexKix.cxx scite-3.4.1/scintilla/lexers/LexLaTeX.cxx scite-3.4.1/scintilla/lexers/LexLisp.cxx scite-3.4.1/scintilla/lexers/LexLout.cxx scite-3.4.1/scintilla/lexers/LexLua.cxx scite-3.4.1/scintilla/lexers/LexMMIXAL.cxx scite-3.4.1/scintilla/lexers/LexMPT.cxx scite-3.4.1/scintilla/lexers/LexMSSQL.cxx scite-3.4.1/scintilla/lexers/LexMagik.cxx scite-3.4.1/scintilla/lexers/LexMarkdown.cxx scite-3.4.1/scintilla/lexers/LexMatlab.cxx scite-3.4.1/scintilla/lexers/LexMetapost.cxx scite-3.4.1/scintilla/lexers/LexModula.cxx scite-3.4.1/scintilla/lexers/LexMySQL.cxx scite-3.4.1/scintilla/lexers/LexNimrod.cxx scite-3.4.1/scintilla/lexers/LexNsis.cxx scite-3.4.1/scintilla/lexers/LexOScript.cxx scite-3.4.1/scintilla/lexers/LexOpal.cxx scite-3.4.1/scintilla/lexers/LexOthers.cxx scite-3.4.1/scintilla/lexers/LexPB.cxx scite-3.4.1/scintilla/lexers/LexPLM.cxx scite-3.4.1/scintilla/lexers/LexPO.cxx scite-3.4.1/scintilla/lexers/LexPOV.cxx scite-3.4.1/scintilla/lexers/LexPS.cxx scite-3.4.1/scintilla/lexers/LexPascal.cxx scite-3.4.1/scintilla/lexers/LexPerl.cxx scite-3.4.1/scintilla/lexers/LexPowerPro.cxx scite-3.4.1/scintilla/lexers/LexPowerShell.cxx scite-3.4.1/scintilla/lexers/LexProgress.cxx scite-3.4.1/scintilla/lexers/LexPython.cxx scite-3.4.1/scintilla/lexers/LexR.cxx scite-3.4.1/scintilla/lexers/LexRebol.cxx scite-3.4.1/scintilla/lexers/LexRuby.cxx scite-3.4.1/scintilla/lexers/LexRust.cxx scite-3.4.1/scintilla/lexers/LexSML.cxx scite-3.4.1/scintilla/lexers/LexSQL.cxx scite-3.4.1/scintilla/lexers/LexSTTXT.cxx scite-3.4.1/scintilla/lexers/LexScriptol.cxx scite-3.4.1/scintilla/lexers/LexSmalltalk.cxx scite-3.4.1/scintilla/lexers/LexSorcus.cxx scite-3.4.1/scintilla/lexers/LexSpecman.cxx scite-3.4.1/scintilla/lexers/LexSpice.cxx scite-3.4.1/scintilla/lexers/LexTACL.cxx scite-3.4.1/scintilla/lexers/LexTADS3.cxx scite-3.4.1/scintilla/lexers/LexTAL.cxx scite-3.4.1/scintilla/lexers/LexTCL.cxx scite-3.4.1/scintilla/lexers/LexTCMD.cxx scite-3.4.1/scintilla/lexers/LexTeX.cxx scite-3.4.1/scintilla/lexers/LexTxt2tags.cxx scite-3.4.1/scintilla/lexers/LexVB.cxx scite-3.4.1/scintilla/lexers/LexVHDL.cxx scite-3.4.1/scintilla/lexers/LexVerilog.cxx scite-3.4.1/scintilla/lexers/LexVisualProlog.cxx scite-3.4.1/scintilla/lexers/LexYAML.cxx scite-3.4.1/scintilla/lexlib/Accessor.cxx scite-3.4.1/scintilla/lexlib/Accessor.h scite-3.4.1/scintilla/lexlib/CharacterCategory.cxx scite-3.4.1/scintilla/lexlib/CharacterCategory.h scite-3.4.1/scintilla/lexlib/CharacterSet.cxx scite-3.4.1/scintilla/lexlib/CharacterSet.h scite-3.4.1/scintilla/lexlib/LexAccessor.h scite-3.4.1/scintilla/lexlib/LexerBase.cxx scite-3.4.1/scintilla/lexlib/LexerBase.h scite-3.4.1/scintilla/lexlib/LexerModule.cxx scite-3.4.1/scintilla/lexlib/LexerModule.h scite-3.4.1/scintilla/lexlib/LexerNoExceptions.cxx scite-3.4.1/scintilla/lexlib/LexerNoExceptions.h scite-3.4.1/scintilla/lexlib/LexerSimple.cxx scite-3.4.1/scintilla/lexlib/LexerSimple.h scite-3.4.1/scintilla/lexlib/OptionSet.h scite-3.4.1/scintilla/lexlib/PropSetSimple.cxx scite-3.4.1/scintilla/lexlib/PropSetSimple.h scite-3.4.1/scintilla/lexlib/SparseState.h scite-3.4.1/scintilla/lexlib/StringCopy.h scite-3.4.1/scintilla/lexlib/SubStyles.h scite-3.4.1/scintilla/lexlib/WordList.cxx scite-3.4.1/scintilla/lexlib/WordList.h scite-3.4.1/scintilla/qt/ScintillaEdit/ScintillaDocument.cpp scite-3.4.1/scintilla/qt/ScintillaEdit/ScintillaDocument.h scite-3.4.1/scintilla/qt/ScintillaEdit/WidgetGen.py scite-3.4.1/scintilla/qt/ScintillaEditBase/PlatQt.cpp scite-3.4.1/scintilla/qt/ScintillaEditBase/PlatQt.h scite-3.4.1/scintilla/qt/ScintillaEditBase/ScintillaEditBase.cpp scite-3.4.1/scintilla/qt/ScintillaEditBase/ScintillaEditBase.h scite-3.4.1/scintilla/qt/ScintillaEditBase/ScintillaQt.cpp scite-3.4.1/scintilla/qt/ScintillaEditBase/ScintillaQt.h scite-3.4.1/scintilla/qt/ScintillaEditPy/global.h scite-3.4.1/scintilla/qt/ScintillaEditPy/sepbuild.py scite-3.4.1/scintilla/qt/ScintillaEditPy/testsepq.py scite-3.4.1/scintilla/scripts/Face.py scite-3.4.1/scintilla/scripts/FileGenerator.py scite-3.4.1/scintilla/scripts/GenerateCaseConvert.py scite-3.4.1/scintilla/scripts/GenerateCharacterCategory.py scite-3.4.1/scintilla/scripts/HFacer.py scite-3.4.1/scintilla/scripts/LexGen.py scite-3.4.1/scintilla/scripts/ScintillaData.py scite-3.4.1/scintilla/src/AutoComplete.cxx scite-3.4.1/scintilla/src/AutoComplete.h scite-3.4.1/scintilla/src/CallTip.cxx scite-3.4.1/scintilla/src/CallTip.h scite-3.4.1/scintilla/src/CaseConvert.cxx scite-3.4.1/scintilla/src/CaseConvert.h scite-3.4.1/scintilla/src/CaseFolder.cxx scite-3.4.1/scintilla/src/CaseFolder.h scite-3.4.1/scintilla/src/Catalogue.cxx scite-3.4.1/scintilla/src/Catalogue.h scite-3.4.1/scintilla/src/CellBuffer.cxx scite-3.4.1/scintilla/src/CellBuffer.h scite-3.4.1/scintilla/src/CharClassify.cxx scite-3.4.1/scintilla/src/CharClassify.h scite-3.4.1/scintilla/src/ContractionState.cxx scite-3.4.1/scintilla/src/ContractionState.h scite-3.4.1/scintilla/src/Decoration.cxx scite-3.4.1/scintilla/src/Decoration.h scite-3.4.1/scintilla/src/Document.cxx scite-3.4.1/scintilla/src/Document.h scite-3.4.1/scintilla/src/Editor.cxx scite-3.4.1/scintilla/src/Editor.h scite-3.4.1/scintilla/src/ExternalLexer.cxx scite-3.4.1/scintilla/src/ExternalLexer.h scite-3.4.1/scintilla/src/FontQuality.h scite-3.4.1/scintilla/src/Indicator.cxx scite-3.4.1/scintilla/src/Indicator.h scite-3.4.1/scintilla/src/KeyMap.cxx scite-3.4.1/scintilla/src/KeyMap.h scite-3.4.1/scintilla/src/LineMarker.cxx scite-3.4.1/scintilla/src/LineMarker.h scite-3.4.1/scintilla/src/Partitioning.h scite-3.4.1/scintilla/src/PerLine.cxx scite-3.4.1/scintilla/src/PerLine.h scite-3.4.1/scintilla/src/PositionCache.cxx scite-3.4.1/scintilla/src/PositionCache.h scite-3.4.1/scintilla/src/RESearch.cxx scite-3.4.1/scintilla/src/RunStyles.cxx scite-3.4.1/scintilla/src/RunStyles.h scite-3.4.1/scintilla/src/ScintillaBase.cxx scite-3.4.1/scintilla/src/ScintillaBase.h scite-3.4.1/scintilla/src/Selection.cxx scite-3.4.1/scintilla/src/Selection.h scite-3.4.1/scintilla/src/SplitVector.h scite-3.4.1/scintilla/src/Style.cxx scite-3.4.1/scintilla/src/Style.h scite-3.4.1/scintilla/src/UniConversion.cxx scite-3.4.1/scintilla/src/UniConversion.h scite-3.4.1/scintilla/src/ViewStyle.cxx scite-3.4.1/scintilla/src/ViewStyle.h scite-3.4.1/scintilla/src/XPM.cxx scite-3.4.1/scintilla/src/XPM.h scite-3.4.1/scintilla/test/MessageNumbers.py scite-3.4.1/scintilla/test/ScintillaCallable.py scite-3.4.1/scintilla/test/XiteMenu.py scite-3.4.1/scintilla/test/XiteQt.py scite-3.4.1/scintilla/test/XiteWin.py scite-3.4.1/scintilla/test/examples/x.cxx scite-3.4.1/scintilla/test/examples/x.php scite-3.4.1/scintilla/test/examples/x.pl scite-3.4.1/scintilla/test/examples/x.py scite-3.4.1/scintilla/test/examples/x.rb scite-3.4.1/scintilla/test/lexTests.py scite-3.4.1/scintilla/test/performanceTests.py scite-3.4.1/scintilla/test/simpleTests.py scite-3.4.1/scintilla/test/unit/catch.hpp scite-3.4.1/scintilla/test/unit/testCellBuffer.cxx scite-3.4.1/scintilla/test/unit/testCharClassify.cxx scite-3.4.1/scintilla/test/unit/testContractionState.cxx scite-3.4.1/scintilla/test/unit/testDecoration.cxx scite-3.4.1/scintilla/test/unit/testPartitioning.cxx scite-3.4.1/scintilla/test/unit/testRunStyles.cxx scite-3.4.1/scintilla/test/unit/testSparseState.cxx scite-3.4.1/scintilla/test/unit/testSplitVector.cxx scite-3.4.1/scintilla/test/unit/unitTest.cxx scite-3.4.1/scintilla/test/xite.py scite-3.4.1/scintilla/win32/CheckD2D.cxx scite-3.4.1/scintilla/win32/PlatWin.cxx scite-3.4.1/scintilla/win32/PlatWin.h scite-3.4.1/scintilla/win32/ScintillaWin.cxx scite-3.4.1/scite/gtk/DirectorExtension.cxx scite-3.4.1/scite/gtk/DirectorExtension.h scite-3.4.1/scite/gtk/GTKMutex.cxx scite-3.4.1/scite/gtk/GUIGTK.cxx scite-3.4.1/scite/gtk/SciIcon.h scite-3.4.1/scite/gtk/SciTEGTK.cxx scite-3.4.1/scite/gtk/Widget.cxx scite-3.4.1/scite/gtk/Widget.h scite-3.4.1/scite/gtk/pixmapsGNOME.h scite-3.4.1/scite/lua/include/lauxlib.h scite-3.4.1/scite/lua/include/lua.h scite-3.4.1/scite/lua/include/luaconf.h scite-3.4.1/scite/lua/include/lualib.h scite-3.4.1/scite/lua/src/lapi.c scite-3.4.1/scite/lua/src/lapi.h scite-3.4.1/scite/lua/src/lcode.c scite-3.4.1/scite/lua/src/lcode.h scite-3.4.1/scite/lua/src/ldebug.c scite-3.4.1/scite/lua/src/ldebug.h scite-3.4.1/scite/lua/src/ldo.c scite-3.4.1/scite/lua/src/ldo.h scite-3.4.1/scite/lua/src/ldump.c scite-3.4.1/scite/lua/src/lfunc.c scite-3.4.1/scite/lua/src/lfunc.h scite-3.4.1/scite/lua/src/lgc.c scite-3.4.1/scite/lua/src/lgc.h scite-3.4.1/scite/lua/src/lib/lauxlib.c scite-3.4.1/scite/lua/src/lib/lbaselib.c scite-3.4.1/scite/lua/src/lib/ldblib.c scite-3.4.1/scite/lua/src/lib/linit.c scite-3.4.1/scite/lua/src/lib/liolib.c scite-3.4.1/scite/lua/src/lib/lmathlib.c scite-3.4.1/scite/lua/src/lib/loadlib.c scite-3.4.1/scite/lua/src/lib/loslib.c scite-3.4.1/scite/lua/src/lib/lstrlib.c scite-3.4.1/scite/lua/src/lib/ltablib.c scite-3.4.1/scite/lua/src/llex.c scite-3.4.1/scite/lua/src/llex.h scite-3.4.1/scite/lua/src/llimits.h scite-3.4.1/scite/lua/src/lmem.c scite-3.4.1/scite/lua/src/lmem.h scite-3.4.1/scite/lua/src/lobject.c scite-3.4.1/scite/lua/src/lobject.h scite-3.4.1/scite/lua/src/lopcodes.c scite-3.4.1/scite/lua/src/lopcodes.h scite-3.4.1/scite/lua/src/lparser.c scite-3.4.1/scite/lua/src/lparser.h scite-3.4.1/scite/lua/src/lstate.c scite-3.4.1/scite/lua/src/lstate.h scite-3.4.1/scite/lua/src/lstring.c scite-3.4.1/scite/lua/src/lstring.h scite-3.4.1/scite/lua/src/ltable.c scite-3.4.1/scite/lua/src/ltable.h scite-3.4.1/scite/lua/src/ltm.c scite-3.4.1/scite/lua/src/ltm.h scite-3.4.1/scite/lua/src/lundump.c scite-3.4.1/scite/lua/src/lundump.h scite-3.4.1/scite/lua/src/lvm.c scite-3.4.1/scite/lua/src/lvm.h scite-3.4.1/scite/lua/src/lzio.c scite-3.4.1/scite/lua/src/lzio.h scite-3.4.1/scite/scripts/CheckMentioned.py scite-3.4.1/scite/scripts/CheckPropsDoc.py scite-3.4.1/scite/scripts/IFaceTableGen.py scite-3.4.1/scite/scripts/RegenerateSource.py scite-3.4.1/scite/scripts/checkbuildlinux.sh scite-3.4.1/scite/scripts/commandsdoc.py scite-3.4.1/scite/scripts/makerpms.py scite-3.4.1/scite/scripts/tags2api.py scite-3.4.1/scite/src/Cookie.cxx scite-3.4.1/scite/src/Cookie.h scite-3.4.1/scite/src/Credits.cxx scite-3.4.1/scite/src/Exporters.cxx scite-3.4.1/scite/src/Extender.h scite-3.4.1/scite/src/FilePath.cxx scite-3.4.1/scite/src/FilePath.h scite-3.4.1/scite/src/FileWorker.cxx scite-3.4.1/scite/src/FileWorker.h scite-3.4.1/scite/src/GUI.h scite-3.4.1/scite/src/IFaceTable.cxx scite-3.4.1/scite/src/IFaceTable.h scite-3.4.1/scite/src/JobQueue.cxx scite-3.4.1/scite/src/JobQueue.h scite-3.4.1/scite/src/LuaExtension.cxx scite-3.4.1/scite/src/LuaExtension.h scite-3.4.1/scite/src/MultiplexExtension.cxx scite-3.4.1/scite/src/MultiplexExtension.h scite-3.4.1/scite/src/Mutex.h scite-3.4.1/scite/src/PropSetFile.cxx scite-3.4.1/scite/src/PropSetFile.h scite-3.4.1/scite/src/SString.h scite-3.4.1/scite/src/SciTE.h scite-3.4.1/scite/src/SciTEBase.cxx scite-3.4.1/scite/src/SciTEBase.h scite-3.4.1/scite/src/SciTEBuffers.cxx scite-3.4.1/scite/src/SciTEIO.cxx scite-3.4.1/scite/src/SciTEKeys.h scite-3.4.1/scite/src/SciTEProps.cxx scite-3.4.1/scite/src/StringHelpers.cxx scite-3.4.1/scite/src/StringHelpers.h scite-3.4.1/scite/src/StringList.cxx scite-3.4.1/scite/src/StringList.h scite-3.4.1/scite/src/StripDefinition.h scite-3.4.1/scite/src/StyleDefinition.cxx scite-3.4.1/scite/src/StyleDefinition.h scite-3.4.1/scite/src/StyleWriter.cxx scite-3.4.1/scite/src/StyleWriter.h scite-3.4.1/scite/src/Utf8_16.cxx scite-3.4.1/scite/src/Utf8_16.h scite-3.4.1/scite/src/Worker.h scite-3.4.1/scite/src/scite_lua_win.h scite-3.4.1/scite/win32/DirectorExtension.cxx scite-3.4.1/scite/win32/DirectorExtension.h scite-3.4.1/scite/win32/GUIWin.cxx scite-3.4.1/scite/win32/SciTEWin.cxx scite-3.4.1/scite/win32/SciTEWin.h scite-3.4.1/scite/win32/SciTEWinBar.cxx scite-3.4.1/scite/win32/SciTEWinDlg.cxx scite-3.4.1/scite/win32/Strips.cxx scite-3.4.1/scite/win32/Strips.h scite-3.4.1/scite/win32/UniqueInstance.cxx scite-3.4.1/scite/win32/UniqueInstance.h scite-3.4.1/scite/win32/WinMutex.cxx [!]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1269760 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: scite-3.4.1-3.fc21.i686.rpm scite-3.4.1-3.fc21.src.rpm scite.i686: W: no-manual-page-for-binary SciTE 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint scite scite.i686: W: no-manual-page-for-binary SciTE 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- scite (rpmlib, GLIBC filtered): libc.so.6 libcairo.so.2 libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgdk-3.so.0 libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgtk-3.so.0 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpthread.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(CXXABI_1.3.8) rtld(GNU_HASH) Provides -------- scite: application() application(SciTE.desktop) mimehandler(text/plain) scite scite(x86-32) Source checksums ---------------- http://download.sourceforge.net/scintilla/scite341.tgz : CHECKSUM(SHA256) this package : ab2940ba6ad3f1c7c33aea233dd5b44efc75319062fe0b3625db04c747bf3341 CHECKSUM(SHA256) upstream package : ab2940ba6ad3f1c7c33aea233dd5b44efc75319062fe0b3625db04c747bf3341 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn scite-3.4.1-3.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ------------------------------------------ 1. gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -I ../../scintilla/include -I ../src -I../lua/include -DLUA_USE_POSIX -DNDEBUG -Os -W -Wall -pedantic -DGTK -DSCI_LEXER -DPIXMAP_PATH=\"/usr/share/pixmaps\" -DSYSCONF_PATH=\"/usr/share/scite\" -I ../../scintilla/include -I ../src -I../lua/include -c ../lua/src/lcode.c -o lcode.o Flags are overrode. And NDEBUG is bad. 2. lua is bundled.
Client site would like to see SciTE in EPEL if it can go that far. Let me know if a business case is needed.
3.4.2 is available
This should hopefully fix 1 and 2. Spec URL: http://opuk.fedorapeople.org/scite.spec SRPM URL: http://opuk.fedorapeople.org/SRPMS/scite-3.4.4-6.fc20.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Public domain", "Unknown or generated", "*No copyright* Public domain". 311 files have unknown license. Detailed output of licensecheck: *No copyright* Public domain ---------------------------- scite-3.4.4/scintilla/src/RESearch.h Public domain ------------- scite-3.4.4/scintilla/lexlib/StyleContext.cxx scite-3.4.4/scintilla/lexlib/StyleContext.h scite-3.4.4/scintilla/src/UnicodeFromUTF8.h Unknown or generated -------------------- scite-3.4.4/scintilla/bin/__init__.py scite-3.4.4/scintilla/cocoa/InfoBar.h scite-3.4.4/scintilla/cocoa/InfoBarCommunicator.h scite-3.4.4/scintilla/cocoa/PlatCocoa.h scite-3.4.4/scintilla/cocoa/QuartzTextLayout.h scite-3.4.4/scintilla/cocoa/QuartzTextStyle.h scite-3.4.4/scintilla/cocoa/QuartzTextStyleAttribute.h scite-3.4.4/scintilla/cocoa/ScintillaCocoa.h scite-3.4.4/scintilla/cocoa/ScintillaTest/AppController.h scite-3.4.4/scintilla/cocoa/ScintillaTest/main.m scite-3.4.4/scintilla/cocoa/ScintillaView.h scite-3.4.4/scintilla/cocoa/checkbuildosx.sh scite-3.4.4/scintilla/gtk/Converter.h scite-3.4.4/scintilla/gtk/PlatGTK.cxx scite-3.4.4/scintilla/gtk/ScintillaGTK.cxx scite-3.4.4/scintilla/gtk/scintilla-marshal.c scite-3.4.4/scintilla/gtk/scintilla-marshal.h scite-3.4.4/scintilla/include/ILexer.h scite-3.4.4/scintilla/include/Platform.h scite-3.4.4/scintilla/include/SciLexer.h scite-3.4.4/scintilla/include/Scintilla.h scite-3.4.4/scintilla/include/ScintillaWidget.h scite-3.4.4/scintilla/lexers/LexA68k.cxx scite-3.4.4/scintilla/lexers/LexAPDL.cxx scite-3.4.4/scintilla/lexers/LexASY.cxx scite-3.4.4/scintilla/lexers/LexAU3.cxx scite-3.4.4/scintilla/lexers/LexAVE.cxx scite-3.4.4/scintilla/lexers/LexAVS.cxx scite-3.4.4/scintilla/lexers/LexAbaqus.cxx scite-3.4.4/scintilla/lexers/LexAda.cxx scite-3.4.4/scintilla/lexers/LexAsm.cxx scite-3.4.4/scintilla/lexers/LexAsn1.cxx scite-3.4.4/scintilla/lexers/LexBaan.cxx scite-3.4.4/scintilla/lexers/LexBash.cxx scite-3.4.4/scintilla/lexers/LexBasic.cxx scite-3.4.4/scintilla/lexers/LexBullant.cxx scite-3.4.4/scintilla/lexers/LexCLW.cxx scite-3.4.4/scintilla/lexers/LexCOBOL.cxx scite-3.4.4/scintilla/lexers/LexCPP.cxx scite-3.4.4/scintilla/lexers/LexCSS.cxx scite-3.4.4/scintilla/lexers/LexCaml.cxx scite-3.4.4/scintilla/lexers/LexCmake.cxx scite-3.4.4/scintilla/lexers/LexCoffeeScript.cxx scite-3.4.4/scintilla/lexers/LexConf.cxx scite-3.4.4/scintilla/lexers/LexCrontab.cxx scite-3.4.4/scintilla/lexers/LexCsound.cxx scite-3.4.4/scintilla/lexers/LexD.cxx scite-3.4.4/scintilla/lexers/LexDMAP.cxx scite-3.4.4/scintilla/lexers/LexDMIS.cxx scite-3.4.4/scintilla/lexers/LexECL.cxx scite-3.4.4/scintilla/lexers/LexEScript.cxx scite-3.4.4/scintilla/lexers/LexEiffel.cxx scite-3.4.4/scintilla/lexers/LexErlang.cxx scite-3.4.4/scintilla/lexers/LexFlagship.cxx scite-3.4.4/scintilla/lexers/LexForth.cxx scite-3.4.4/scintilla/lexers/LexFortran.cxx scite-3.4.4/scintilla/lexers/LexGAP.cxx scite-3.4.4/scintilla/lexers/LexGui4Cli.cxx scite-3.4.4/scintilla/lexers/LexHTML.cxx scite-3.4.4/scintilla/lexers/LexHaskell.cxx scite-3.4.4/scintilla/lexers/LexInno.cxx scite-3.4.4/scintilla/lexers/LexKVIrc.cxx scite-3.4.4/scintilla/lexers/LexKix.cxx scite-3.4.4/scintilla/lexers/LexLaTeX.cxx scite-3.4.4/scintilla/lexers/LexLisp.cxx scite-3.4.4/scintilla/lexers/LexLout.cxx scite-3.4.4/scintilla/lexers/LexLua.cxx scite-3.4.4/scintilla/lexers/LexMMIXAL.cxx scite-3.4.4/scintilla/lexers/LexMPT.cxx scite-3.4.4/scintilla/lexers/LexMSSQL.cxx scite-3.4.4/scintilla/lexers/LexMagik.cxx scite-3.4.4/scintilla/lexers/LexMarkdown.cxx scite-3.4.4/scintilla/lexers/LexMatlab.cxx scite-3.4.4/scintilla/lexers/LexMetapost.cxx scite-3.4.4/scintilla/lexers/LexModula.cxx scite-3.4.4/scintilla/lexers/LexMySQL.cxx scite-3.4.4/scintilla/lexers/LexNimrod.cxx scite-3.4.4/scintilla/lexers/LexNsis.cxx scite-3.4.4/scintilla/lexers/LexOScript.cxx scite-3.4.4/scintilla/lexers/LexOpal.cxx scite-3.4.4/scintilla/lexers/LexOthers.cxx scite-3.4.4/scintilla/lexers/LexPB.cxx scite-3.4.4/scintilla/lexers/LexPLM.cxx scite-3.4.4/scintilla/lexers/LexPO.cxx scite-3.4.4/scintilla/lexers/LexPOV.cxx scite-3.4.4/scintilla/lexers/LexPS.cxx scite-3.4.4/scintilla/lexers/LexPascal.cxx scite-3.4.4/scintilla/lexers/LexPerl.cxx scite-3.4.4/scintilla/lexers/LexPowerPro.cxx scite-3.4.4/scintilla/lexers/LexPowerShell.cxx scite-3.4.4/scintilla/lexers/LexProgress.cxx scite-3.4.4/scintilla/lexers/LexPython.cxx scite-3.4.4/scintilla/lexers/LexR.cxx scite-3.4.4/scintilla/lexers/LexRebol.cxx scite-3.4.4/scintilla/lexers/LexRuby.cxx scite-3.4.4/scintilla/lexers/LexRust.cxx scite-3.4.4/scintilla/lexers/LexSML.cxx scite-3.4.4/scintilla/lexers/LexSQL.cxx scite-3.4.4/scintilla/lexers/LexSTTXT.cxx scite-3.4.4/scintilla/lexers/LexScriptol.cxx scite-3.4.4/scintilla/lexers/LexSmalltalk.cxx scite-3.4.4/scintilla/lexers/LexSorcus.cxx scite-3.4.4/scintilla/lexers/LexSpecman.cxx scite-3.4.4/scintilla/lexers/LexSpice.cxx scite-3.4.4/scintilla/lexers/LexTACL.cxx scite-3.4.4/scintilla/lexers/LexTADS3.cxx scite-3.4.4/scintilla/lexers/LexTAL.cxx scite-3.4.4/scintilla/lexers/LexTCL.cxx scite-3.4.4/scintilla/lexers/LexTCMD.cxx scite-3.4.4/scintilla/lexers/LexTeX.cxx scite-3.4.4/scintilla/lexers/LexTxt2tags.cxx scite-3.4.4/scintilla/lexers/LexVB.cxx scite-3.4.4/scintilla/lexers/LexVHDL.cxx scite-3.4.4/scintilla/lexers/LexVerilog.cxx scite-3.4.4/scintilla/lexers/LexVisualProlog.cxx scite-3.4.4/scintilla/lexers/LexYAML.cxx scite-3.4.4/scintilla/lexlib/Accessor.cxx scite-3.4.4/scintilla/lexlib/Accessor.h scite-3.4.4/scintilla/lexlib/CharacterCategory.cxx scite-3.4.4/scintilla/lexlib/CharacterCategory.h scite-3.4.4/scintilla/lexlib/CharacterSet.cxx scite-3.4.4/scintilla/lexlib/CharacterSet.h scite-3.4.4/scintilla/lexlib/LexAccessor.h scite-3.4.4/scintilla/lexlib/LexerBase.cxx scite-3.4.4/scintilla/lexlib/LexerBase.h scite-3.4.4/scintilla/lexlib/LexerModule.cxx scite-3.4.4/scintilla/lexlib/LexerModule.h scite-3.4.4/scintilla/lexlib/LexerNoExceptions.cxx scite-3.4.4/scintilla/lexlib/LexerNoExceptions.h scite-3.4.4/scintilla/lexlib/LexerSimple.cxx scite-3.4.4/scintilla/lexlib/LexerSimple.h scite-3.4.4/scintilla/lexlib/OptionSet.h scite-3.4.4/scintilla/lexlib/PropSetSimple.cxx scite-3.4.4/scintilla/lexlib/PropSetSimple.h scite-3.4.4/scintilla/lexlib/SparseState.h scite-3.4.4/scintilla/lexlib/StringCopy.h scite-3.4.4/scintilla/lexlib/SubStyles.h scite-3.4.4/scintilla/lexlib/WordList.cxx scite-3.4.4/scintilla/lexlib/WordList.h scite-3.4.4/scintilla/qt/ScintillaEdit/ScintillaDocument.cpp scite-3.4.4/scintilla/qt/ScintillaEdit/ScintillaDocument.h scite-3.4.4/scintilla/qt/ScintillaEdit/WidgetGen.py scite-3.4.4/scintilla/qt/ScintillaEditBase/PlatQt.cpp scite-3.4.4/scintilla/qt/ScintillaEditBase/PlatQt.h scite-3.4.4/scintilla/qt/ScintillaEditBase/ScintillaEditBase.cpp scite-3.4.4/scintilla/qt/ScintillaEditBase/ScintillaEditBase.h scite-3.4.4/scintilla/qt/ScintillaEditBase/ScintillaQt.cpp scite-3.4.4/scintilla/qt/ScintillaEditBase/ScintillaQt.h scite-3.4.4/scintilla/qt/ScintillaEditPy/global.h scite-3.4.4/scintilla/qt/ScintillaEditPy/sepbuild.py scite-3.4.4/scintilla/qt/ScintillaEditPy/testsepq.py scite-3.4.4/scintilla/scripts/Face.py scite-3.4.4/scintilla/scripts/FileGenerator.py scite-3.4.4/scintilla/scripts/GenerateCaseConvert.py scite-3.4.4/scintilla/scripts/GenerateCharacterCategory.py scite-3.4.4/scintilla/scripts/HFacer.py scite-3.4.4/scintilla/scripts/LexGen.py scite-3.4.4/scintilla/scripts/ScintillaData.py scite-3.4.4/scintilla/src/AutoComplete.cxx scite-3.4.4/scintilla/src/AutoComplete.h scite-3.4.4/scintilla/src/CallTip.cxx scite-3.4.4/scintilla/src/CallTip.h scite-3.4.4/scintilla/src/CaseConvert.cxx scite-3.4.4/scintilla/src/CaseConvert.h scite-3.4.4/scintilla/src/CaseFolder.cxx scite-3.4.4/scintilla/src/CaseFolder.h scite-3.4.4/scintilla/src/Catalogue.cxx scite-3.4.4/scintilla/src/Catalogue.h scite-3.4.4/scintilla/src/CellBuffer.cxx scite-3.4.4/scintilla/src/CellBuffer.h scite-3.4.4/scintilla/src/CharClassify.cxx scite-3.4.4/scintilla/src/CharClassify.h scite-3.4.4/scintilla/src/ContractionState.cxx scite-3.4.4/scintilla/src/ContractionState.h scite-3.4.4/scintilla/src/Decoration.cxx scite-3.4.4/scintilla/src/Decoration.h scite-3.4.4/scintilla/src/Document.cxx scite-3.4.4/scintilla/src/Document.h scite-3.4.4/scintilla/src/Editor.cxx scite-3.4.4/scintilla/src/Editor.h scite-3.4.4/scintilla/src/ExternalLexer.cxx scite-3.4.4/scintilla/src/ExternalLexer.h scite-3.4.4/scintilla/src/FontQuality.h scite-3.4.4/scintilla/src/Indicator.cxx scite-3.4.4/scintilla/src/Indicator.h scite-3.4.4/scintilla/src/KeyMap.cxx scite-3.4.4/scintilla/src/KeyMap.h scite-3.4.4/scintilla/src/LineMarker.cxx scite-3.4.4/scintilla/src/LineMarker.h scite-3.4.4/scintilla/src/Partitioning.h scite-3.4.4/scintilla/src/PerLine.cxx scite-3.4.4/scintilla/src/PerLine.h scite-3.4.4/scintilla/src/PositionCache.cxx scite-3.4.4/scintilla/src/PositionCache.h scite-3.4.4/scintilla/src/RESearch.cxx scite-3.4.4/scintilla/src/RunStyles.cxx scite-3.4.4/scintilla/src/RunStyles.h scite-3.4.4/scintilla/src/ScintillaBase.cxx scite-3.4.4/scintilla/src/ScintillaBase.h scite-3.4.4/scintilla/src/Selection.cxx scite-3.4.4/scintilla/src/Selection.h scite-3.4.4/scintilla/src/SplitVector.h scite-3.4.4/scintilla/src/Style.cxx scite-3.4.4/scintilla/src/Style.h scite-3.4.4/scintilla/src/UniConversion.cxx scite-3.4.4/scintilla/src/UniConversion.h scite-3.4.4/scintilla/src/ViewStyle.cxx scite-3.4.4/scintilla/src/ViewStyle.h scite-3.4.4/scintilla/src/XPM.cxx scite-3.4.4/scintilla/src/XPM.h scite-3.4.4/scintilla/test/MessageNumbers.py scite-3.4.4/scintilla/test/ScintillaCallable.py scite-3.4.4/scintilla/test/XiteMenu.py scite-3.4.4/scintilla/test/XiteQt.py scite-3.4.4/scintilla/test/XiteWin.py scite-3.4.4/scintilla/test/examples/x.cxx scite-3.4.4/scintilla/test/examples/x.php scite-3.4.4/scintilla/test/examples/x.pl scite-3.4.4/scintilla/test/examples/x.py scite-3.4.4/scintilla/test/examples/x.rb scite-3.4.4/scintilla/test/lexTests.py scite-3.4.4/scintilla/test/performanceTests.py scite-3.4.4/scintilla/test/simpleTests.py scite-3.4.4/scintilla/test/unit/catch.hpp scite-3.4.4/scintilla/test/unit/testCellBuffer.cxx scite-3.4.4/scintilla/test/unit/testCharClassify.cxx scite-3.4.4/scintilla/test/unit/testContractionState.cxx scite-3.4.4/scintilla/test/unit/testDecoration.cxx scite-3.4.4/scintilla/test/unit/testPartitioning.cxx scite-3.4.4/scintilla/test/unit/testRunStyles.cxx scite-3.4.4/scintilla/test/unit/testSparseState.cxx scite-3.4.4/scintilla/test/unit/testSplitVector.cxx scite-3.4.4/scintilla/test/unit/unitTest.cxx scite-3.4.4/scintilla/test/xite.py scite-3.4.4/scintilla/win32/CheckD2D.cxx scite-3.4.4/scintilla/win32/PlatWin.cxx scite-3.4.4/scintilla/win32/PlatWin.h scite-3.4.4/scintilla/win32/ScintillaWin.cxx scite-3.4.4/scite/gtk/DirectorExtension.cxx scite-3.4.4/scite/gtk/DirectorExtension.h scite-3.4.4/scite/gtk/GTKMutex.cxx scite-3.4.4/scite/gtk/GUIGTK.cxx scite-3.4.4/scite/gtk/SciIcon.h scite-3.4.4/scite/gtk/SciTEGTK.cxx scite-3.4.4/scite/gtk/Widget.cxx scite-3.4.4/scite/gtk/Widget.h scite-3.4.4/scite/gtk/pixmapsGNOME.h scite-3.4.4/scite/scripts/CheckMentioned.py scite-3.4.4/scite/scripts/CheckPropsDoc.py scite-3.4.4/scite/scripts/IFaceTableGen.py scite-3.4.4/scite/scripts/RegenerateSource.py scite-3.4.4/scite/scripts/checkbuildlinux.sh scite-3.4.4/scite/scripts/commandsdoc.py scite-3.4.4/scite/scripts/makerpms.py scite-3.4.4/scite/scripts/tags2api.py scite-3.4.4/scite/src/Cookie.cxx scite-3.4.4/scite/src/Cookie.h scite-3.4.4/scite/src/Credits.cxx scite-3.4.4/scite/src/Exporters.cxx scite-3.4.4/scite/src/Extender.h scite-3.4.4/scite/src/FilePath.cxx scite-3.4.4/scite/src/FilePath.h scite-3.4.4/scite/src/FileWorker.cxx scite-3.4.4/scite/src/FileWorker.h scite-3.4.4/scite/src/GUI.h scite-3.4.4/scite/src/IFaceTable.cxx scite-3.4.4/scite/src/IFaceTable.h scite-3.4.4/scite/src/JobQueue.cxx scite-3.4.4/scite/src/JobQueue.h scite-3.4.4/scite/src/LuaExtension.cxx scite-3.4.4/scite/src/LuaExtension.h scite-3.4.4/scite/src/MatchMarker.cxx scite-3.4.4/scite/src/MatchMarker.h scite-3.4.4/scite/src/MultiplexExtension.cxx scite-3.4.4/scite/src/MultiplexExtension.h scite-3.4.4/scite/src/Mutex.h scite-3.4.4/scite/src/PropSetFile.cxx scite-3.4.4/scite/src/PropSetFile.h scite-3.4.4/scite/src/SString.h scite-3.4.4/scite/src/SciTE.h scite-3.4.4/scite/src/SciTEBase.cxx scite-3.4.4/scite/src/SciTEBase.h scite-3.4.4/scite/src/SciTEBuffers.cxx scite-3.4.4/scite/src/SciTEIO.cxx scite-3.4.4/scite/src/SciTEKeys.h scite-3.4.4/scite/src/SciTEProps.cxx scite-3.4.4/scite/src/StringHelpers.cxx scite-3.4.4/scite/src/StringHelpers.h scite-3.4.4/scite/src/StringList.cxx scite-3.4.4/scite/src/StringList.h scite-3.4.4/scite/src/StripDefinition.h scite-3.4.4/scite/src/StyleDefinition.cxx scite-3.4.4/scite/src/StyleDefinition.h scite-3.4.4/scite/src/StyleWriter.cxx scite-3.4.4/scite/src/StyleWriter.h scite-3.4.4/scite/src/Utf8_16.cxx scite-3.4.4/scite/src/Utf8_16.h scite-3.4.4/scite/src/Worker.h scite-3.4.4/scite/src/scite_lua_win.h scite-3.4.4/scite/win32/DirectorExtension.cxx scite-3.4.4/scite/win32/DirectorExtension.h scite-3.4.4/scite/win32/GUIWin.cxx scite-3.4.4/scite/win32/SciTEWin.cxx scite-3.4.4/scite/win32/SciTEWin.h scite-3.4.4/scite/win32/SciTEWinBar.cxx scite-3.4.4/scite/win32/SciTEWinDlg.cxx scite-3.4.4/scite/win32/Strips.cxx scite-3.4.4/scite/win32/Strips.h scite-3.4.4/scite/win32/UniqueInstance.cxx scite-3.4.4/scite/win32/UniqueInstance.h scite-3.4.4/scite/win32/WinMutex.cxx [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in scite [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1269760 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: scite-3.4.4-6.fc22.i686.rpm scite-3.4.4-6.fc22.src.rpm scite.i686: W: no-manual-page-for-binary SciTE 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint scite scite.i686: W: no-manual-page-for-binary SciTE 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- scite (rpmlib, GLIBC filtered): /bin/sh libc.so.6 libcairo.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgdk-3.so.0 libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgtk-3.so.0 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpthread.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(CXXABI_1.3.8) rtld(GNU_HASH) Provides -------- scite: application() application(SciTE.desktop) mimehandler(text/plain) scite scite(x86-32) Source checksums ---------------- http://download.sourceforge.net/scintilla/scite344.tgz : CHECKSUM(SHA256) this package : e3c477d96ab233e526020ff176b7113ada0cdf90425765ca5cb7c48e55317995 CHECKSUM(SHA256) upstream package : e3c477d96ab233e526020ff176b7113ada0cdf90425765ca5cb7c48e55317995 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -rvn scite-3.4.4-6.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ------------------------------------------ 1. For new version please reset the %release to 1, I don't want to see something like 4.0.0-100 in the future. 2. Desktop file contains deprecated "Encoding" key, you should remove it. 3. LDFLAGS="%{__global_ldflags}" EL6 doesn't have it. Use LDFLAGS="%{?__global_ldflags}" instead. 4. Sorry for the typo left before, I used my pad to edit the rest part of the review...
(In reply to Christopher Meng from comment #8) > 1. For new version please reset the %release to 1, I don't want to see > something like 4.0.0-100 in the future. Of course, as you can see in the changelog I did that but I had to bump the release tag a few times as I'm maintaining a Copr for this package for testing purposes. > 2. Desktop file contains deprecated "Encoding" key, you should remove it. Fixed. > 3. LDFLAGS="%{__global_ldflags}" > > EL6 doesn't have it. Use LDFLAGS="%{?__global_ldflags}" instead. Fixed. Spec URL: http://opuk.fedorapeople.org/scite.spec SRPM URL: http://opuk.fedorapeople.org/SRPMS/scite-3.4.4-7.fc20.src.rpm Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=7136542
You should use --remove-key instead of using sed as you've used --remove-category... BTW, why build without lua support?
(In reply to Christopher Meng from comment #10) > You should use --remove-key instead of using sed as you've used > --remove-category... Sure, I will fix that. > BTW, why build without lua support? As it only builds against the bundled library there is some patching needed in order to get it to work. I've been looking in to patch this as upstream seems unwilling to unbundle the library[0] but it's not ready yet. [0]: https://groups.google.com/forum/#!topic/scintilla-interest/RKH67BBqRts
Spec URL: http://opuk.fedorapeople.org/scite.spec SRPM URL: http://opuk.fedorapeople.org/SRPMS/scite-3.4.4-8.fc20.src.rpm
PACKAGE APPROVED.
Package Change Request ====================== Package Name: scite New Branches: f20 f21 el6 el7 Owners: opuk
Git done (by process-git-requests).
Updated; Swap with bug 1122332.
scite-3.4.4-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/scite-3.4.4-1.fc20
scite-3.4.4-1.fc20 has been pushed to the Fedora 20 testing repository.
scite-3.4.4-1.fc20 has been pushed to the Fedora 20 stable repository.
Can we get this into EPEL6?
Somehow this review missed the bundled copy of scintilla.
I'm packaging base scintilla which could be used a shared library to build other widget toolkit bridges on top. Unfortunately upstream ships scintilla tighten to GTK toolkit and does not have interest in decoupling them.