rpmlint says:

ocaml-srpm-macros.src: W: no-url-tag
ocaml-srpm-macros.noarch: W: no-url-tag
ocaml-srpm-macros.noarch: W: no-documentation
ocaml-srpm-macros.noarch: E: script-without-shebang /etc/rpm/macros.ocaml-srpm

Needless to say, I believe the script-without-shebang error is
completely bogus.  There is no executable bit and it's not in
an executable directory.

I can't think of a suitable URL to use, so I didn't add one.

There is no documentation because the entire package consists of
a single self-documenting file.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6740988

I'll take this

APPROVED.

Side note: you don't need the %prep and %build placeholders if they're not actually used.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ latest version packaged
n/a %doc includes license file    
+ spec file written in American English
+ spec file is legible
n/a upstream sources match sources in the srpm
+ package successfully builds on at least one architecture
  tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ Package perserves timestamps on install
+ Permissions on files must be set properly 
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
n/a files marked %doc should not affect package runtime 
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8

Optional:

- if there is no license file, packager should query upstream to include it
  I don't believe it's necessary and none of the other similar macro rpms provide it either
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
n/a the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a non -devel packages should require fully versioned base
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
n/a Package should have man files

Thanks for the review.  I didn't have %prep and %build originally
and as you say RPM worked fine.  However rpmlint said ...

ocaml-srpm-macros.spec: W: no-%prep-section
The spec file does not contain a %prep section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality.  Add the section, even if
empty.

ocaml-srpm-macros.spec: W: no-%build-section
The spec file does not contain a %build section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality, such as injection of
automatic -debuginfo subpackages.  Add the section, even if empty.

So I guess we need them, although I'm not sure I understand rpmlint's
message.

New Package SCM Request
=======================
Package Name: ocaml-srpm-macros
Short Description: OCaml architecture macros
Owners: rjones pmatilai
Branches: 
InitialCC:

I am wondering how is this going to work in the buildsys?
Are you going to add ocaml-srpm-macros to @buildsys-build?
Otherwise AFAIK you won't be able to use this in koji.

(In reply to Jens Petersen from comment #7)
> I am wondering how is this going to work in the buildsys?
> Are you going to add ocaml-srpm-macros to @buildsys-build?
> Otherwise AFAIK you won't be able to use this in koji.

it will be a dependency of redhat-rpm-config just like the perl one is

Actually it already is required by redhat-rpm-config, ocaml-srpm-macros is just a sub-package of ocaml itself ATM. That however creates a bit of a bootstrapping problem, but that's easily avoided by creating this little package, for which we have gathered around here :)

Git done (by process-git-requests).

Cool thanks for the explanation that makes good sense then.
Maybe I should add ghc-srpm-macros to ghc-rpm-macros too then.

(In reply to Jens Petersen from comment #11)
> Cool thanks for the explanation that makes good sense then.
> Maybe I should add ghc-srpm-macros to ghc-rpm-macros too then.

That would be very welcome from my POV.

Git is ready, but I'm on holiday until Tuesday and I don't
want to risk breaking the buildroot/OCaml/Rawhide/etc by pushing
a build and then leaving.  (Note this requires adjustment of the
OCaml package and a rebuild there too, so it's not a totally
straightforward change).

Therefore I'll do this on Tuesday next week.  Setting NEEDINFO of me.

(In reply to Panu Matilainen from comment #12)
> (In reply to Jens Petersen from comment #11)
> > Maybe I should add ghc-srpm-macros to ghc-rpm-macros too then.
> That would be very welcome from my POV.

Okay thanks - I created bug 1089102 for that.
I think I will do it as part of the GHC_7.8 Change for F21.

http://koji.fedoraproject.org/koji/taskinfo?taskID=6764068