Spec URL: http://gil.fedorapeople.org/argparse4j.spec SRPM URL: http://gil.fedorapeople.org/argparse4j-0.4.3-1.fc19.src.rpm Description: Java port of Python's famous argparse command-line argument parser. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6740961
Spec URL: http://gil.fedorapeople.org/argparse4j.spec SRPM URL: http://gil.fedorapeople.org/argparse4j-0.4.4-1.fc20.src.rpm - update to 0.4.4 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=8633281
Spec URL: http://gil.fedorapeople.org/argparse4j.spec SRPM URL: http://gil.fedorapeople.org/argparse4j-0.4.4-1.fc20.src.rpm - add sub-package docs Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=8637902
Hi Gil, One small issue, see below. Thanks, Gerard. Issues: ======= [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated", "*No copyright* Apache (v2.0)". 26 files have unknown license. Detailed output of licensecheck in /home/grdryn/1087895-argparse4j/licensecheck.txt ^^Two files have ASL 2.0 license argparse4j-argparse4j-0.4.4/src/main/java/net/sourceforge/argparse4j/impl/type/FileArgumentType.java argparse4j-argparse4j-0.4.4/src/main/java/net/sourceforge/argparse4j/internal/TerminalWidth.java Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated", "*No copyright* Apache (v2.0)". 26 files have unknown license. Detailed output of licensecheck in /home/grdryn/1087895-argparse4j/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 675840 bytes in 35 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in argparse4j- javadoc , argparse4j-docs [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: argparse4j-0.4.4-1.fc22.noarch.rpm argparse4j-javadoc-0.4.4-1.fc22.noarch.rpm argparse4j-docs-0.4.4-1.fc22.noarch.rpm argparse4j-0.4.4-1.fc22.src.rpm argparse4j.noarch: W: spelling-error Summary(en_US) argparse -> sparse, parsec, parse argparse4j.noarch: W: spelling-error %description -l en_US argparse -> sparse, parsec, parse argparse4j-docs.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/argparse4j-docs/html/_static/jquery.js argparse4j.src: W: spelling-error Summary(en_US) argparse -> sparse, parsec, parse argparse4j.src: W: spelling-error %description -l en_US argparse -> sparse, parsec, parse 4 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- argparse4j-javadoc (rpmlib, GLIBC filtered): jpackage-utils argparse4j-docs (rpmlib, GLIBC filtered): argparse4j-javadoc argparse4j (rpmlib, GLIBC filtered): java-headless jpackage-utils Provides -------- argparse4j-javadoc: argparse4j-javadoc argparse4j-docs: argparse4j-docs argparse4j: argparse4j mvn(net.sourceforge.argparse4j:argparse4j) mvn(net.sourceforge.argparse4j:argparse4j:pom:) Source checksums ---------------- https://github.com/tatsuhiro-t/argparse4j/archive/argparse4j-0.4.4.tar.gz : CHECKSUM(SHA256) this package : 6b3014b7967d1e4348895e7a35c3ac1cf543fe531c34b69437dcb49b3da66d0f CHECKSUM(SHA256) upstream package : 6b3014b7967d1e4348895e7a35c3ac1cf543fe531c34b69437dcb49b3da66d0f Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1087895 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Spec URL: http://gil.fedorapeople.org/argparse4j.spec SRPM URL: http://gil.fedorapeople.org/argparse4j-0.4.4-2.fc20.src.rpm - fix license field - remove bundled jquery
(In reply to gil cattaneo from comment #4) > Spec URL: http://gil.fedorapeople.org/argparse4j.spec > SRPM URL: http://gil.fedorapeople.org/argparse4j-0.4.4-2.fc20.src.rpm > > - fix license field > - remove bundled jquery Thanks Gil, it looks good to me now, all issues have been fixed. Source tarballs are identical, and here's spec diff: [grdryn@localhost updated]$ diff -u ../srpm-unpacked/argparse4j.spec argparse4j.spec --- ../srpm-unpacked/argparse4j.spec 2015-01-19 01:11:57.000000000 +0000 +++ argparse4j.spec 2015-01-24 17:50:29.696160080 +0000 @@ -1,8 +1,10 @@ Name: argparse4j Version: 0.4.4 -Release: 1%{?dist} +Release: 2%{?dist} Summary: The command-line parser library based on Python's argparse -License: MIT +# files with ASL 2.0 src/main/java/net/sourceforge/argparse4j/impl/type/FileArgumentType.java +# src/main/java/net/sourceforge/argparse4j/internal/TerminalWidth.java +License: ASL 2.0 and MIT URL: http://argparse4j.sourceforge.net Source0: https://github.com/tatsuhiro-t/argparse4j/archive/%{name}-%{version}.tar.gz @@ -52,6 +54,7 @@ cd src/site/sphinx %{__make} %{?_smp_mflags} html PACKAGE_VERSION=%{version} rm -r _build/html/.buildinfo +rm -r _build/html/_static/jquery.js %install %mvn_install @@ -68,6 +71,10 @@ %doc LICENSE.txt src/site/sphinx/_build/html/ %changelog +* Sat Jan 24 2015 gil cattaneo <puntogil> 0.4.4-2 +- fix license field +- remove bundled jquery + * Fri Jan 16 2015 gil cattaneo <puntogil> 0.4.4-1 - update to 0.4.4
Thanks for the review! New Package SCM Request ======================= Package Name: argparse4j Short Description: The command-line parser library based on Python's argparse Upstream URL: http://argparse4j.sourceforge.net Owners: gil Branches: f21 InitialCC: java-sig
Git done (by process-git-requests).
argparse4j-0.4.4-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/argparse4j-0.4.4-2.fc21
argparse4j-0.4.4-2.fc21 has been pushed to the Fedora 21 testing repository.
argparse4j-0.4.4-2.fc21 has been pushed to the Fedora 21 stable repository.