Spec URL: http://people.parinux.org/~seyman/fedora/perl-Class-Forward/perl-Class-Forward.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Class-Forward/perl-Class-Forward-0.100006-1.fc20.src.rpm Description: Class::Forward is designed to resolve Perl namespaces from shorthand (which is simply a file-path-like specification). Class::Forward can also be used to dispatch method calls using said shorthand. See the included exported functions for examples on how this can be used. Fedora Account System Username: eseyman
Licensing is fine. FIX: BR: perl(Exporter) # line 10 of lib/Class/Forward TODO: Change the by author Source0 to a by module URL "Source0: http://www.cpan.org/modules/by-module/Class/Class-Forward-%{version}.tar.gz" This will protect you if the author changes in the future. You can remove the "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;" line. It is not required except for EL5. You can update the "make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT" to "make pure_install DESTDIR=$RPM_BUILD_ROOT" reference can be found at https://fedoraproject.org/wiki/Perl/Tips?rd=PackagingTips/Perl#Makefile.PL_vs_Build.PL
(In reply to David Dick from comment #1) > TODO: > > Change the by author Source0 to a by module URL There is no such rule in the FPG. Conversely, it is commonly recommended practice to use by-author URLs and to not use by-module URLs, because by-module URLs have shown to be unreliable. IIRC, there even once was a rule in some FPG-appendix, which mandated using by-author URLs, because of this, but I can't find it right now nor do I recall what has happened to this.
Hi Ralf, If Emmanuel would prefer to stay with by-author, i have no problems with approving the package (hence the TODO section) In my experience, i've had modules that i depend on change author (original authors hand over modules to new maintainers), causing me to rewrite spec files (non offical fedora/redhat) to keep up.
Hi Emmanuel, I forgot an additional TODO: Removal of the "cpanfile" file from %doc. This file seems to be just specifying dependencies for the package.
(In reply to David Dick from comment #1) > Licensing is fine. > > FIX: > > BR: perl(Exporter) # line 10 of lib/Class/Forward Done. (In reply to David Dick from comment #3) > > If Emmanuel would prefer to stay with by-author, i have no problems with > approving the package (hence the TODO section) The vast majority of the Perl packages I maintain have by-author Source0 lines so I'll stick with that. > In my experience, i've had modules that i depend on change author (original > authors hand over modules to new maintainers), causing me to rewrite spec > files (non offical fedora/redhat) to keep up. Indeed, I've seen maintainers cease to maintain packages over stuff like this. (In reply to David Dick from comment #4) > > Removal of the "cpanfile" file from %doc. > > This file seems to be just specifying dependencies for the package. Done. Spec URL: http://people.parinux.org/~seyman/fedora/perl-Class-Forward/perl-Class-Forward.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Class-Forward/perl-Class-Forward-0.100006-2.fc20.src.rpm
APPROVED
Thanks for the review, David. New Package SCM Request ======================= Package Name: perl-Class-Forward Short Description: Namespace Dispatch and Resolution Owners: eseyman Branches: f20 InitialCC: perl-sig
Git done (by process-git-requests).
Package is in Rawhide and F20. Thanks for the git repo, Jens.