Spec URL: http://people.parinux.org/~seyman/fedora/perl-Search-Elasticsearch/perl-Search-Elasticsearch.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Search-Elasticsearch/perl-Search-Elasticsearch-1.10-1.fc20.src.rpm Description: Search::Elasticsearch is the official Perl client for Elasticsearch, supported by elasticsearch.com. Elasticsearch itself is a flexible and powerful open source, distributed real-time search and analytics engine for the cloud. You can read more about it on elasticsearch.org. Fedora Account System Username: eseyman
FIX: License: ASL 2.0 is the correct value according to https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses BR: perl(strict) # t/lib/MockCxn.pm at line 3 (used in t/40_Transport/30_perform_request.t) BR: perl(warnings) # t/lib/MockCxn.pm at line 4 (used in t/40_Transport/30_perform_request.t) BR: perl(lib) # t/30_Logger/60_trace_error.t at line 4 BR: perl(IO::Socket) # lib/Search/Elasticsearch/TestServer.pm at line 7 BR: perl(POSIX) # lib/Search/Elasticsearch/TestServer.pm at line 5 BR: perl(IO::Select) # lib/Search/Elasticsearch/Role/CxnPool.pm at line 6 BR: perl(overload) # lib/Search/Elasticsearch/Error.pm at line 28 Req: perl(MIME::Base64) # lib/Search/Elasticsearch/Role/Cxn/HTTP.pm at line 62 Req: perl(IO::Uncompress::Inflate) # lib/Search/Elasticsearch/Role/Cxn/HTTP.pm at line 132 Req: perl(IO::Socket::SSL) # lib/Search/Elasticsearch/Cxn/HTTPTiny.pm at line 62 BR: perl(JSON::XS) and BR: perl(URI::Escape::XS) are specified in the META.* files, but does not seem to be referenced at all. If you want to include it, you should probably include a Run Time Require as well TODO: find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; can be removed make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT can be changed to make pure_install DESTDIR=$RPM_BUILD_ROOT
Petr, can you confirm my recommendation for License?
koji build is located at http://koji.fedoraproject.org/koji/taskinfo?taskID=6748557
(In reply to David Dick from comment #2) > Petr, can you confirm my recommendation for License? It is indead. Spec URL: http://people.parinux.org/~seyman/fedora/perl-Search-Elasticsearch/perl-Search-Elasticsearch.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Search-Elasticsearch/perl-Search-Elasticsearch-1.10-2.fc20.src.rpm
You've got a duplicate Requires: perl(IO::Uncompress::Inflate) line and you've missed BR: perl(POSIX) # lib/Search/Elasticsearch/TestServer.pm at line 5 BR: perl(IO::Select) # lib/Search/Elasticsearch/Role/CxnPool.pm at line 6 As noted in the review above, you should probably put Requires: perl(URI::Escape::XS) Requires: perl(JSON::XS) in as well, as the rpm auto depends code does not detect them. However, package APPROVED.
Done. Spec URL: http://people.parinux.org/~seyman/fedora/perl-Search-Elasticsearch/perl-Search-Elasticsearch.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Search-Elasticsearch/perl-Search-Elasticsearch-1.10-3.fc20.src.rpm New Package SCM Request ======================= Package Name: perl-Search-Elasticsearch Short Description: Official client for Elasticsearch Owners: eseyman Branches: InitialCC: perl-sig
Git done (by process-git-requests).
Submitted to rawhide. Thank you, David and Jon.