Bug 1088277 - Review Request: rubygem-morph-cli - Runs Morph scrapers from the command line
Summary: Review Request: rubygem-morph-cli - Runs Morph scrapers from the command line
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michal Fojtik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-16 11:02 UTC by Lubomir Rintel
Modified: 2014-07-25 19:54 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-25 19:54:32 UTC
Type: Bug
Embargoed:
mfojtik: fedora-review+
petersen: fedora-cvs+


Attachments (Terms of Use)

Description Lubomir Rintel 2014-04-16 11:02:21 UTC
SPEC: http://v3.sk/~lkundrak/SPECS/rubygem-morph-cli.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/rubygem-morph-cli-0.2-1.el7.src.rpm
Mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=6745429

Description:

Actually it will run them on the Morph server identically to the real thing.
That means not installing a bucket load of libraries and bits and bobs that are
already installed with the Morph scraper environments.

Comment 1 Michal Fojtik 2014-04-16 20:50:07 UTC
Lubo:

* I think the 'git' magic in %setup, can be replaced with a patch for the gemspec that provide a full list of files there (or replace it with "Dir['lib/*.rb'] + Dir['bin/*']" (but tbh I like the 'git init' hack as it seems less pain as maintaining the patch, why don't you include the 'bin' folder there as well? ;-)

* there are no tests which will make QA unhappy, but they don't exists in upstream so OK by me.

* everything else seems pretty sane to me, so review+

Comment 2 Lubomir Rintel 2014-04-16 23:01:10 UTC
New Package SCM Request
=======================
Package Name: rubygem-morph-cli
Short Description: Runs Morph scrapers from the command line
Owners: lkundrak
Branches: f19 f20 el6 epel7

Comment 3 Jens Petersen 2014-04-17 06:37:18 UTC
Git done (by process-git-requests).

Comment 4 Lubomir Rintel 2014-07-25 19:54:32 UTC
Imported and built.

Thank you!


Note You need to log in before you can comment on or make changes to this bug.