Description of problem: Port numbers configured on Socket Binding (domain-host) screen are not propagated into domain configuration files. Version-Release number of selected component (if applicable): 6.3.0.ER1 How reproducible: Always Steps to Reproduce: 1. Run gui installer, go to Socket Bindings screen 2. Choose to Configure custom port bindings -> Configure ports for domain mode, Press next to go to Socket Binding (domain-host) screen 3. Change default values for management-native Port Number and management-http Port Number 4. Finish the installation Actual results: Default values for management-native port and management-http port are used in all domain configuration files (host.xml, host-slave.xml, and host-master.xml). Expected results: Values entered by user for management-native port and management-http port are used in all domain configuration files (host.xml, host-slave.xml, and host-master.xml). Additional info: This is a regression against 6.2.0 installer.
Changes has been made to ensure domain configuration files are modified correctly when values entered by user for management-native port and management-http port are configured.
The fix brought back https://bugzilla.redhat.com/show_bug.cgi?id=1026241. Value of jboss.domain.master.port in host-slave.xml is changed to value of jboss.management.native.port
To be more specific, value entered as 'Default Value' of 'management native Port Number' on 'Socket Binding (domain-host)' screen is used for jboss.domain.master.port in host-slave.xml file.
Ensuring that the value of jboss.domain.master.port in host-slave.xml will always have the port value of 9999. http://git.app.eng.bos.redhat.com/git/installer-commons.git/commit/?id=395f73bcb8aa8dd5dcce2740f976fd5695f07504
Hi Miles, there is one thing I would like you to fix (sorry, I should have looked into the commit earlier). This is how I expect to jboss.domain.master.port behave: - jboss.domain.master.port property has always the same name (there is no field to configure it in 'Socket Binding (domain-host)' screen) - changing the port or property name of 'management-native Port number' on 'Socket Binging (domain-host)' screen will not change values for jboss.domain.master.port - however I would expect that 'Configure an offset for all default port bindings.' option will update also the jboss.domain.master.port port number What do you think?
Hello, 1. jboss.domain.master.port will always have the name "jboss.domain.master.port" there is currently no way to change this. It is only set in one place OffsetVariableBridgeAction.java 2. Changing port property of 'management-native Port number' will not change values for "jboss.domain.master.port". See OffsetVariableBridgeAction.java where it is set, the name if hard coded to "jboss.domain.master.port", also port will always start of with 9999 3. I have added the portOffset to be added to the "jboss.domain.master.port", see commit. So the only changes I have made was to accommodate #3. Please let me know if I'm missing anything. https://code.engineering.redhat.com/gerrit/gitweb?p=installer-commons.git;a=commit;h=f7e52aaf5e2f4e841985f1ab3a50c6ba20b310d8
Yes, this should be it, thanks.
Verified on EAP 6.3.0.ER5 installer.