Bug 1089054 - gf-error-codes.h is missing from source tarball
Summary: gf-error-codes.h is missing from source tarball
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On: 1038391
Blocks: glusterfs-3.5.1
TreeView+ depends on / blocked
 
Reported: 2014-04-17 18:55 UTC by Niels de Vos
Modified: 2014-06-24 11:04 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.5.1beta
Doc Type: Bug Fix
Doc Text:
Clone Of: 1038391
Environment:
Last Closed: 2014-06-24 11:04:54 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2014-04-17 18:55:12 UTC
Bug 1038391 contains an incomplete/unmerged fix for mainline, we need a backport for 3.5.1 too.

Reported: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6138


+++ This bug was initially created as a clone of Bug #1038391 +++

Description of problem:

Source tarballs for 3.5qa1 & 3.5qa2 are missing gf-error-codes.h.  It is necessary to run autogen.sh to generate the file before running configure.

Version-Release number of selected component (if applicable):

3.5qa1 & 3.5qa2

How reproducible:

Consistently

Steps to Reproduce:
1. Download source tarball (http://bits.gluster.org/pub/gluster/glusterfs/src/glusterfs-3.5qa2.tar.gz)
2. Run configure
3. Run make

Actual results:
very early in the build process, the following error halts progress...

logging.c:29:28: fatal error: gf-error-codes.h: No such file or directory


Expected results:

glusterfs builds completely

Additional info:

I'm not certain if this is a bug or not.  In all previous release tarballs of glusterfs it was not necessary to run autogen.sh before configure.  Now with the 3.5qa releases it is necessary to run autogen.sh to generate gf-error-codes.h

Thank you.

--- Additional comment from Bala.FA on 2013-12-10 06:42:29 CET ---


Lous, This http://review.gluster.org/#/c/5382/ may be interesting fix.

./autogen.sh is necessary when updating error codes and maintainer does before releasing tarball, I think we could include gf-error-codes.h file in the tarball.

Comment 1 Anand Avati 2014-05-22 14:37:16 UTC
REVIEW: http://review.gluster.org/7850 (tests/rpm: always run ./autogen.sh to create missing files) posted (#1) for review on release-3.5 by Niels de Vos (ndevos)

Comment 2 Anand Avati 2014-05-22 14:37:47 UTC
REVIEW: http://review.gluster.org/7851 (logging: remove unused message-id scripts) posted (#1) for review on release-3.5 by Niels de Vos (ndevos)

Comment 3 Anand Avati 2014-05-23 07:48:28 UTC
REVIEW: http://review.gluster.org/7851 (logging: remove unused message-id scripts) posted (#2) for review on release-3.5 by Niels de Vos (ndevos)

Comment 4 Anand Avati 2014-05-23 18:21:04 UTC
COMMIT: http://review.gluster.org/7850 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit b0ac8069119532fabaafc12650d87da698138a1f
Author: Niels de Vos <ndevos>
Date:   Thu May 22 16:35:35 2014 +0200

    tests/rpm: always run ./autogen.sh to create missing files
    
    In some occasions 'install-sh' seems to be missing in the 'make dist'
    tarball when ./autogen.sh has not been run (skipped when 'configure'
    exists). With this changes, 'autogen.sh' is always run so that missing
    files should get added to the tarball.
    
    Also write the logs from mock to a known location, and copy them to the
    '/var/log/' directory that Jenkins archives after a regression test
    failure. This makes it easier to find build issues that mock detects.
    
    Cherry picked from commit 79de5b63775f1ab8e2e498fd51b55509a30cd896:
    > Change-Id: I8d0cf1afef61ebab0137aa0d20521e75a35ddbdd
    > BUG: 1038391
    > Signed-off-by: Niels de Vos <ndevos>
    > Reviewed-on: http://review.gluster.org/7786
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle>
    > Reviewed-by: Anand Avati <avati>
    
    Change-Id: I8d0cf1afef61ebab0137aa0d20521e75a35ddbdd
    BUG: 1089054
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/7850
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: Gluster Build System <jenkins.com>

Comment 5 Anand Avati 2014-05-24 15:26:16 UTC
COMMIT: http://review.gluster.org/7851 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit d74024b470fdd0e1d0b14aeb7e914d4d64aa2a24
Author: Niels de Vos <ndevos>
Date:   Thu May 22 16:35:48 2014 +0200

    logging: remove unused message-id scripts
    
    The current unused implementation for message-ids in the logs depends on
    automatically generated files. The generated files are not included in
    the distributed tarball. This causes issues when distributions build
    packages, they need to re-run ./autogen.sh to create the needed files.
    
    I thought of including the generated files in the distribution tarball.
    However, the contents of these files are not actively used, so it seems
    to make more sense to drop it all together. These functions were the
    only users of libintl and gettext too, so dropped the requirement
    checking from configure.ac.
    
    A replacement for the message-id logging framework is in progress. Any
    changes that this patch makes, can be reverted in the submission of
    patches for the new framework.
    
    Cherry picked from commit cec37c9b66b8711b213f114875d215f56b8120aa:
    > Reference: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6212
    > Change-Id: Iea82dd3910944a5c6be3ee393806eccabd575e11
    > BUG: 1038391
    > Signed-off-by: Niels de Vos <ndevos>
    > Reviewed-on: http://review.gluster.org/7714
    > Tested-by: Gluster Build System <jenkins.com>
    > Reviewed-by: Vijay Bellur <vbellur>
    
    Change-Id: Iea82dd3910944a5c6be3ee393806eccabd575e11
    BUG: 1089054
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/7851
    Tested-by: Gluster Build System <jenkins.com>

Comment 6 Niels de Vos 2014-05-25 09:07:53 UTC
The first (and last?) Beta for GlusterFS 3.5.1 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.1beta release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-May/040377.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 7 Niels de Vos 2014-06-24 11:04:54 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.1, please reopen this bug report.

glusterfs-3.5.1 has been announced on the Gluster Users mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-June/040723.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.