Spec URL: http://sourceforge.net/projects/nield/files/nield-0.5.0/nield-0.5.0-1.fc20.spec SRPM URL: http://sourceforge.net/projects/nield/files/nield-0.5.0/nield-0.5.0-1.fc20.src.rpm Description: nield(Network Interface Events Logging Daemon) is a tool that receives notifications from the kernel through the netlink socket, and generates logs related to link state, neighbor cache(ARP,NDP), IP address(IPv4,IPv6), route, FIB rules, traffic control. Fedora Account System Username: t2mune
FAS username invalid. SPEC name invalid. Use your real name in bugzilla. Read carefully: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
SPEC file: 1. Packager: xxxx <txxx> Remove that. 2. ExclusiveArch: %{ix86} x86_64 Why? 3. ${RPM_BUILD_ROOT} Bad. See https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS 4. cp contrib/fedora/nield.service ${RPM_BUILD_ROOT}/%{_unitdir} Use install -pm644 to do that. 5. %clean Remove this section please. 6. %files /usr/sbin/nield /usr/sbin --> %{_sbindir} 7. %doc /usr/share/man/man8/nield.8.gz No %doc for manpages please. Also list manpages by: %{_mandir}/man8/nield.8* 8. * Thu Apr 17 2014 t2mune - 0.5.0-1 Who are you? Name? Email address? I assume you are not a troll.
Also, 9. [ -d ${RPM_BUILD_ROOT}/%{_unitdir} ] || mkdir -p ${RPM_BUILD_ROOT}/%{_unitdir} You don't need to use script here, just mkdir -p %{buildroot}%{_unitdir} is enough.
Hi Christopher, Thank you for your comments. I've posted a new version, taking account of them: Spec URL: http://sourceforge.net/projects/nield/files/nield-0.5.0/nield.spec SRPM URL: http://sourceforge.net/projects/nield/files/nield-0.5.0/nield-0.5.0-1.fc20.src.rpm Description: nield(Network Interface Events Logging Daemon) is a tool that receives notifications from the kernel through the netlink socket, and generates logs related to link state, neighbor cache(ARP,NDP), IP address(IPv4,IPv6), route, FIB rules, traffic control. Fedora Account System Username: t2mune
Please use spaces after parentheses! License is GPLv2+, run licensecheck on the source code to see why! As you are the developer, you should state the license in every file, not just a random few. The changelog format is not correct yet: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs Use the version macro in the Source line. You can also use the name macro there. You must include %doc COPYING in the files section of your spec file and I recommend adding "ChangeLog" as well.
I meant _before_!
Hi Volker, Tyank you for comments. > Please use spaces after parentheses! Could you give me more details?
Oh, just "Blah blah (something)" instead of "Blah blah(something)".
I uploaded new files: Spec URL: http://sourceforge.net/projects/nield/files/nield-0.5.0/nield.spec SRPM URL: http://sourceforge.net/projects/nield/files/nield-0.5.0/nield-0.5.0-1.fc20.src.rpm Description: nield (Network Interface Events Logging Daemon) is a tool that receives notifications from the kernel through the netlink socket, and generates logs related to link state, neighbor cache (ARP,NDP), IP address (IPv4,IPv6), route, FIB rules, traffic control. Fedora Account System Username: t2mune
(In reply to Volker Fröhlich from comment #5) > License is GPLv2+, run licensecheck on the source code to see why! As you > are the developer, you should state the license in every file, not just a > random few. This package include a part of files in linux-headers (GPL), but there are no mention of a license and copyright in some files. What would be the best thing to do?
Please also follow this carefully: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers
Updated so as not to include kernel header files. Could you review them? Spec URL: http://sourceforge.net/projects/nield/files/nield-0.5.1/fedora/nield.spec SRPM URL: http://sourceforge.net/projects/nield/files/nield-0.5.1/fedora/nield-0.5.1-1.fc20.src.rpm Description: The Network Interface Events Logging Daemon is a tool that receives notifications from the kernel through the netlink socket, and generates logs related to link state, neighbor cache (ARP,NDP), IP address (IPv4,IPv6), route, FIB rules, traffic control. Fedora Account System Username: t2mune And I ran licensecheck and rpmlint. "netlink" is not a spelling error. [t2mune@fedora20 ~]$ licensecheck nield-0.5.1/* nield-0.5.1/src/tcmsg_filter.c: GPL (v2 or later) nield-0.5.1/src/debug.c: GPL (v2 or later) nield-0.5.1/src/log.c: GPL (v2 or later) nield-0.5.1/src/ndmsg.c: GPL (v2 or later) nield-0.5.1/src/nlmsg.c: GPL (v2 or later) nield-0.5.1/src/rtmsg.c: GPL (v2 or later) nield-0.5.1/src/nield.h: GPL (v2 or later) nield-0.5.1/src/nield.c: GPL (v2 or later) nield-0.5.1/src/tcmsg_qdisc.c: GPL (v2 or later) nield-0.5.1/src/frhdr.c: GPL (v2 or later) nield-0.5.1/src/ifimsg.c: GPL (v2 or later) nield-0.5.1/src/ifamsg.c: GPL (v2 or later) nield-0.5.1/src/list.h: GPL (v2 or later) nield-0.5.1/src/rtnetlink.h: GPL (v2 or later) nield-0.5.1/src/tcamsg.c: GPL (v2 or later) [t2mune@fedora20 ~]$ rpmlint rpmbuild/SPECS/nield.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [t2mune@fedora20 ~]$ rpmlint rpmbuild/SRPMS/nield-0.5.1-1.fc20.src.rpm nield.src: W: spelling-error %description -l en_US netlink -> net link, net-link, linnet 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Read carefully: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers Find which step you forgot to follow, then do it.
Tetsumune, any progress concerning a sponsorship?
No progress.
No activity in 4 years, closing!