RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1089179 - The error is inaccurate when create snapshot with memspec snapshot=external and diskspec snapshot=no
Summary: The error is inaccurate when create snapshot with memspec snapshot=external a...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Peter Krempa
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-18 08:12 UTC by Shanzhi Yu
Modified: 2015-03-05 07:34 UTC (History)
5 users (show)

Fixed In Version: libvirt-1.2.7-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-05 07:34:34 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
libvirtd log (5.95 MB, text/x-log)
2014-04-18 08:18 UTC, Shanzhi Yu 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:0323 0 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2015-03-05 12:10:54 UTC

Description Shanzhi Yu 2014-04-18 08:12:05 UTC 
Description of problem:

The error is inaccurate when create snapshot with memspec snapshot=external and diskspec snapshot=no

Version-Release number of selected component (if applicable):

libvirt-1.1.1-29.el7.x86_64
qemu-kvm-rhev-1.5.3-45.el7.x86_64

How reproducible:

100%

Steps to Reproduce:

1.prepare an guest with an heath guest os installed. keep it running status
# virsh list --all
 Id    Name                           State
----------------------------------------------------
 35    rhel6                          running

2.do snapshot with memspec snapshot=external diskspec snapshot=no

# virsh snapshot-create-as rhel6 --memspec snapshot=external,file=/tmp/sss --diskspec sda,snapshot=no --diskspec vdb,snapshot=no

error: An error occurred, but the cause is unknown

3.

Actual results:


Expected results:

libvirt should can do such type snapshot, or give an accurate error info

Additional info:
Comment 1 Shanzhi Yu 2014-04-18 08:15:28 UTC 
This also occur on rhel6 with libvirt-0.10.2-33.el6.x86_64
Comment 2 Shanzhi Yu 2014-04-18 08:18:32 UTC 
Created attachment 887458 [details]
libvirtd log
Comment 3 Ján Tomko 2014-05-29 12:51:56 UTC 
Fixed upstream:
commit cb6681ff1de3d02e8d88ce3b391ba03f8dd612f4
Author:     Peter Krempa <pkrempa>
AuthorDate: 2014-05-20 15:22:14 +0200
Commit:     Peter Krempa <pkrempa>
CommitDate: 2014-05-20 19:28:10 +0200

    qemu: snapshot: Fix return value of external checkpoint with no disks
    
    When doing an external checkpoint of a VM with no disk selected we'd
    return failure but not set error code. This was a result of ret not
    being set to 0 during walking of the disk array.
    
    Rework early failure checking and set the error code to success before
    iterating the array of disks so that we return success if no disks are
    snapshotted.
    
    Fixes the following symptom (or without --diskspec for diskless VMs)
    
     $ virsh snapshot-create-as snapshot-test  --memspec /tmp/asdf --diskspec hda,snapshot=no
     error: An error occurred, but the cause is unknown

git describe: v1.2.4-107-gcb6681f contains: v1.2.5-rc1~22
Comment 5 Yang Yang 2014-09-26 07:20:27 UTC 
Verified it on
qemu-kvm-rhev-2.1.0-5.el7.x86_64
libvirt-1.2.8-3.el7.x86_64

Steps：
1. # virsh list --all
 Id    Name                           State
----------------------------------------------------
 2     qe-con                         running

2. # virsh snapshot-create-as qe-con --memspec snapshot=external,file=/tmp/s1 --diskspec hda,snapshot=no
Domain snapshot 1411715584 created

# virsh snapshot-dumpxml qe-con 1411715584
<domainsnapshot>
  <name>1411715584</name>
  <state>running</state>
  <parent>
    <name>1411715488</name>
  </parent>
  <creationTime>1411715584</creationTime>
  <memory snapshot='external' file='/tmp/s1'/>
  <disks>
    <disk name='hda' snapshot='no'/>
  </disks>
.......

3. # virsh snapshot-create-as qe-con --memspec snapshot=external,file=/tmp/s2
Domain snapshot 1411715645 created

# virsh snapshot-dumpxml qe-con 1411715645
<domainsnapshot>
  <name>1411715645</name>
  <state>running</state>
  <parent>
    <name>1411715584</name>
  </parent>
  <creationTime>1411715645</creationTime>
  <memory snapshot='external' file='/tmp/s2'/>
  <disks>
    <disk name='hda' snapshot='external' type='file'>
      <driver type='qcow2'/>
      <source file='/tmp/disk.1411715645'/>
    </disk>
  </disks>

Since the results are expected, set it to verified
Comment 7 errata-xmlrpc 2015-03-05 07:34:34 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html
Note You need to log in before you can comment on or make changes to this bug.