Bug 1089523 - Review Request: tommyds - High performance C library for hashtables and tries
Summary: Review Request: tommyds - High performance C library for hashtables and tries
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-20 07:14 UTC by Eric Smith
Modified: 2014-05-17 05:08 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-17 05:08:29 UTC
Type: ---
Embargoed:
i: fedora-review?


Attachments (Terms of Use)

Description Eric Smith 2014-04-20 07:14:59 UTC
Spec URL: http://fedorapeople.org/~brouhaha/tommyds/tommyds.spec
SRPM URL: http://fedorapeople.org/~brouhaha/tommyds/tommyds-1.8-1.fc20.src.rpm
Description: 
TommyDS is a C library of hashtables and tries designed to store
objects with high performance.  It's faster than all the similar
libraries like rbtree, judy, googledensehash, googlebtree, stxbtree,
khash, uthash, nedtrie, judyarray and others.
Fedora Account System Username: brouhaha

Comment 1 Eric Smith 2014-04-21 22:56:23 UTC
Andrea Mazzoleni, author of both TommyDS and SnapRAID, has requested that TommyDS not be built as a shared library.  I've opened FPC ticket #423 requesting a "copylib" bundling exception.  If granted, this review request should be closed.

Comment 2 Christopher Meng 2014-04-22 00:51:08 UTC
Shouldn't it be a header only package?

Comment 3 Eric Smith 2014-04-22 01:03:44 UTC
(A small) part of the problem is that the headers may be modified for use in an application.  That's one of the reasons it should be a copylib.

If it's a copylib, then it shouldn't be a package at all.

If it's not a copylib, then it would have to include the sources. This isn't like a C++ template library, where the code is *in* the headers.

Comment 4 Eric Smith 2014-05-17 05:08:29 UTC
I am withdrawing this review, as FPC approved the SnapRAID/TommyDS bundling exception (FPC ticket #423) at their 2014-05-15 meeting.  Should any of the conditions that led to the bundling exception request change, I will contact FPC.


Note You need to log in before you can comment on or make changes to this bug.