Spec URL: http://dscott.fedorapeople.org/python-SPARQLWrapper.spec SRPM URL: http://dscott.fedorapeople.org/python-SPARQLWrapper-1.5.2-1.fc20.src.rpm Description: This is a wrapper around a SPARQL service. It helps in creating the query URI and, possibly, convert the result into a more manageable format. It complements the RDFLib library. Fedora Account System Username: dscott Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6759371
Oh, and hey, here's the rawhide SRPM (duh): SRPM URL: http://dscott.fedorapeople.org/python-SPARQLWrapper-1.5.2-1.fc21.src.rpm
I'll review this by the weekend. Taking.
[+] OK [-] NA [?] Issue ** Mandatory review guidelines: ** [?] rpmlint output: Couple of warnings that you need to fix: [asinha@ankur-laptop SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ../SPECS/python-SPARQLWrapper.spec ./python-SPARQLWrapper-1.5.2-1.fc20.src.rpm python3-SPARQLWrapper.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-SPARQLWrapper/README.txt python3-SPARQLWrapper.noarch: W: file-not-utf8 /usr/share/doc/python3-SPARQLWrapper/LICENSE.txt python-SPARQLWrapper.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-SPARQLWrapper/README.txt python-SPARQLWrapper.noarch: W: file-not-utf8 /usr/share/doc/python-SPARQLWrapper/LICENSE.txt 4 packages and 1 specfiles checked; 0 errors, 4 warnings. [asinha@ankur-laptop SRPMS]$ [+] License is acceptable (...) [+] License field in spec is correct [+] License files included in package %docs if included in source package [-] License files installed when any subpackage combination is installed [+] Spec written in American English [+] Spec is legible [+] Sources match upstream unless altered to fix permissibility issues [asinha@ankur-laptop SPECS(master *%=)]$ review-md5check.sh python-SPARQLWrapper.spec Getting https://pypi.python.org/packages/source/S/SPARQLWrapper/SPARQLWrapper-1.5.2.tar.gz to /tmp/review/SPARQLWrapper-1.5.2.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 24953 100 24953 0 0 102k 0 --:--:-- --:--:-- --:--:-- 102k dc72e43ee4382dbc3abcb1941ab3e9c0 /tmp/review/SPARQLWrapper-1.5.2.tar.gz dc72e43ee4382dbc3abcb1941ab3e9c0 /home/asinha/rpmbuild/SOURCES/SPARQLWrapper-1.5.2.tar.gz removed ‘/tmp/review/SPARQLWrapper-1.5.2.tar.gz’ removed directory: ‘/tmp/review’ [asinha@ankur-laptop SPECS(master *%=)]$ [+] Build succeeds on at least one primary arch [+] Build succeeds on all primary arches or has ExcludeArch + bugs filed [+] BuildRequires correct, justified where necessary [-] Locales handled with %find_lang, not %_datadir/locale/* [-] %post, %postun call ldconfig if package contains shared .so files [+] No bundled libs [-] Relocatability is justified [+] Package owns all directories it creates [+] Package requires others for directories it uses but does not own [+] No duplication in %files unless necessary for license files [+] File permissions are sane [+] Package contains permissible code or content [-] Large docs go in -doc subpackage [+] %doc files not required at runtime [-] Static libs go in -static package/virtual Provides [-] Development files go in -devel package [-] -devel packages Require base with fully-versioned dependency, %_isa [-] No .la files [-] GUI app uses .desktop file, installs it with desktop-file-install [+] File list does not conflict with other packages' without justification [+] File names are valid UTF-8 ** Optional review guidelines: ** [-] Query upstream about including license files [-] Translations of description, summary [+] Builds in mock [+] Builds on all arches [?] Functions as described (e.g. no crashes) Not tested. Please test it to confirm. [-] Scriptlets are sane [+] Subpackages require base with fully-versioned dependency if sensible [-] .pc file subpackage placement is sensible [-] No file deps outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin [-] Include man pages if available Naming guidelines: [+] Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+ [+] Package names are sane [+] No naming conflicts [+] Spec file name matches base package name [+] Version is sane [+] Version does not contain ~ [+] Release is sane [+] %dist tag [+] Case used only when necessary [-] Renaming handled correctly Packaging guidelines: [+] Useful without external bits [+] No kmods [?] Pre-built binaries, libs removed in %prep Please delete the bundled egginfo in %prep [+] Sources contain only redistributable code or content [+] Spec format is sane [+] Package obeys FHS, except libexecdir, /run, /usr/target [+] No files in /bin, /sbin, /lib* on >= F17 [-] Programs run before FS mounting use /run instead of /var/run [-] Binaries in /bin, /sbin do not depend on files in /usr on < F17 [-] No files under /srv, /opt, /usr/local [+] Changelog in prescribed format [+] No Packager, Vendor, Copyright, PreReq tags [+] Summary does not end in a period [-] Correct BuildRoot tag on < EL6 [-] Correct %clean section on < EL6 [?] Requires correct, justified where necessary Should anything extra be specified for the package to work properly? [+] Summary, description do not use trademarks incorrectly [-] All relevant documentation is packaged, appropriately marked with %doc [+] Doc files do not drag in extra dependencies (e.g. due to +x) [-] Code compilable with gcc is compiled with gcc [-] Build honors applicable compiler flags or justifies otherwise [-] PIE used for long-running/root daemons, setuid/filecap programs [-] Useful -debuginfo package or disabled and justified [-] Package with .pc files Requires pkgconfig on < EL6 [-] No static executables [+] Rpath absent or only used for internal libs [-] Config files marked with %config(noreplace) or justified %config [-] No config files under /usr [-] Third party package manager configs acceptable, in %_docdir [-] .desktop files are sane [+] Spec uses macros consistently [+] Spec uses macros instead of hard-coded names where appropriate [-] Spec uses macros for executables only when configurability is needed [-] %makeinstall used only when alternatives don't work [-] Macros in Summary, description are expandable at srpm build time [-] Spec uses %{SOURCE#} instead of $RPM_SOURCE_DIR and %sourcedir [+] No software collections (scl) [-] Macro files named /etc/rpm/macros.%name [+] Build uses only python/perl/shell+coreutils/lua/BuildRequired langs [+] %global, not %define [-] Package translating with gettext BuildRequires it [-] Package translating with Linguist BuildRequires qt-devel [-] File ops preserve timestamps [-] Parallel make [+] No Requires(pre,post) notation [-] User, group creation handled correctly (See Packaging:UsersAndGroups) [-] Web apps go in /usr/share/%name, not /var/www [-] Conflicts are justified [+] One project per package [+] No bundled fonts [-] Patches have appropriate commentary [+] Available test suites executed in %check [-] tmpfiles.d used for /run, /run/lock on >= F15 ** Python guidelines: ** [?] Runtime Requires correct Need to confirm. [-] Python macros declared on < EL6 [+] All .py files packaged with .pyc, .pyo counterparts [+] Includes .egg-info files/directories when generated [-] Provides/Requires properly filtered [-] Code that invokes gtk.gdk.get_pixels_array() Requires numpy Looks mostly OK. Just a few little tidbits. Thanks, Warm regards, Ankur
I beleive the same SPEC and SRPM will also compile to a python3-SPARQLWrapper-1.5.2-1.fc20.noarch
Created attachment 955710 [details] python-SPARQLWrapper-1.6.4-1.f21.src.rpm hth
Dan, Are you still looking to maintain this package and continue the package? Cheerio, Ankur
Hi Ankur: I'm still interested, but realistically I'm lacking the time for the next few weeks to even look at this again.
No worries, Dan, take your time. :)
Dan, JFYI: I'm updating pyton-rdflib in rawhide and I had to skip another subset of tests. I have a feeling that this will soon be needed for rdflib to work correctly. I haven't investigated much yet to see if rdflib currently works without it at least for other packages that depend on it.
SPEC: https://ignatenkobrain.fedorapeople.org/for-review/python-sparqlwrapper.spec SRPM: https://ignatenkobrain.fedorapeople.org/for-review/python-sparqlwrapper-1.8.0-1.fc26.src.rpm P.S. Miro, is it used only for test suite? Because I see that install_requires has rdflib, so it might introduce some circular dependency.
Igor, it is a dependency for some submodules in rdflib. Also used in build time in tests (currently those tests are skipped). BTW python-prov builds fine with rdflib without this.
When Anker said "take your time", I'm sure he didn't mean to take over a year. I've contributed a fair bit of effort upstream over the past year. At this point, I've been inactive long enough that it will take more time than I have to contribute usefully to this package, and don't want to block further progress on it.
(In reply to Dan Scott from comment #12) > When Anker said "take your time", I'm sure he didn't mean to take over a > year. I've contributed a fair bit of effort upstream over the past year. I didn't notice the year gap, I thought it was just couple months since November, sorry about that :)
Hi all, Should we close this as a WONTFIX so that someone else that wishes to package this up can do so? We haven't made much progress in a while :) Cheers!
I think that's the best plan, Ankur.