Bug 1089600 - recent upgrade breaks autocomplete
Summary: recent upgrade breaks autocomplete
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: autojump
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tomas Tomecek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-21 06:24 UTC by Sergio Basto
Modified: 2014-05-05 12:35 UTC (History)
4 users (show)

Fixed In Version: autojump-21.6.9-2.fc20
Clone Of:
Environment:
Last Closed: 2014-05-03 19:53:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Sergio Basto 2014-04-21 06:24:57 UTC
Description of problem:

j oneletter tab tab , is not working in last update of autojump , works with 

0:21.1.2-3.fc19

this a big regression for me .

Comment 1 Tomas Tomecek 2014-04-22 07:13:42 UTC
What shell do you use? Is /etc/profile.d/autojump.${SHELL} sourced? Can you provide me an output of these commands?

rpm -Vv autojump-21.6.9-1.fc20.noarch
shopt -s extdebug && declare -F j && shopt -u extdebug
autojump --complete ${YOUR_DIR}

Comment 2 Tomas Tomecek 2014-04-22 14:22:02 UTC
I have finally figured out where the problem is. The thing is that 

  autojump --complete --bash "dir"

encloses output in quotes and therefore completion cannot work.


I have issued a scratch build in koji:

http://koji.fedoraproject.org/koji/taskinfo?taskID=6764997

Could you please test whether this build fixes the issue? It does for me.

Comment 3 Fedora Update System 2014-04-23 08:34:51 UTC
autojump-21.6.9-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/autojump-21.6.9-2.fc20

Comment 4 Fedora Update System 2014-04-24 07:39:39 UTC
Package autojump-21.6.9-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing autojump-21.6.9-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-5534/autojump-21.6.9-2.fc20
then log in and leave karma (feedback).

Comment 5 Garrett Mitchener 2014-05-02 17:45:06 UTC
The update in comment #4 mostly works, but if you type 

j ABC[Tab]

and the path you choose has a space in it, as in '/home/me/My Stuff/ABC' it's no longer quoted when you choose it, and I think it used to be.

Comment 6 Fedora Update System 2014-05-03 19:53:00 UTC
autojump-21.6.9-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Tomas Tomecek 2014-05-05 07:13:32 UTC
(In reply to Garrett Mitchener from comment #5)
> The update in comment #4 mostly works, but if you type 
> 
> j ABC[Tab]
> 
> and the path you choose has a space in it, as in '/home/me/My Stuff/ABC'
> it's no longer quoted when you choose it, and I think it used to be.

I've just tested your usecase. It's correct what you are saying, but that doesn't break anything:


## I have a "/var/tmp/test asd" directory
/ $ ls -d /var/tmp/test\ asd/
/var/tmp/test asd/

## Lets jump in it
/ $ j asd
## After hitting tab it changed to
/ $ j /var/tmp/test asd 
/var/tmp/test asd

## now I'm in there
/var/tmp/test asd $


I've also tested it with upstream git and it's working the same way:

[root@localhost tmp]# mkdir "/var/tmp/test asd2"
[root@localhost tmp]# autojump -a /var/tmp/test\ asd2/
[root@localhost ~]# cd /
[root@localhost /]# j te__
te__1__/var/tmp/test asd2  te__2__/var/tmp/test asd2  
[root@localhost /]# j /var/tmp/test asd2 
/var/tmp/test asd2
[root@localhost test asd2]# 


I can report this upstream if you feel like this is a regression.

Comment 8 Garrett Mitchener 2014-05-05 12:35:38 UTC
You know, I'm such a programmer: It never occurred to me that jumping to such a directory might work without the quote. I guess it's okay then.


Note You need to log in before you can comment on or make changes to this bug.