Spec URL: http://ddick.fedorapeople.org/packages/perl-Crypt-SaltedHash.spec SRPM URL: http://ddick.fedorapeople.org/packages/perl-Crypt-SaltedHash-0.09-1.fc20.src.rpm Description: Perl interface to functions that assist in working with salted hashes Fedora Account System Username: ddick
koji builds at rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=6760790 el6 http://koji.fedoraproject.org/koji/taskinfo?taskID=6760786
corrected koji builds at rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=6760803 el6 http://koji.fedoraproject.org/koji/taskinfo?taskID=6760794
TODO: Fix a typo in the description, s/agorithms/algorithms/ TODO: Convert the line endings in Changes and README. TODO: Remove the Digest::SHA build-time dependency; it doesn't appear to be used at all during build. Keep the runtime dependency, though! Anyhow, no showstoppers. Approving.
Hi Petr, all fixed except for removing Digest::SHA as a build-time dependency. It gets used in rawhide in t/bug-localize-regex-vars.t as seen below. It's undetectable as the only place it is referenced is in Crypt::SaltedHash->new when the algorithm is not specified. PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01use.t .................... ok t/02pod.t .................... skipped: Test::Pod 1.14 required t/03podcoverage.t ............ skipped: Test::Pod::Coverage 1.04 required t/04Crypt-SaltedHash.t ....... ok # Failed test 'validate() lived even through non-match and $1 already set!' # at t/bug-localize-regex-vars.t line 19. # got: 'Can't locate Digest/SHA.pm in @INC (you may need to install the Digest::SHA module) (@INC contains: /builddir/build/BUILD/Crypt-SaltedHash-0.09/blib/lib /builddir/build/BUILD/Crypt-SaltedHash-0.09/blib/arch /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at /usr/share/perl5/vendor_perl/Digest.pm line 41. # ' # expected: undef # Looks like you failed 1 test of 3. t/bug-localize-regex-vars.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/bug-localize-regex-vars.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=5, Tests=10, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.11 cusr 0.01 csys = 0.16 CPU) Result: FAIL
New Package SCM Request ======================= Package Name: perl-Crypt-SaltedHash Short Description: Perl interface to functions that assist in working with salted hashes Owners: ddick Branches: f20 el6 epel7 InitialCC: perl-sig Thanks Petr!
(In reply to David Dick from comment #4) > Hi Petr, all fixed except for removing Digest::SHA as a build-time > dependency. It gets used in rawhide in t/bug-localize-regex-vars.t as seen > below. It's undetectable as the only place it is referenced is in > Crypt::SaltedHash->new when the algorithm is not specified. Yes, I saw this; however, I didn't notice it was called through validate() in t/bug-localize-regex-vars.t. My bad :)
Git done (by process-git-requests).
perl-Crypt-SaltedHash-0.09-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Crypt-SaltedHash-0.09-1.fc20
perl-Crypt-SaltedHash-0.09-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Crypt-SaltedHash-0.09-1.el6
perl-Crypt-SaltedHash-0.09-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
perl-Crypt-SaltedHash-0.09-1.fc20 has been pushed to the Fedora 20 stable repository.
perl-Crypt-SaltedHash-0.09-1.el6 has been pushed to the Fedora EPEL 6 stable repository.