Created attachment 888402 [details] use github sources and build highlight.pack.js Upstream suggests to use highlight.pack.js instead of plain highlight.js. ipython uses the highlight.pack.js, but that is not built in this package Please built the highlight.pack.js so one can directly use it instead of the (not recomment highlight.js). The attached patch builds the highlight.pack.js and copies it to the usual nodejs directory. (I am not sure, if there must be a "languages" subdirectory in the nodejs directory...)
Thanks for the bug report. This will require a js-highlight subpackage so that the highlight.pack.js file can be placed in the appropriate directory (according to web assets and javascript guidelines). I will also be including the stylesheets. The languages subdirectory is included in the npm tarball so I will retain it in the nodejs-highlight-js package. However, it's not possible to use your patch as this uses a bundled yuicompressor.jar to build the compressed files. I will be patching to use uglifyjs instead for compression. New builds to follow...
nodejs-highlight-js-7.5.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-highlight-js-7.5.0-3.fc20
nodejs-highlight-js-7.5.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-highlight-js-7.5.0-3.fc19
nodejs-highlight-js-7.3.0-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-highlight-js-7.3.0-4.el6
Package nodejs-highlight-js-7.5.0-3.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing nodejs-highlight-js-7.5.0-3.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-5673/nodejs-highlight-js-7.5.0-3.fc19 then log in and leave karma (feedback).
(In reply to Jamie Nguyen from comment #1) > This will require a js-highlight subpackage so that the highlight.pack.js > file can be placed in the appropriate directory (according to web assets and > javascript guidelines). I will also be including the stylesheets. > > The languages subdirectory is included in the npm tarball so I will retain > it in the nodejs-highlight-js package. > > However, it's not possible to use your patch as this uses a bundled > yuicompressor.jar to build the compressed files. I will be patching to use > uglifyjs instead for compression. Thanks for building the subpackage. Something still seems to be wrong (I don't know yet, if it is on the ipython side or not as I am just digging into JS for the first time...): Error: Cannot find module './javascript.js' at Function.Module._resolveFilename (module.js:338:15) at Function.Module._load (module.js:280:25) at Module.require (module.js:364:17) at require (module.js:380:17) at Object.eval (eval at <anonymous> (/home/tomspur/rpmbuild/BUILDROOT/ipython-2.0.0-2.fc20.x86_64/usr/lib/python3.3/site-packages/IPython/nbconvert/filters/marked.js:14:9), <anonymous>:641:32) at Object.<anonymous> (/home/tomspur/rpmbuild/BUILDROOT/ipython-2.0.0-2.fc20.x86_64/usr/lib/python3.3/site-packages/IPython/nbconvert/filters/marked.js:14:1) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) I don't find this reference to ./javascript.js anywhere -.-
That was my fault. Everything working now as expected. Thanks!
(In reply to Thomas Spura from comment #7) > That was my fault. > > Everything working now as expected. Thanks! Cool, glad it's working :)
nodejs-highlight-js-7.5.0-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
nodejs-highlight-js-7.5.0-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
nodejs-highlight-js-7.3.0-5.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.