Bug 1089950 - Review Request: perl-DB_File-Lock - Locking with flock wrapper for DB_File
Summary: Review Request: perl-DB_File-Lock - Locking with flock wrapper for DB_File
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ralf Corsepius
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-22 09:34 UTC by Xavier Bachelot
Modified: 2014-05-09 03:01 UTC (History)
2 users (show)

Fixed In Version: perl-DB_File-Lock-0.05-2.fc20
Clone Of:
Environment:
Last Closed: 2014-05-08 21:58:59 UTC
Type: ---
Embargoed:
rc040203: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Xavier Bachelot 2014-04-22 09:34:14 UTC
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-DB_File-Lock.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-DB_File-Lock-0.05-1.fc20.src.rpm
Description: Locking with flock wrapper for DB_File
Fedora Account System Username: xavierb

Comment 1 Ralf Corsepius 2014-04-22 09:55:19 UTC
* MUSTFIX: Missing BRs:

+BuildRequires:  perl(Carp)
+BuildRequires:  perl(DB_File)
+BuildRequires:  perl(Fcntl)
+BuildRequires:  perl(Symbol)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(vars)

* CONSIDER: You also can remove this line:
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;

Besides these, the package looks good.

Comment 2 Xavier Bachelot 2014-04-22 10:00:50 UTC
Thanks Ralf. Updated as you suggested.

Spec URL: http://www.bachelot.org/fedora/SPECS/perl-DB_File-Lock.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-DB_File-Lock-0.05-2.fc20.src.rpm

Comment 3 Ralf Corsepius 2014-04-22 12:53:26 UTC
APPROVED

Clean package, nothing much to say about it

PS: I wonder why somebody wants to add an old and presumably upstream dead package to Fedora :-)

Comment 4 Xavier Bachelot 2014-04-22 14:42:51 UTC
New Package SCM Request
=======================
Package Name: perl-DB_File-Lock
Short Description: Locking with flock wrapper for DB_File
Owners: xavierb
Branches: f20 el6 epel7
InitialCC: perl-sig


Thanks for the review Ralf. fwiw, I want to add this package because some other app depends on it.

Comment 5 Gwyn Ciesla 2014-04-22 15:49:46 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-04-23 08:53:55 UTC
perl-DB_File-Lock-0.05-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-DB_File-Lock-0.05-2.fc20

Comment 7 Fedora Update System 2014-04-23 08:54:33 UTC
perl-DB_File-Lock-0.05-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-DB_File-Lock-0.05-2.el6

Comment 8 Fedora Update System 2014-04-23 21:42:04 UTC
perl-DB_File-Lock-0.05-2.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 9 Fedora Update System 2014-05-08 21:58:59 UTC
perl-DB_File-Lock-0.05-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 10 Fedora Update System 2014-05-09 03:01:05 UTC
perl-DB_File-Lock-0.05-2.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.