Bug 1089962 - Review Request: radeontop - View GPU utilization of AMD/ATI Radeon devices [NEEDINFO]
Review Request: radeontop - View GPU utilization of AMD/ATI Radeon devices
Status: NEW
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-22 05:56 EDT by Fabian Deutsch
Modified: 2016-03-25 00:40 EDT (History)
7 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
luya: fedora‑review+
fdeutsch: needinfo? (fedora)


Attachments (Terms of Use)

  None (edit)
Description Fabian Deutsch 2014-04-22 05:56:55 EDT
Spec URL: https://raw.githubusercontent.com/fabiand/radeontop-spec/0.7-1/radeontop.spec
SRPM URL: http://fedorapeople.org/~fabiand/radeontop/radeontop-0.7-1.git20140421.eadc100.fc19.src.rpm
Description:
RadeonTop shows the utilization of your GPU, both in general and by blocks.
Supported cards are R600 and up.

Fedora Account System Username: fabiand
Comment 1 Fabian Deutsch 2014-04-22 05:58:27 EDT
$ rpmlint -v radeontop.spec ~/rpmbuild/SRPMS/radeontop-0.7-1.git20140421.eadc100.fc19.src.rpm ~/rpmbuild/RPMS/x86_64/radeontop-0.7-1.git20140421.eadc100.fc19.x86_64.rpm ~/rpmbuild/RPMS/x86_64/radeontop-debuginfo-0.7-1.git20140421.eadc100.fc19.x86_64.rpm
radeontop.spec: I: checking-url https://github.com/clbr/radeontop/archive/eadc100956fb5e346a4c5726453efd15fb2ec9f7/radeontop-0.7-eadc100.tar.gz (timeout 10 seconds)
radeontop.src: I: checking
radeontop.src: I: checking-url https://github.com/clbr/radeontop (timeout 10 seconds)
radeontop.src: I: checking-url https://github.com/clbr/radeontop/archive/eadc100956fb5e346a4c5726453efd15fb2ec9f7/radeontop-0.7-eadc100.tar.gz (timeout 10 seconds)
radeontop.x86_64: I: checking
radeontop.x86_64: I: checking-url https://github.com/clbr/radeontop (timeout 10 seconds)
radeontop-debuginfo.x86_64: I: checking
radeontop-debuginfo.x86_64: I: checking-url https://github.com/clbr/radeontop (timeout 10 seconds)
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
Comment 2 Michael Schwendt 2014-04-23 14:36:03 EDT
> %global gitversion .git%{commitdate}.%{shortcommit}
> Release:    1%{?gitversion}%{?dist}

%gitversion is somewhat in the wrong order:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
https://fedoraproject.org/wiki/Packaging:SourceURL#Github


> Group:      System Environment/Libraries

It's not a library. And the Group tag is optional nowadays:
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
/usr/share/doc/rpm/GROUPS


> BuildRequires: ncurses-devel
> BuildRequires: libpciaccess-devel

Relevant these days:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_based_on_pkg-config


> %build
> # configure doesn't exist, but we need the exported CFLAGS and friends
> %configure || :

You ought to compile in %build not in %install.


> %{_mandir}/man1/radeontop.1.gz

So far the manual pages are gzipped on-the-fly, but if you replace the ".gz" with "*" the packaging would allow for changed/disabled compression if man pages:

  %{_mandir}/man1/radeontop.1*
Comment 3 Björn "besser82" Esser 2014-04-23 15:52:16 EDT
taken  ;)  Will cycle through this tommorow morning!
Comment 4 Fabian Deutsch 2014-04-24 04:26:23 EDT
Thanks Michael!

I've updated the spec according to your comments:

Spec URL: https://raw.githubusercontent.com/fabiand/radeontop-spec/0.7-2/radeontop.spec
SRPM URL: http://fedorapeople.org/~fabiand/radeontop/radeontop-0.7-2.20140421giteadc100.fc19.src.rpm

$ rpmlint radeontop.spec \
  ~/rpmbuild/RPMS/x86_64/radeontop*0.7-2.20140421giteadc100.fc19.x86_64.rpm \
  ~/rpmbuild/SRPMS/radeontop-0.7-2.20140421giteadc100.fc19.src.rpm
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
Comment 5 Fabian Deutsch 2014-04-25 04:07:20 EDT
Rawhide scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=6777631
Comment 7 Fabian Deutsch 2015-02-16 08:12:14 EST
I missed to push the tags:, here is the commit: https://github.com/fabiand/radeontop-spec/commit/b48f8c2e7653b58431d42d40c4b49936eba6f91d
Comment 9 Fabian Deutsch 2015-03-18 09:24:16 EDT
Ping?
Comment 10 Antonio Trande 2015-03-18 09:32:23 EDT
Bjorn does not respond here since 1y almost.

In these cases:
http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
Comment 11 Michael Schwendt 2015-07-13 07:09:47 EDT
> Summary:    View GPU utilization off AMD/ATI Radeon devices

s/off/of/


> Group:      System Environment/Libraries

It's still not a library. ;)  

Repeating my earlier comment, you may want drop the optional Group tag or pick a more suitable group from /usr/share/doc/rpm/GROUPS.


> %install
> make install PREFIX=%{_prefix} DESTDIR=%{buildroot}

Something's broken here. This step recompiles the entire program using different flags as in %build.


> %doc README.md COPYING

Since early 2015, the guidelines want packagers to use the %license macro:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
Comment 12 Michael Schwendt 2015-08-12 08:26:39 EDT
--- radeontop.spec.orig	2015-02-16 12:21:43.000000000 +0100
+++ radeontop.spec	2015-08-12 14:24:43.849563292 +0200
@@ -2,12 +2,11 @@
 %global shortcommit %(c=%{commit}; echo ${c:0:7})
 %global checkout .20150215git%{shortcommit}
 
-Summary:    View GPU utilization off AMD/ATI Radeon devices
+Summary:    View GPU utilization of AMD/ATI Radeon devices
 Name:       radeontop
 Version:    0.8
 Release:    1%{?checkout}%{?dist}
 License:    GPLv3
-Group:      System Environment/Libraries
 URL:        https://github.com/clbr/%{name}
 
 Source0:    %{url}/archive/%{commit}/%{name}-%{version}-%{shortcommit}.tar.gz
@@ -25,6 +24,7 @@
 
 %prep
 %setup -q -n %{name}-%{commit}
+mkdir .git
 
 
 %build
@@ -43,7 +43,8 @@
 
 
 %files -f %{name}.lang
-%doc README.md COPYING
+%doc README.md
+%license COPYING
 %{_sbindir}/radeontop
 %{_mandir}/man1/radeontop.1*
Comment 13 Michael Schwendt 2015-08-12 09:07:33 EDT
# radeontop -v
RadeonTop 

indicates that not deleting the ".git" directory may be required when wrapping up the source tarball. Else the Makefile cannot retrieve the version.
Comment 14 Dominik 'Rathann' Mierzejewski 2016-03-14 11:59:19 EDT
Any update here? I actually have the hardware to test this, so it'd be nice to have in Fedora.
Comment 15 Luya Tshimbalanga 2016-03-20 03:18:23 EDT
I am interested as well having a AMD APU powered laptop. I will review it once I get the change to read the spec file.
Comment 16 Fabian Deutsch 2016-03-21 06:36:30 EDT
Feel free to fork the spec file.

It should be fairly ready, it just needs to make the last 2meters (in a metric system).
Comment 17 Luya Tshimbalanga 2016-03-25 00:40:36 EDT
(In reply to Fabian Deutsch from comment #16)
> Feel free to fork the spec file.
> 
> It should be fairly ready, it just needs to make the last 2meters (in a
> metric system).

Attempting to use fedora-review command result with the following build.log error:

Processing files: radeontop-debuginfo-0.8-1.20150215git281462c.fc23.x86_64
RPM build errors:
error: Empty %files file /builddir/build/BUILD/radeontop-281462c0943486170ef7b2451d1c3c38268c3484/debugfiles.list
    Empty %files file /builddir/build/BUILD/radeontop-281462c0943486170ef7b2451d1c3c38268c3484/debugfiles.list
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps  /builddir/build/SPECS/radeontop.spec 
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/mockbuild/trace_decorator.py", line 88, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.4/site-packages/mockbuild/util.py", line 547, in do
    raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
mockbuild.exception.Error: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps  /builddir/build/SPECS/radeontop.spec 
LEAVE do --> EXCEPTION RAISED

Note You need to log in before you can comment on or make changes to this bug.