Bug 1090053 - Incorrect naming of resteasy-spring.jar file
Summary: Incorrect naming of resteasy-spring.jar file
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Build
Version: 6.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ER10
: EAP 6.3.0
Assignee: Stuart Douglas
QA Contact: Katerina Odabasi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-22 13:16 UTC by Nikoleta Hlavickova
Modified: 2015-02-20 10:21 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-06 14:34:19 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1064320 0 unspecified CLOSED Missing EAP jars from Maven repo zip for EAP 6.3.0 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1090057 0 unspecified CLOSED Incorrect naming of jboss-seam-int.jar file 2021-02-22 00:41:40 UTC
Red Hat Issue Tracker WFLY-3366 0 Major Resolved Include version number in resteasy-spring jar 2014-09-05 12:13:29 UTC

Internal Links: 1064320 1090057

Description Nikoleta Hlavickova 2014-04-22 13:16:31 UTC
modules/system/layers/base/org/jboss/resteasy/resteasy-spring/main/bundled/resteasy-spring.jar

The jar name is not consistent with EAP jar files naming. It should contain substring "version-redhat-XY"

Comment 1 Paul Gier 2014-05-14 14:17:04 UTC
Assigning to Stuart since he added this jar with the unversioned filename.

Comment 2 Rostislav Svoboda 2014-05-16 06:59:01 UTC
I think we need to know:

Stuart:
 - can it be renamed to follow -redhat-XX naming without any problem in integration == code doesn't contain hardcoded file name

Paul:
 - is it built from sources when is EAP productized or is it downloaded from somewhere

I really want to have it renamed with -redhat-XX convention to stay consistent with the rest of jar files in EAP zip. We need to know if that is possible without any impact.

Comment 3 Paul Gier 2014-05-16 12:48:13 UTC
Yes, it is built from sources with the resteasy project.  The version downloaded during the build is the same as the other resteasy jars.

Comment 4 Stuart Douglas 2014-05-16 13:13:43 UTC
This jar is referenced directly from the integration code, which is why the version was removed to allow the code to work no matter what version is in use. 

I will have a look and see if it is easy to make it work with a version.

Comment 5 Stuart Douglas 2014-05-16 14:08:51 UTC
Upstream change is here: https://issues.jboss.org/browse/WFLY-3366

Note that there is a risk associated with this, as tests for this feature were never added to the EAP6 code base, instead there is a test that lives in an old Resteasy branch that is not run by default.

Comment 8 Fernando Nasser 2014-06-04 21:57:41 UTC
Hi Stuart,

This change breaks the RPM case where the symlinks are unversioned (so that the destination can be upgraded).

We can easily revert the change to build/build.xml when we prepare the ZIP for the RPMs but the name of the JAR is hardcoded in 

org/jboss/as/jaxrs/deployment/JaxrsSpringProcessor.java

We'd need a small change there for it to look for the unversioned name if, for instance, the property resteasy.version is not set.  We could remove from the RPM distro the file

org/jboss/as/jaxrs/spring-version.properties

to get that property unset.  We cannot just do that now because a '-' will be added at the end always.

Best regards,
Fernando

Comment 10 Kabir Khan 2014-06-05 14:08:30 UTC
A test as per https://bugzilla.redhat.com/show_bug.cgi?id=1090053#c5 should help guard against problems in the future

Comment 11 Nikoleta Hlavickova 2014-06-18 08:05:38 UTC
Verified with EAP 6.3.0.ER7.

Comment 12 Kabir Khan 2014-06-23 18:56:12 UTC
https://github.com/jbossas/jboss-eap/pull/1428 does this better, moving back to MODIFIED for ER9 on Fernando's request

Comment 13 Kabir Khan 2014-07-08 15:01:22 UTC
PR 1428 causes the regression in https://bugzilla.redhat.com/show_bug.cgi?id=1117245, for which https://github.com/jbossas/jboss-eap/pull/1504 has been created.

Comment 14 Katerina Odabasi 2014-07-09 07:04:26 UTC
Postponed to ER10 due to regression found https://bugzilla.redhat.com/show_bug.cgi?id=1117245.

Comment 15 Katerina Odabasi 2014-07-18 10:54:06 UTC
Verified in EAP 6.3.0.ER10.


Note You need to log in before you can comment on or make changes to this bug.