Bug 1090386 - Project editor: misleading conflict modal when saving changes
Summary: Project editor: misleading conflict modal when saving changes
Keywords:
Status: CLOSED EOL
Alias: None
Product: JBoss BRMS Platform 6
Classification: Retired
Component: Business Central
Version: 6.0.2
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: DR2
: 6.1.0
Assignee: Alexandre Porcelli
QA Contact: Lukáš Petrovický
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-23 08:33 UTC by Zuzana Krejčová
Modified: 2020-03-27 19:42 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-27 19:42:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Zuzana Krejčová 2014-04-23 08:33:13 UTC
Description of problem:
When saving changes made to a project for the second time, user gets Conflict Error modal: "User has updated the following resource default://master@<repo>/<project>/pom.xml."
1st and main issue is that only this one user was making the changes and so there is no conflict.
2nd issue is that the Conflict Error modal message doesn't specify which user has made the changes.


Version-Release number of selected component (if applicable):
BPMS 6.0.2 ER1


Steps to Reproduce:
1. Open the Project Editor.
2. Change project version and save.
3. repeat step 2.


Actual results:
Error modal warning about a conflict.


Expected results:
Changes are saved, no conflict.
(In case of actual conflict, the message informs which user has made the changes as well.)

Comment 1 Toni Rikkola 2014-04-25 10:03:57 UTC
Looks like the patch commit, that is used to commit all the files Project Editor edits, does not use the same session ID as the current session. The id there is "<system>" instead of a generated hash.
If the session ID's do not match, then the we fire a concurrent edit event that causes this message.

I'm pretty sure this is a bug in UF. Going to take a look at it next.

Comment 2 manstis 2014-05-23 14:50:18 UTC
I can verify Toni's investigations. 

A VFS "batch" operation is not setting the SessionId in the WatchContext so a default of "<system>" is being used which causes the client-side optimistic concurrent lock mechanism to incorrectly report the file has been saved by another user.

Batches of 1 or more changes are affected.

Would you mind taking a look?

Comment 3 Alexandre Porcelli 2014-06-16 22:27:13 UTC
Fix pushed to uberfire:

(master) http://github.com/uberfire/uberfire/commit/c889ea053


Note You need to log in before you can comment on or make changes to this bug.