Bug 1090407 - hivex test failure after upgrade rubygem-minitest 5.3.1
Summary: hivex test failure after upgrade rubygem-minitest 5.3.1
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: hivex
Version: rawhide
Hardware: ppc64le
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F-ExcludeArch-ppc64le, PPC64LETracker
TreeView+ depends on / blocked
 
Reported: 2014-04-23 09:18 UTC by Michel Normand
Modified: 2014-04-23 15:10 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-04-23 15:10:20 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
hivex-with-rubygem-minitestV5.patch (6.26 KB, text/x-c)
2014-04-23 09:18 UTC, Michel Normand
no flags Details

Description Michel Normand 2014-04-23 09:18:29 UTC
Created attachment 888822 [details]
hivex-with-rubygem-minitestV5.patch

Description of problem: hivex make check is failing after upgrade rubygem-minitest 5.3.1


Version-Release number of selected component (if applicable):
/hivex-1.3.9-2.fc21

How reproducible:
$mock --no-clean --with=check ./hivex-1.3.9-2.fc21.src.rpm
===
/usr/share/ruby/test/unit.rb:670:in `<class:Runner>': undefined method `_run_suite' for class `Test::Unit::Runner' (NameError)
===
...
rake test TEST=./tests/tc_010_load.rb
Warning: you should require 'minitest/autorun' instead.
Warning: or add 'gem "minitest"' before 'require "minitest/autorun"'
From:
  /usr/share/ruby/test/unit.rb:3:in `<top (required)>'
  /builddir/build/BUILD/hivex-1.3.9/ruby/tests/tc_010_load.rb:18:in `<top (required)>'
  /usr/share/gems/gems/rake-10.0.4/lib/rake/rake_test_loader.rb:15:in `block in <main>'
  /usr/share/gems/gems/rake-10.0.4/lib/rake/rake_test_loader.rb:4:in `select'
  /usr/share/gems/gems/rake-10.0.4/lib/rake/rake_test_loader.rb:4:in `<main>'
MiniTest::Unit::TestCase is now Minitest::Test. From /usr/share/ruby/test/unit/testcase.rb:8:in `<module:Unit>'
/usr/share/ruby/test/unit.rb:670:in `<class:Runner>': undefined method `_run_suite' for class `Test::Unit::Runner' (NameError)
        from /usr/share/ruby/test/unit.rb:255:in `<module:Unit>'
        from /usr/share/ruby/test/unit.rb:9:in `<module:Test>'
        from /usr/share/ruby/test/unit.rb:8:in `<top (required)>'
        from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
        from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
        from /builddir/build/BUILD/hivex-1.3.9/ruby/tests/tc_010_load.rb:18:in `<top (required)>'
        from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
        from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
        from /usr/share/gems/gems/rake-10.0.4/lib/rake/rake_test_loader.rb:15:in `block in <main>'
        from /usr/share/gems/gems/rake-10.0.4/lib/rake/rake_test_loader.rb:4:in `select'
        from /usr/share/gems/gems/rake-10.0.4/lib/rake/rake_test_loader.rb:4:in `<main>'
===

The attached hivex-with-rubygem-minitestV5.patch is a proposed correction
similar to what is already done for libguestfs ref in RHBZ #1085029

Comment 1 Richard W.M. Jones 2014-04-23 11:07:53 UTC
See equivalent libguestfs changes for new minitest:

https://www.redhat.com/archives/libguestfs/2014-April/thread.html#00049

Comment 2 Pino Toscano 2014-04-23 13:38:04 UTC
Thanks for the heads-up, I just ported the fixes in libguestfs to hivex.

https://github.com/libguestfs/hivex/commit/014a4acf2c5fa7f1169b2db6dbe917d75182f61d
https://github.com/libguestfs/hivex/commit/3f3bc6af076ce2dd56e9613eb47302f0cfdc3e37
fix the issue in upstream hivex >= 1.3.10.

Comment 3 Richard W.M. Jones 2014-04-23 15:06:09 UTC
1.3.10 has been uploaded here:
http://libguestfs.org/download/hivex/

Comment 4 Richard W.M. Jones 2014-04-23 15:10:20 UTC
Should be fixed in:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6769766


Note You need to log in before you can comment on or make changes to this bug.