Bug 1090807 - Remove autogenerated xdr routines and coroutines
Summary: Remove autogenerated xdr routines and coroutines
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: rpc
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Harshavardhana
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-04-24 08:19 UTC by Harshavardhana
Modified: 2015-03-23 01:04 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Clone Of:
Environment:
Last Closed: 2014-11-11 08:30:45 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Harshavardhana 2014-04-24 08:19:45 UTC
Description of problem:

http://review.gluster.org/#/c/7526/  - this is a proposal to add a
build time dependency on 'rpcgen' and get the files for XDR routines
and co-routines generated during build time and avoid having them in
the repository.

This is due to a fact that i observed recently that we have been
modifying the auto-generated files alone rather than making respective
changes in ".x"

For example at commit "29bccc2ed18eedc40e83d2f0d35327037a322384"  -
this results in two things which leads to other infinite things

- Divergent of ".x" files for future use and inconsistent codebase
which is one of the most important pieces of the overall
functionality.

- ill informed person like me making changes and not able to figure
out where the hell build error is coming from.


Version-Release number of selected component (if applicable):
mainline

Comment 1 Anand Avati 2014-04-24 08:20:50 UTC
REVIEW: http://review.gluster.org/7526 (rpcgen: Remove autogenerated files instead build on demand) posted (#5) for review on master by Harshavardhana (harsha)

Comment 2 Anand Avati 2014-04-24 22:45:15 UTC
REVIEW: http://review.gluster.org/7526 (rpcgen: Remove autogenerated files instead build on demand) posted (#6) for review on master by Harshavardhana (harsha)

Comment 3 Anand Avati 2014-04-25 20:29:31 UTC
COMMIT: http://review.gluster.org/7526 committed in master by Anand Avati (avati) 
------
commit 9819fcedf10f1430d4969c86e6df4dfe975b7dcf
Author: Harshavardhana <harsha>
Date:   Tue Apr 22 13:27:35 2014 -0700

    rpcgen: Remove autogenerated files instead build on demand
    
    Avoid modifying autogenerated files and keeping them in
    repository - autogenerate them on demand from ".x" files
    
    Change-Id: I2cdb1fe9b99768ceb80a8cb100fa00bd1d8fe2c6
    BUG: 1090807
    Signed-off-by: Harshavardhana <harsha>
    Reviewed-on: http://review.gluster.org/7526
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Anand Avati <avati>

Comment 4 Anand Avati 2014-04-25 23:19:42 UTC
REVIEW: http://review.gluster.org/7566 (rpcgen: 'hyper' is 64bit undefined on Darwin use quad_t) posted (#1) for review on master by Harshavardhana (harsha)

Comment 5 Anand Avati 2014-04-26 06:01:29 UTC
COMMIT: http://review.gluster.org/7566 committed in master by Anand Avati (avati) 
------
commit 447f4dec70a8103fc188024ea76447425cf14c60
Author: Harshavardhana <harsha>
Date:   Fri Apr 25 16:08:09 2014 -0700

    rpcgen: 'hyper' is 64bit undefined on Darwin use quad_t
    
    "9819fcedf10f1430d4969c86e6df4dfe975b7dcf" After the commit i
    observed that we never used "hyper" as defined in .x previously
    in the .[c,h] files.
    
    Change-Id: I26152141bca6e789c4a3b3158fffe0a65e4b0878
    BUG: 1090807
    Signed-off-by: Harshavardhana <harsha>
    Reviewed-on: http://review.gluster.org/7566
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 6 Anand Avati 2014-04-27 03:49:36 UTC
REVIEW: http://review.gluster.org/7572 (rpcgen: After recent changes parallel builds failed) posted (#1) for review on master by Harshavardhana (harsha)

Comment 7 Anand Avati 2014-04-27 05:40:29 UTC
REVIEW: http://review.gluster.org/7572 (rpcgen: After recent changes parallel builds failed) posted (#2) for review on master by Harshavardhana (harsha)

Comment 8 Anand Avati 2014-04-27 17:41:18 UTC
COMMIT: http://review.gluster.org/7572 committed in master by Anand Avati (avati) 
------
commit f77e5b6ebe5d702065844db141ebd38ff7802168
Author: Harshavardhana <harsha>
Date:   Sat Apr 26 20:19:38 2014 -0700

    rpcgen: After recent changes parallel builds failed
    
    Parallel builds failed due to make file would overrun
    xdrgen (internally xdrgen uses tempfiles to add License
    header).
    
    Seperate out header and source generation and add explicit
    dependency to fix it.
    
    Change-Id: Id20f548493540b0f17a2300f0775646f9f20789c
    BUG: 1090807
    Signed-off-by: Harshavardhana <harsha>
    Reviewed-on: http://review.gluster.org/7572
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 9 Niels de Vos 2014-09-22 12:38:44 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 10 Niels de Vos 2014-11-11 08:30:45 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.