Bug 1091069 - Use system qtsingleapplication instead of bundled one
Summary: Use system qtsingleapplication instead of bundled one
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: texmaker
Version: rawhide
Hardware: All
OS: All
unspecified
unspecified
Target Milestone: ---
Assignee: Mukundan Ragavan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DuplicSysLibsTracker
TreeView+ depends on / blocked
 
Reported: 2014-04-24 19:01 UTC by Ville Skyttä
Modified: 2014-12-07 04:02 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-07 04:02:29 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Use system qtsingleapplication instead of bundled one (3.94 KB, patch)
2014-04-24 19:01 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2014-04-24 19:01:09 UTC
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
https://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries

'git am'able fix attached, build tested only. Let me know if you'd
like me to push and build this for devel.

Comment 1 Ville Skyttä 2014-04-24 19:01:13 UTC
Created attachment 889409 [details]
Use system qtsingleapplication instead of bundled one

Comment 2 Deji Akingunola 2014-05-20 04:02:33 UTC
Thank you for submitting this bug and providing a patch.

I have attempted to apply the patch while updating the package to the latest upstream release. But it failed to build with the patch because the current (as at this time) qtsinglespplication in Fedora is not built with Qt5. So I have disabled the patch, but will continue to monitor the system's qtsingleapplication for when it provides support for Qt5.

Comment 3 Ville Skyttä 2014-05-20 06:44:16 UTC
The other allowed alternative to getting rid of the bundling is to get an exception from FPC and mark it as appropriate in the package.

https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions

Comment 4 Fedora Admin XMLRPC Client 2014-07-26 17:13:25 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 5 Fedora Admin XMLRPC Client 2014-07-26 19:49:47 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 6 Mukundan Ragavan 2014-07-27 03:34:21 UTC
I will look into this.

Comment 7 Mukundan Ragavan 2014-08-10 22:42:43 UTC
I am unable to compile with system qtsingleapplication yet. I will get this fixed as soon as I can.


In file included from texmakerapp.h:18:0,
                 from main.cpp:15:
/usr/include/QtSolutions/qtsingleapplication.h:75:49: error: 'Type' has not been declared
     QtSingleApplication(int &argc, char **argv, Type type);
                                                 ^
Makefile:1945: recipe for target '.obj/main.o' failed
make: *** [.obj/main.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from texmakerapp.h:18:0,
                 from texmakerapp.cpp:21:
/usr/include/QtSolutions/qtsingleapplication.h:75:49: error: 'Type' has not been declared
     QtSingleApplication(int &argc, char **argv, Type type);
                                                 ^
Makefile:1986: recipe for target '.obj/texmakerapp.o' failed


Any input is welcome! Thanks.

Comment 8 Mukundan Ragavan 2014-12-07 04:02:29 UTC
Fixed in rawhide.


Note You need to log in before you can comment on or make changes to this bug.