Bug 1091125 - Add a patch to support building with new gflags
Summary: Add a patch to support building with new gflags
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: glog
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: John Khvatov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1091043
TreeView+ depends on / blocked
 
Reported: 2014-04-25 00:05 UTC by Christopher Meng
Modified: 2014-06-10 02:42 UTC (History)
4 users (show)

Fixed In Version:
Clone Of: 1091043
Environment:
Last Closed: 2014-05-01 18:15:24 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Christopher Meng 2014-04-25 00:05:53 UTC
+++ This bug was initially created as a clone of Bug #1091043 +++

The version of Google gflags shipped with Fedora is archaic - version 1.3 which was shipped in 2010. This is srpm for 2.1.1 which is the latest.

Also included is a new build of glog with a patch that enables building against the new gflags. The patch has been submitted upstream, but it looks like they don't pay any attention to their issue tracker. [1] :/

[1] http://code.google.com/p/google-glog/issues/list

Comment 1 John Khvatov 2014-04-28 17:51:56 UTC
I applied provided patch from #1091043 with this change:
<pre>
-BuildRequires:  autoconf, gflags >= 2.1.0
+BuildRequires:  autoconf, gflags-devel >= 2.1.0
</pre>

http://pkgs.fedoraproject.org/cgit/glog.git/log/?h=feature-gflags2

But scratch build failed in f21 because of gflags version:
<pre>
DEBUG util.py:281:  Error: No Package found for gflags-devel >= 2.1.0
</pre>

More logs: http://koji.fedoraproject.org/koji/taskinfo?taskID=6791526

BTW, is it okay that we broke compatibility with gflags 1.3?

Comment 2 Dan Fuhry 2014-04-28 18:20:48 UTC
Updated gflags srpm is at Bug #1091043.

I personally am not concerned with breaking gflags 1.3 compatibility - that release is over 4 years old.

Comment 3 John Khvatov 2014-04-28 18:58:45 UTC
Ok. I'll contact with Peter Lemenkov about gflags update.

Comment 4 Dan Fuhry 2014-04-28 19:04:42 UTC
Just FYI, I emailed him a few days ago (Thursday April 24) and have not yet received a response.

Comment 5 John Khvatov 2014-05-01 18:15:24 UTC
glog rebuild with gflags 2.1.1: http://koji.fedoraproject.org/koji/taskinfo?taskID=6803937


Note You need to log in before you can comment on or make changes to this bug.