Bug 1091215

Created attachment 889561 [details]
reproducer

Description of problem:

Weld associates contexts with requests in its WeldListener. If an application contains its own buggy ServletRequestListener which throws exception, the thread will not disassociate the contexts from the thread, as WeldListener requestDestroyed will not be called.

This may cause weird problems when such broken thread eventually handles a different request, such as accessing different user's session. 

Version-Release number of selected component (if applicable):
6.3.0.ER2 (likely all EAP 6.x versions)

How reproducible:
Hardly

Steps to Reproduce:
1. Setup an executor with a single thread to make this problem easily reproducible, e.g.:

<subsystem xmlns="urn:jboss:domain:threads:1.1">
            <bounded-queue-thread-pool name="http-executor">
                <core-threads count="1"/>
                <queue-length count="1"/>
                <max-threads count="1"/>
                <keepalive-time time="10" unit="seconds"/>
            </bounded-queue-thread-pool>
        </subsystem>


<connector name="http" protocol="HTTP/1.1" scheme="http" socket-binding="http" executor="http-executor"/>

2. Deploy the attached reproducer
3. Open two browsers (two user sessions), e.g. Firefox and Chrome:

firefox: open 
http://127.0.0.1:8080/jboss-as-helloworld/Login?id=foo

chrome: open
http://127.0.0.1:8080/jboss-as-helloworld/Login?id=bar

chrome: open
http://127.0.0.1:8080/jboss-as-helloworld/Fail

(this will result in an expected HTTP 500 error)

firefox: open 
http://127.0.0.1:8080/jboss-as-helloworld/HelloWorld

Actual results:
Page will say "Hello bar"

Expected results:
Page should say "Hello foo"

Additional info:

Doesn't seem to be a problem on Undertow on current Wildfly 7.1.0.CR1.