Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1091364

Summary:	server: Setting server.outstanding-rpc-limit misses validation and help displays NULL
Product:	[Community] GlusterFS	Reporter:	santosh pradhan <spradhan>
Component:	protocol	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-bugs, vagarwal
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-11 08:30:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description santosh pradhan 2014-04-25 12:32:08 UTC

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. gluster v set nfsperf server.outstanding-rpc-limit -1
2. gluster v set help |grep outstanding 
3.

Actual results:


Expected results:
1. gluster v set nfsperf server.outstanding-rpc-limit -1 should FAIL.

2. gluster v set help should display description for "server.outstanding-rpc-limit" option.

Additional info:

Comment 1 Anand Avati 2014-04-25 12:40:22 UTC

REVIEW: http://review.gluster.org/7562 (protocol/server: Validate outstanding-rpc-limit) posted (#1) for review on master by Santosh Pradhan (spradhan)

Comment 2 Anand Avati 2014-05-02 05:37:29 UTC

REVIEW: http://review.gluster.org/7562 (protocol/server: Validate outstanding-rpc-limit) posted (#2) for review on master by Santosh Pradhan (spradhan)

Comment 3 Anand Avati 2014-05-03 19:43:31 UTC

COMMIT: http://review.gluster.org/7562 committed in master by Anand Avati (avati) 
------
commit 49d235361cb42746329453121e83beeb7fe611e5
Author: Santosh Kumar Pradhan <spradhan>
Date:   Fri Apr 25 18:04:08 2014 +0530

    protocol/server: Validate outstanding-rpc-limit
    
    server.outstanding-rpc-limit by passes validation enforcement of gluster
    as protocol/server ignores any keys starting with rpc (rpc* wildcard).
    Which also causes a side effect, i.e. help text gets displayed as NULL.
    
    Change-Id: I925e028529d671e1e29a0c7ff7e625fdb49a1be4
    BUG: 1091364
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/7562
    Reviewed-by: Poornima G <pgurusid>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 6 Niels de Vos 2014-09-22 12:38:52 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 7 Niels de Vos 2014-11-11 08:30:51 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users